From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2786AC433B4 for ; Mon, 10 May 2021 18:04:38 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BE6A614A5 for ; Mon, 10 May 2021 18:04:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BE6A614A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dL3GnaSNjPp6lBpZ5HqBM6wH5Wxv9f/QwkfbcmKAMnE=; b=G8cHEBnNAsUdlIWt+VRKROi8j cN9uuXJVbbJ4Z5Jcorrk6QViTdpZaIE5eV/60+Rbrt49DTZxapSCHmmP9P/jQ9S5V7XszgrJjLWxm a6zTkEgWfK2fQSWcnOCPfm232BkwAWw/mKrSE9egND7nNCbsvj/zc+jRKXINc4WoaLWbi6JZZRRpG PbPi1+61ZvOtsUOFyLLFeNdULVaFC74H3nplYDLP44bzX+gX0xy5rCEGGff2AVrlgR1KERB6bE7T5 m+Xm/ryAYqaQrdLgmxLmVa0y63Pz/pT1J3qj6T2a3dfd3JtS0dYpvEy4AVB908QfwK2/+NzdCjJYd mYgt2+lag==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgAFK-00FLaB-Qb; Mon, 10 May 2021 18:03:12 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg9wx-00FEre-7i for linux-arm-kernel@desiato.infradead.org; Mon, 10 May 2021 17:44:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=s5lmK1+OZLwxBU1OoSI15fp+aIvsLBGSfbw/McbfXvs=; b=4gFN/RBLufoqIh/wOHXihDxj0V /3nKQlZsZREBHK+zsifNx6tBNPrnAt2HJpLF3o+JNtZ+VZSKI0syQHz8j6DTqEV917QnL714fradX z4f4CbA9c7+bDq4xMzhA+iMfvYzskXgg0chrw7li5f64iBJhxwTIwVmJzs9IaS+imaQnS9zYT9kdS IPQoshRM/OgeQgeCoNrSEv+fiYEVvFXWR7uzFlf09B6s7kafOC8wZTinI1jRK0as1Xf54OgxmgMV4 A4OE9boxBkTyjd4aO2+YTLqQPpjmpg3XmTHv5l5LXpOTjY8PGl+OJc1SgMSPs29MTnxx21XfS4kfl V4T48udA==; Received: from mail-pg1-f178.google.com ([209.85.215.178]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg9wu-008zsU-Jd for linux-arm-kernel@lists.infradead.org; Mon, 10 May 2021 17:44:10 +0000 Received: by mail-pg1-f178.google.com with SMTP id q15so9595704pgg.12 for ; Mon, 10 May 2021 10:44:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=s5lmK1+OZLwxBU1OoSI15fp+aIvsLBGSfbw/McbfXvs=; b=SEBLz77WKXnFYB5zfM3AQ4U8Q6cT+YHDVd5CXIwjJvj7QyBgKJyhlzk6YW4uD8iyHT aVGYFXfe+2WsUBuNmQzycaWSmnUCqPbfFtMpFwFzQ0cIDJfuuJ0S2jL/LHl0r4jYjyE1 mfWWuojwZ/BisBqMXX7ZlgDBkOZvQ5ky6yXSIQj6lN4XR77bK9tAy0o7qObVp88fDGSE xjWZLIwVmehfQ3JANjeG3n7LOinmj/te/Ct9iZnWvhWj4wofcw1uShVradGFOcqtNmr5 Cx+HWUAgW2LMl1kgclGPVv6R7xIGfV37YcM80ubWZe8ds3+BdPcm9EqEwr5rLi3Qwnrg seTg== X-Gm-Message-State: AOAM531ctKs4WGay/rsaqZPrFEtIhz2+GlUgCKLMTRgSlrp2SrT6gBgc nhlnrBl8x4w80u1/ku4cwBE= X-Google-Smtp-Source: ABdhPJw1Ep+d8PgXoQHvR+7kiCh1SLIFNgftTmuA/rMKH27jgP9UTxB7p8JfQv142Lj38pLDQJ9Xrg== X-Received: by 2002:a62:ea10:0:b029:25a:9902:43f3 with SMTP id t16-20020a62ea100000b029025a990243f3mr26075477pfh.68.1620668646731; Mon, 10 May 2021 10:44:06 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id 33sm11538907pgq.21.2021.05.10.10.44.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 May 2021 10:44:06 -0700 (PDT) Date: Mon, 10 May 2021 10:44:05 -0700 From: Moritz Fischer To: Nava kishore Manne Cc: Moritz Fischer , "trix@redhat.com" , "robh+dt@kernel.org" , Michal Simek , "linux-fpga@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , git , "chinnikishore369@gmail.com" Subject: Re: [PATCH 1/2] fpga: mgr: Adds secure BitStream loading support Message-ID: References: <20210118025058.10051-1-nava.manne@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_104408_667649_1ABE9255 X-CRM114-Status: GOOD ( 24.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 03, 2021 at 10:11:51AM +0000, Nava kishore Manne wrote: > Ping! > > > -----Original Message----- > > From: Nava kishore Manne > > Sent: Wednesday, January 27, 2021 2:43 PM > > To: Moritz Fischer > > Cc: trix@redhat.com; robh+dt@kernel.org; Michal Simek > > ; linux-fpga@vger.kernel.org; > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org; git ; chinnikishore369@gmail.com > > Subject: RE: [PATCH 1/2] fpga: mgr: Adds secure BitStream loading support > > > > Hi Moritz, > > > > Thanks for the review. > > Please find my response inline. > > > > > -----Original Message----- > > > From: Moritz Fischer > > > Sent: Friday, January 22, 2021 10:47 AM > > > To: Nava kishore Manne > > > Cc: mdf@kernel.org; trix@redhat.com; robh+dt@kernel.org; Michal Simek > > > ; linux-fpga@vger.kernel.org; > > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > > linux- kernel@vger.kernel.org; git ; > > > chinnikishore369@gmail.com > > > Subject: Re: [PATCH 1/2] fpga: mgr: Adds secure BitStream loading > > > support > > > > > > On Mon, Jan 18, 2021 at 08:20:57AM +0530, Nava kishore Manne wrote: > > > > This commit adds secure flags to the framework to support secure > > > > BitStream Loading. > > > > > > > > Signed-off-by: Nava kishore Manne > > > > --- > > > > drivers/fpga/of-fpga-region.c | 10 ++++++++++ > > > > include/linux/fpga/fpga-mgr.h | 12 ++++++++++++ > > > > 2 files changed, 22 insertions(+) > > > > > > > > diff --git a/drivers/fpga/of-fpga-region.c > > > > b/drivers/fpga/of-fpga-region.c index e405309baadc..3a5eb4808888 > > > > 100644 > > > > --- a/drivers/fpga/of-fpga-region.c > > > > +++ b/drivers/fpga/of-fpga-region.c > > > > @@ -228,6 +228,16 @@ static struct fpga_image_info > > > *of_fpga_region_parse_ov( > > > > if (of_property_read_bool(overlay, "encrypted-fpga-config")) > > > > info->flags |= FPGA_MGR_ENCRYPTED_BITSTREAM; > > > > > > > > + if (of_property_read_bool(overlay, "userkey-encrypted-fpga- > > > config")) > > > > + info->flags |= > > > FPGA_MGR_USERKEY_ENCRYPTED_BITSTREAM; > > > > > > Can this just be encrypted-fpga-config/FPGA_MGR_ENCRYPTED? > > > > In Encryption we have two kinds of use case one is Encrypted Bitstream > > loading with Device-key and Other one is Encrypted Bitstream loading with > > User-key. To differentiate both the use cases this Changes are needed. > > > > Regards, > > Navakishore. Is this region specific, or could this be a sysfs attribute? - Moritz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel