From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F8A5C433B4 for ; Wed, 12 May 2021 00:57:49 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC4AA617C9 for ; Wed, 12 May 2021 00:57:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC4AA617C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rTVvevMv1H79SIUVsZ2DpmG4lmdR/0qmyN4Ktoth++Q=; b=DR8b4+/Jg++LkEU+S3t63qvhB o0OKzgjkUFEcQ2vcipzyuG60N8wvepDf3i1ycimciElcCcaCj0r4GaBMgr2gSlaxIiv0FWC+2Dag0 nrrjHUq3wlgqt+DQpSA416fUZizIWNfERsD7yPNTURkv0HIj71zhU9fg8cv2ZH8CztIgax9cEcbeh liGMqIuQ0gWolI4o/b6e4AdBw/Uh6JhgaCSvMTl5zVYIFptglQSlsuPE4lbIvsrAzOpfxNHT/gLYo 4KaiGO4gSQeP6BHhLJIacwyhnj3Sjb2waLW/u/Vt/xUTWYs7wGFvvMptfJtQCcxjuVFvuKIFfqMzX +lNXvXvDQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgdAg-001dsL-Ab; Wed, 12 May 2021 00:56:18 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgdAe-001ds3-7t for linux-arm-kernel@desiato.infradead.org; Wed, 12 May 2021 00:56:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=hLk8R+sPEq1fJqeDs5YrbWitukFkj2eeoBAVdTu4lno=; b=D5qwYHrT1aYbL/zAwScsFqpO73 u4F3q/2l42yzHjy8wHjmB2ej9RRT2k73cSV9tEAgV+4O6x3OWMq7MPTbxTLJBsaUxsmCeL+vPtMO6 1JqQ4nTSRwY2srJ/eeDbJBin6WJxoMAKkbdAPUtsR8E7kyB19gJWMkPjzLc1L9rQ9SjCl9gfaThjM 3R7Nvn3oP7qKHosWepqIAg74/GPBw1TnuUVB6RLLlpn/cPq+VryM9WSZ+RQDrvQz6Xc78PL96oqfM EsB3SjRg2SDmhCylBogxznI1pSCTwGUI2k2CBcDjkAFFngR2Et27qL3/CtNF6kD0r/t6g7Pu9z/9s CoFCK+5g==; Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgdAa-00A1jS-Bu for linux-arm-kernel@lists.infradead.org; Wed, 12 May 2021 00:56:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hLk8R+sPEq1fJqeDs5YrbWitukFkj2eeoBAVdTu4lno=; b=jCrLCW9FGl8GeIRmXcY2O32Kz9 iF1LYJPu5gIYlR6OYqEJZbF66Dnr9a0k2V7G/8u1+w9Rusqo8aj1irrukXuC5DEvGsyPky5OGoB+X 8F4B+J0vSry2+R3g/87oMz63qKHGpx5sCiDhZv8w3Ebidb/nAG2A1GXIn4Zy92DaKSuw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lgdAX-003qLE-9H; Wed, 12 May 2021 02:56:09 +0200 Date: Wed, 12 May 2021 02:56:09 +0200 From: Andrew Lunn To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Gregory CLEMENT , Marek =?iso-8859-1?Q?Beh=FAn?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 mvebu + mvebu/dt64 3/6] firmware: turris-mox-rwtm: fail probing when firmware does not support hwrng Message-ID: References: <20210308153703.23097-1-kabel@kernel.org> <20210506090802.14268-1-pali@kernel.org> <20210506090802.14268-3-pali@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210506090802.14268-3-pali@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_175612_425829_EE125D01 X-CRM114-Status: GOOD ( 12.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 06, 2021 at 11:07:59AM +0200, Pali Roh=E1r wrote: > When Marvell's rWTM firmware, which does not support the GET_RANDOM > command, is used, kernel prints an error message > hwrng: no data available > every 10 seconds. > = > Fail probing of this driver if the rWTM firmware does not support the > GET_RANDOM command. > = > This makes it possible to put this driver's compatible into generic > armada-37xx device tree, to be available for other Armada 3720 devices > besides Turris MOX. If they use the rWTM firmware from CZ.NIC, they will > have HWRNG available, and if not, the driver won't be complaining. We start getting into questions of if this is relevant for stable. Running Turris MOX with plain Marvell rWTM will spam the log. So i would say it is a fix, for that situation. However, i would drop the second part of the description. Making the Turris MOX firmware work on none Turris MOX hardware is a new feature, and so not applicable to stable. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel