From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AEAFC2B9F8 for ; Tue, 25 May 2021 17:03:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D54D261417 for ; Tue, 25 May 2021 17:03:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D54D261417 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k2300c7jmHY5LcUBcEvD9qBsyDMgCHdwYk0v0W5qumw=; b=fftogFT+L6GPKU bGiYg+H9ylMaliolaaKJ0oFar/OdlqA7BuVglTKhWteyGFeQ0t86/teeM5tsN3ovCJecEuaVmmdLr Q9/+ihbya1OwEFA1bD1Z5tfMi/w89dEzy0zpZdAj88UDAskqNXItemwaMLkDLfWihsmv4AxwvBw52 JEkiZGoW8IIk9s2bKpQzEm3mFaI0g2v6rSsg52ugcBPxkAGPpLLm1cn05KO1vItet7ckXRUsW4284 PvURsNfnpdVe01h9oAVuj/JPObBipF81KZWkFejW/YwkrLoCW+ZZRP6IXOWAw7K9mefGVgMn4oOn4 0WRayr540FV6nU80KH2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llaQk-006fmZ-H1; Tue, 25 May 2021 17:01:24 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llaCT-006YOY-Aa for linux-arm-kernel@lists.infradead.org; Tue, 25 May 2021 16:46:39 +0000 Received: by mail-pg1-x536.google.com with SMTP id 29so12103397pgu.11 for ; Tue, 25 May 2021 09:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xwS5IVdCekJk7kv3FtNxGVNuofglwTIwxkn43HaNTJo=; b=LkOcj4gtSJPG6QLSDZLLxKY0eFWqg75E5lt7Vq6by8faYpV4d+j1pbincVWsRHY6cR gehPrbn8jhvFppDxsZ3sUCPBNj+hlo56GFqvOLg3VWW3LtU9Xp5qX8CCW/4zZwfQ2awY Pgd4SE2ggCQEo9OKVolYfCWIBVOqpjCpgvY5S9G90MfYVrZ8jnDbOKyRQNlMA3Lxreqs djtJpam7l9btEoGR6Pd0kZlk3uC9t5y/+i9BxICFj84qhjhmTDim4ZkzBnOB9tnAp5Lu x2LunG+TtD/xW1Z+NWOLEV7pqUMKMXt1+2VMRngnppROoZRhOwCstn8YDpEi8QjkAOS1 jkFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xwS5IVdCekJk7kv3FtNxGVNuofglwTIwxkn43HaNTJo=; b=MTw1dSRM28/5+ZVEE7KsxLE+w2/QJw0SUdVrW5TbJfsLDfdr7fbUlb+u8YS3M5xXxE Z1C7hqaoL9fz7XjHm3v2Dd/0bZEc6KpVc/rC5pLfTPyBuesMxlTzEt/LvvOzlwzNbUM7 huJMBhPl+c+v7Jfxj5a4HWHuWumk+tzXXK0cPWrEOOr2EDmUJHCEuxg9HSGIgi7bE5sm BIPFfG4ySdYCDSzBp0DaOQpyTmueYuQHpNka3RHOzhVeIMfXRQA5OMkABJv3iuZTAMim 41uiBIvKqajI/PpmyS4Q1i33J4RdaeXGzUYxv7sY/nWTxyH/rKqlJ5IyAisqVHpsMXZw jLfA== X-Gm-Message-State: AOAM533kU3O/AxTrc1FgwS+OOIB5B924xCDn5bkkLihZdBrIiyYYjdve LVyIZU/mCMryfnZm+sloRm0boQ== X-Google-Smtp-Source: ABdhPJwzX5Z1/XMITezELAhA4gfUFx10BkBRwzCVyyn+CkMr7oR5/cLRKHNBzud+DuLNirYdfDXmxw== X-Received: by 2002:a05:6a00:a1e:b029:2e2:89d8:5c87 with SMTP id p30-20020a056a000a1eb02902e289d85c87mr29438912pfh.73.1621961195812; Tue, 25 May 2021 09:46:35 -0700 (PDT) Received: from google.com (240.111.247.35.bc.googleusercontent.com. [35.247.111.240]) by smtp.gmail.com with ESMTPSA id 10sm15223768pgl.39.2021.05.25.09.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 09:46:35 -0700 (PDT) Date: Tue, 25 May 2021 16:46:31 +0000 From: Sean Christopherson To: Rong Chen Cc: Peter Zijlstra , kernel test robot , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [kbuild-all] Re: [PATCH] kvm: fix boolreturn.cocci warnings Message-ID: References: <202105251316.O1igBtAa-lkp@intel.com> <20210525055940.GA7291@9b81fe870f96> <91885328-dc7f-3d12-3ddb-53a403bb8c60@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <91885328-dc7f-3d12-3ddb-53a403bb8c60@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210525_094637_389334_9CCB995B X-CRM114-Status: GOOD ( 16.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 25, 2021, Rong Chen wrote: > > > On 5/25/21 3:11 PM, Peter Zijlstra wrote: > > On Tue, May 25, 2021 at 01:59:40PM +0800, kernel test robot wrote: > > > From: kernel test robot > > > > > > arch/arm64/kvm/mmu.c:1203:9-10: WARNING: return of 0/1 in function 'kvm_age_gfn' with return type bool > > > arch/arm64/kvm/mmu.c:1173:9-10: WARNING: return of 0/1 in function 'kvm_set_spte_gfn' with return type bool > > > arch/arm64/kvm/mmu.c:1216:9-10: WARNING: return of 0/1 in function 'kvm_test_age_gfn' with return type bool > > > arch/arm64/kvm/mmu.c:1159:9-10: WARNING: return of 0/1 in function 'kvm_unmap_gfn_range' with return type bool > > > > > > Return statements in functions returning bool should use > > > true/false instead of 1/0. > > > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > Per 2b076054e524 ("remove boolinit.cocci"), I have a very dim view of > > this sort of thing. > > Hi Peterz, > > Sorry for the noise, we'll disable the check. > > > > > > Fixes: 63b3f96e1a98 ("kvm: Select SCHED_INFO instead of TASK_DELAY_ACCT") > > *how* ?!? > > The bot is stupid LOL. FWIW, it's not _that_ stupid, or maybe it's the broken clock adage... The proper fix is sitting in the KVM tree, it should soon make its way to Linus. fcb8283920b1 ("KVM: arm64: Fix boolreturn.cocci warnings") _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel