From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Daniel Scally <djrscally@gmail.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Wolfram Sang <wsa@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
Maximilian Luz <luzmaximilian@gmail.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-i2c@vger.kernel.org, platform-driver-x86@vger.kernel.org,
devel@acpica.org, Len Brown <lenb@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Russell King <linux@armlinux.org.uk>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Mark Gross <mgross@linux.intel.com>,
Robert Moore <robert.moore@intel.com>,
Erik Kaneda <erik.kaneda@intel.com>,
laurent.pinchart@ideasonboard.com,
kieran.bingham@ideasonboard.com
Subject: Re: [PATCH v4 7/8] platform/x86: Add intel_skl_int3472 driver
Date: Wed, 26 May 2021 10:54:39 +0300 [thread overview]
Message-ID: <YK3+vxmWfD0mhjU0@smile.fi.intel.com> (raw)
In-Reply-To: <6294177b-d6e1-8bbd-d313-5cce1c498604@gmail.com>
On Tue, May 25, 2021 at 11:53:21PM +0100, Daniel Scally wrote:
> On 21/05/2021 13:57, Andy Shevchenko wrote:
...
> >> +static const struct regulator_ops int3472_gpio_regulator_ops;
> > Hmm... Can you use 'reg-fixed-voltage' platform device instead?
> >
> > One example, although gone from upstream, but available in the tree, I can
> > point to is this:
> >
> > git log -p -- arch/x86/platform/intel-mid/device_libs/platform_bcm43xx.c
> >
> > It uses constant structures, but I think you may dynamically generate the
> > necessary ones.
> >
>
> I can experiment with this, though one thing is we have no actual idea
> what voltages these are supplying...it doesn't look like that matters
> from drivers/regulator/fixed.c, but I'd have to try it to be sure.
I believe it is likely 1.8v. But I can check if I have the schematics of a
reference design for something like this.
...
> >> + if (int3472->clock.ena_gpio) {
> >> + ret = skl_int3472_register_clock(int3472);
> >> + if (ret)
> >> + goto out_free_res_list;
> >> + } else {
> > Hmm... Have I got it correctly that we can't have ena_gpio && led_gpio together?
>
>
> No, just that we can only have led_gpio if we also have ena_gpio (at
> least that's the intention...)
Okay, perhaps then a comment above?
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-26 7:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 14:09 [PATCH v4 0/8] Introduce intel_skl_int3472 module Daniel Scally
2021-05-20 14:09 ` [PATCH v4 1/8] ACPI: scan: Extend acpi_walk_dep_device_list() Daniel Scally
2021-05-20 17:15 ` Maximilian Luz
2021-05-20 18:22 ` Rafael J. Wysocki
2021-05-20 21:03 ` Hans de Goede
2021-05-21 12:59 ` Andy Shevchenko
2021-05-20 14:09 ` [PATCH v4 2/8] ACPI: scan: Add function to fetch dependent of acpi device Daniel Scally
2021-05-20 18:33 ` Rafael J. Wysocki
2021-05-20 18:55 ` Rafael J. Wysocki
2021-05-21 19:25 ` Daniel Scally
2021-05-20 14:09 ` [PATCH v4 3/8] i2c: core: Add a format macro for I2C device names Daniel Scally
2021-05-20 14:09 ` [PATCH v4 4/8] gpiolib: acpi: Export acpi_get_gpiod() Daniel Scally
2021-05-20 14:09 ` [PATCH v4 5/8] clkdev: Make clkdev_drop() null aware Daniel Scally
2021-05-20 14:09 ` [PATCH v4 6/8] gpiolib: acpi: Add acpi_gpio_get_io_resource() Daniel Scally
2021-05-21 12:05 ` Andy Shevchenko
2021-05-25 22:30 ` Daniel Scally
2021-05-20 14:09 ` [PATCH v4 7/8] platform/x86: Add intel_skl_int3472 driver Daniel Scally
2021-05-21 12:57 ` Andy Shevchenko
2021-05-25 22:53 ` Daniel Scally
2021-05-26 7:54 ` Andy Shevchenko [this message]
2021-05-20 14:09 ` [PATCH v4 8/8] mfd: tps68470: Remove tps68470 MFD driver Daniel Scally
2021-05-25 13:10 ` [PATCH v4 0/8] Introduce intel_skl_int3472 module Hans de Goede
2021-05-25 13:12 ` Hans de Goede
2021-05-25 13:23 ` Andy Shevchenko
2021-05-25 23:03 ` Daniel Scally
2021-05-26 7:55 ` Andy Shevchenko
2021-05-26 12:36 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK3+vxmWfD0mhjU0@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=devel@acpica.org \
--cc=djrscally@gmail.com \
--cc=erik.kaneda@intel.com \
--cc=hdegoede@redhat.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luzmaximilian@gmail.com \
--cc=mgross@linux.intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).