From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83A12C433ED for ; Tue, 18 May 2021 06:40:01 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01FC2611B0 for ; Tue, 18 May 2021 06:40:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01FC2611B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TPIpUip16l2ZCoMR9DKSzOwEnQzQDZbzCej9w8v9gWc=; b=QNHHcVJj+lAnQTuvkq0HRZuOA IV1bos/bITd6kJNOiA8BbmgUxy/kRTeULS+mjD23c5iRjT2IoaQXxvO5Pi456Jbl3bbodramd0APg BHAUY6H/I1kEvBHAsmOUp/1D44dBqcOH8nBuIY/CCssXbgc2FhjoOThd5ysGNRQbwRxL85rR8mj60 HyZ7w5yGGZHVzl8aIPxUZ3DD9fWHsba7SXftQy48aThc4G5dQZjoF3t7mS0x2pgVej8mGOJ4vsIdE d7JpTHGZ7TTZSfm77KSLq6gcD4QSRHfc0ELT8G7MRFPCZNKwMw5m0cKCmSxmSFkdrGG4KfmDpASQ4 9Rte0pfBg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1litMv-00HArw-6H; Tue, 18 May 2021 06:38:17 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1litMs-00HAra-5e for linux-arm-kernel@desiato.infradead.org; Tue, 18 May 2021 06:38:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=L+uNpoV9IawZLrAfG/JfnTqDqLyYsm+63mdiaEJkF8M=; b=nU38+FoOtkZ857hKSK1ukbtFSO IS6cWaaD4TXT+8HMN06gSgULOlyMKMkfZwJw3i1suIWdVEKdJAW+DVrOC4g6l4/Atm3dCpEPmNKOc rH51oqqYW29soW753CvI1i2Z1MKA1N38wifNMUVP/OHNnRoN+MKahjZyrwYiMtww24AXyZkX7aKe8 FnMY8Z0gYFBIo2LasOA/3LwUT93J9Dsckk20ocjV0nin3Rve0HtO61/Eh7qSZzul/VtwzR7zd1DYl 0owlNVEhoK0F/O9Kma4Hz3C44B7qg/GKfLJrKWaUs9rI7Z77L7Pry6FAf7l8iQqLEHWblDVOWMqJg NoAuT7Lw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1litMp-00EME1-FJ for linux-arm-kernel@lists.infradead.org; Tue, 18 May 2021 06:38:12 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 62CD9611B0; Tue, 18 May 2021 06:38:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621319890; bh=A/cflykcOTYV4DtVK9ADdAYseWeD5YVtDHXFY/y2UVg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=on/bfYxol0bSNMXWXbOrxdMvGc2OTG+ePP/gS1AvrvWNTnzMwI0G53tjQ8emREgZr KfYSWtnrkbk2MQVjeuAb3c2pZJGWbHdBJRVwYRzDleDGVfJr9pkuoZeD3fSUwrG3kF mieEvmVd9DhafQ1WIAFdy44feYWFiNqyrNpOQUA0= Date: Tue, 18 May 2021 08:38:06 +0200 From: Greg Kroah-Hartman To: Andrew Jeffery Cc: linux-serial@vger.kernel.org, Jiri Slaby , Joel Stanley , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, jenmin_yuan@aspeedtech.com, Ryan Chen , Milton Miller II , "Chia-Wei, Wang" Subject: Re: [PATCH] tty: 8250: Add UART_BUG_TXRACE workaround for Aspeed VUART Message-ID: References: <20210517124105.3565860-1-andrew@aj.id.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210517_233811_555211_9F5F3CC0 X-CRM114-Status: GOOD ( 25.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 18, 2021 at 11:00:39AM +0930, Andrew Jeffery wrote: > > > On Mon, 17 May 2021, at 23:45, Greg KH wrote: > > On Mon, May 17, 2021 at 10:11:05PM +0930, Andrew Jeffery wrote: > > > Aspeed Virtual UARTs directly bridge e.g. the system console UART on the > > > LPC bus to the UART interface on the BMC's internal APB. As such there's > > > no RS-232 signalling involved - the UART interfaces on each bus are > > > directly connected as the producers and consumers of the one set of > > > FIFOs. > > > > > > The APB in the AST2600 generally runs at 100MHz while the LPC bus peaks > > > at 33MHz. The difference in clock speeds exposes a race in the VUART > > > design where a Tx data burst on the APB interface can result in a byte > > > lost on the LPC interface. The symptom is LSR[DR] remains clear on the > > > LPC interface despite data being present in its Rx FIFO, while LSR[THRE] > > > remains clear on the APB interface as the host has not consumed the data > > > the BMC has transmitted. In this state, the UART has stalled and no > > > further data can be transmitted without manual intervention (e.g. > > > resetting the FIFOs, resulting in loss of data). > > > > > > The recommended work-around is to insert a read cycle on the APB > > > interface between writes to THR. > > > > > > Cc: ChiaWei Wang > > > Signed-off-by: Andrew Jeffery > > > --- > > > drivers/tty/serial/8250/8250.h | 1 + > > > drivers/tty/serial/8250/8250_aspeed_vuart.c | 1 + > > > drivers/tty/serial/8250/8250_port.c | 2 ++ > > > 3 files changed, 4 insertions(+) > > > > > > diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h > > > index 52bb21205bb6..4d6f5e0ecd4c 100644 > > > --- a/drivers/tty/serial/8250/8250.h > > > +++ b/drivers/tty/serial/8250/8250.h > > > @@ -88,6 +88,7 @@ struct serial8250_config { > > > #define UART_BUG_NOMSR (1 << 2) /* UART has buggy MSR status bits (Au1x00) */ > > > #define UART_BUG_THRE (1 << 3) /* UART has buggy THRE reassertion */ > > > #define UART_BUG_PARITY (1 << 4) /* UART mishandles parity if FIFO enabled */ > > > +#define UART_BUG_TXRACE (1 << 5) /* UART Tx fails to set remote DR */ > > > > BUG()? > > Can you please expand on what you mean here? I don't follow. > > At least, I think there might be a formatting issue (spaces vs tabs). Ick, my fault, I meant "BIT()"? To perhaps use that macro instead of the << symbol. And yes, tabs would be good as well :) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel