From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
Michal Simek <michal.simek@xilinx.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] misc: xilinx-sdfec: Check if file->private_data is NULL
Date: Fri, 21 May 2021 20:39:56 +0200 [thread overview]
Message-ID: <YKf+fJBXXyvIFrZF@kroah.com> (raw)
In-Reply-To: <20210520170150.1615956-1-linux@roeck-us.net>
On Thu, May 20, 2021 at 10:01:50AM -0700, Guenter Roeck wrote:
> container_of() only returns NULL if the passed pointer is NULL _and_
> the embedded element is the first element of the structure. Even if that
> is the case, testing against it is misleading and possibly dangerous
> because the position of the embedded element may change. Explicitly
> check if the parameter is NULL and bail out if so instead of checking
> the result of container_of().
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> RFC:
>
> The NULL check in the poll function is likely unnecessary. Interestingly,
> there is no NULL check in the ioctl function, even though there is a
> similar container_of() in that function. However, I do not feel
> comfortable enough to change the functionality of this code and drop
> the check entirely.
>
> drivers/misc/xilinx_sdfec.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
> index 23c8448a9c3b..0a3721d31dea 100644
> --- a/drivers/misc/xilinx_sdfec.c
> +++ b/drivers/misc/xilinx_sdfec.c
> @@ -1011,11 +1011,11 @@ static __poll_t xsdfec_poll(struct file *file, poll_table *wait)
> __poll_t mask = 0;
> struct xsdfec_dev *xsdfec;
>
> - xsdfec = container_of(file->private_data, struct xsdfec_dev, miscdev);
> -
> - if (!xsdfec)
> + if (!file->private_data)
> return EPOLLNVAL | EPOLLHUP;
>
> + xsdfec = container_of(file->private_data, struct xsdfec_dev, miscdev);
> +
> poll_wait(file, &xsdfec->waitq, wait);
>
> /* XSDFEC ISR detected an error */
> --
> 2.25.1
>
It should be safe not to check this for NULL as the misc device sets the
pointer in the open, and removes it in release. poll or ioctl can not
be called if release has already happened.
So feel free to drop the check here, xsdfec_dev_ioctl() looks correct.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-21 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 17:01 [RFC PATCH] misc: xilinx-sdfec: Check if file->private_data is NULL Guenter Roeck
2021-05-21 18:39 ` Greg Kroah-Hartman [this message]
2021-05-21 19:25 ` Dragan Cvetic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKf+fJBXXyvIFrZF@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=derek.kiernan@xilinx.com \
--cc=dragan.cvetic@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).