From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A36E4C2B9F7 for ; Tue, 25 May 2021 02:29:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5906C6141F for ; Tue, 25 May 2021 02:29:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5906C6141F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6ReeZexelz3XWIyhJWarUnn6uooS+B0MEusurbzTOcs=; b=wn3qL4UsEMPh57 Wb+34dtJozV0ztjvGGbtD2KUX5PsvAkRon86ZeQ/hx57KyV00J8+BAuLxQzADguINmSHYaFohjG7w UGPIn6JQxzzfwJmf9vBvlnm1UkOsnD15tIEccZ1NgJj50cnu2LnpEu7NLa97Z2F4sRYe6eCIT7ok1 l7ytf5ItfRFqUEf/t5qS3u1aqjYmYwZSmAlaSu6Dhu4v6z0rT9R/fN2OPP+3pr5T3vJGm2PGGqVKO 98YcphKwMPLXQ7jXxvJfCMYbUkEDP98LpXKjqX9tlO81eoNo+2v8sHZ4k4X6nfXdsfIpq7ZjnrQsl kTk7FfpFi+mhdvxWQ5Nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llMnE-002uyF-Gf; Tue, 25 May 2021 02:27:41 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1llIVg-0020d0-Tq for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 21:53:18 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 291CE600CD; Mon, 24 May 2021 21:53:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621893196; bh=5vb8ChgnerQT/NGevHl6r63aPAuvU9KJ+h6D8O37gh4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Up4OA561MudWrVUA7K9jSpQhEaeqoKkXE31NuWdP1CDYvXqce577DT7zO8rOGlmdI nXCmMOSjhYw8csue2B/qSVTlQQ1GC5VHxFlGjSOnCkHljTinhZggIcN3a1DgWGpwdi 0Hw2izU4Ivu1HSHNYCi7wDSXpKBkzaimAp3GHeE4IKrh2LPPSG0pyckhgHwiGRjYvu 6/ZC1uoDqSSwtitnXsM3Go5+r97v1EVQe7nBAuXkSParaCgWEueFs7Io2COkde/iLH QTz49ym80BNA1AZWmDXHtAMds+/FaisidOZ7WBoTP5jSvSicFdh3ZlDP0VyU+k7J44 +KfsU0VoIXThA== Date: Mon, 24 May 2021 14:53:14 -0700 From: Eric Biggers To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, herbert@gondor.apana.org.au, will@kernel.org, kernel-team@android.com Subject: Re: [PATCH v5 5/5] crypto: arm64/aes-ccm - avoid by-ref argument for ce_aes_ccm_auth_data Message-ID: References: <20210521102053.66609-1-ardb@kernel.org> <20210521102053.66609-6-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210521102053.66609-6-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_145317_022516_2FBB7A62 X-CRM114-Status: GOOD ( 16.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 21, 2021 at 12:20:53PM +0200, Ard Biesheuvel wrote: > With the SIMD code path removed, we can clean up the CCM auth-only path > a bit further, by passing the 'macp' input buffer pointer by value, > rather than by reference, and taking the output value from the > function's return value. > > This way, the compiler is no longer forced to allocate macp on the > stack. This is not expected to make any difference in practice, it just > makes for slightly cleaner code. > > Signed-off-by: Ard Biesheuvel > --- > arch/arm64/crypto/aes-ce-ccm-core.S | 23 ++++++++++---------- > arch/arm64/crypto/aes-ce-ccm-glue.c | 17 +++++---------- > 2 files changed, 17 insertions(+), 23 deletions(-) > > diff --git a/arch/arm64/crypto/aes-ce-ccm-core.S b/arch/arm64/crypto/aes-ce-ccm-core.S > index 8adff299fcd3..b03f7f71f893 100644 > --- a/arch/arm64/crypto/aes-ce-ccm-core.S > +++ b/arch/arm64/crypto/aes-ce-ccm-core.S > @@ -12,22 +12,21 @@ > .arch armv8-a+crypto > > /* > - * void ce_aes_ccm_auth_data(u8 mac[], u8 const in[], u32 abytes, > - * u32 *macp, u8 const rk[], u32 rounds); > + * u32 ce_aes_ccm_auth_data(u8 mac[], u8 const in[], u32 abytes, > + * u32 macp, u8 const rk[], u32 rounds); How is this different from 'u8 mac[]' which is already one of the parameters? - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel