From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA928C2B9F8 for ; Tue, 25 May 2021 12:52:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 821B46113E for ; Tue, 25 May 2021 12:52:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 821B46113E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1gpjSvDvD7ioX7rG/dESIvL3eeK2ELa1Xjgz7oR/9iA=; b=rhPaKMR1CnDfRn +GDoLQQiTAM69gdnVEjFjfGqCTbXnwI9tGu4i5wigJdzJEEwY9MJdfpxdbLxc/XTsQYMmw3aRzqXg eMvsdc7Wg9hMDt3aplWVBdxlVLypOBrCbKPvj0gGPO92qL23UAKy0ElSay69+7pz3rtY1db/1SEKg UFhagA6XO2oqL1vRCwyYrcz8OxyPrmIryOal8SCYARhZkq0q6kCzhCW05OJ2gtKC8m6OtrYh1TnHq i0VQUdquINdwBp5BcPCjVhk5vlg25kOpkPu0qwtZb9wofB0GBITgf02TYH28yvn4WRd8BzynZRyPE bcbqEASK5IXNsFPmajuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llWWS-0058Mp-72; Tue, 25 May 2021 12:51:00 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llWWP-0058ML-Vl for linux-arm-kernel@bombadil.infradead.org; Tue, 25 May 2021 12:50:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4qWEHCnUc1i/E2a99duBFrQRt0r5gCURlGjDZLYJu5A=; b=Hhlhh9adpV9bryLKV2isk1zbUV Ndwr3et61oe924XgwQwV+JybDWmdnNIRuEd49ZuPFjFL/A0xfPK3zY7re2tRGGlDc+gH/NIoH/jBc cF6xoVn7ocpMjMRFePmFsHy8wT9lux8B7PzZB9yeR1SsV3hoMC9tWiEnIs+DnbiuqkhY20F1XuvhO 9DObQ7NwAdaRzyGnj+o1buFNWLKXIiVIffqyJsVWT1ui63uI/YERyWj8K8iKZs2FPxHJFoqvMCmY+ Q9dxyg9cl6ZWaOJ+bb6Zy/BabZMyNDNIjpXpHAFWv86ZNtsMzpvYiivRavqD0DFSewmFRLEXT92aU HcYyTSmw==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1llWWC-0006fx-KC; Tue, 25 May 2021 12:50:52 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id CB4B24011C; Tue, 25 May 2021 09:50:45 -0300 (-03) Date: Tue, 25 May 2021 09:50:45 -0300 From: Arnaldo Carvalho de Melo To: James Clark Cc: Leo Yan , John Garry , Will Deacon , Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Al Grant , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] perf arm-spe: Remove redundant checking for "full_auxtrace" Message-ID: References: <20210519041546.1574961-1-leo.yan@linaro.org> <20210519041546.1574961-5-leo.yan@linaro.org> <326bfc02-e02d-997b-2f7f-1c0565f4d5cc@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <326bfc02-e02d-997b-2f7f-1c0565f4d5cc@arm.com> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Tue, May 25, 2021 at 03:03:53PM +0300, James Clark escreveu: > > > On 19/05/2021 07:15, Leo Yan wrote: > > The option "opts->full_auxtrace" is checked at the earlier place, if it > > is false the function will directly bail out. So remove the redundant > > checking for "opts->full_auxtrace". > > > > Suggested-by: James Clark > > Signed-off-by: Leo Yan > > --- > > tools/perf/arch/arm64/util/arm-spe.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/arch/arm64/util/arm-spe.c b/tools/perf/arch/arm64/util/arm-spe.c > > index bacdf366040d..a4420d4df503 100644 > > --- a/tools/perf/arch/arm64/util/arm-spe.c > > +++ b/tools/perf/arch/arm64/util/arm-spe.c > > @@ -116,7 +116,7 @@ static int arm_spe_recording_options(struct auxtrace_record *itr, > > return 0; > > > > /* We are in full trace mode but '-m,xyz' wasn't specified */ > > - if (opts->full_auxtrace && !opts->auxtrace_mmap_pages) { > > + if (!opts->auxtrace_mmap_pages) { > > if (privileged) { > > opts->auxtrace_mmap_pages = MiB(4) / page_size; > > } else { > > > > Reviewed-by: James Clark Thanks, applied the series, - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel