From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC6EBC47082 for ; Mon, 7 Jun 2021 22:03:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B546B60FEE for ; Mon, 7 Jun 2021 22:03:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B546B60FEE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s+EkzpcDFF0ienhD5hCHqxk1k8H9/6XAH1iQaRS7ZUo=; b=UmGQzBMOK2LK6h jF1BclihfZaAAp5vXkAnA/yya/KihQk0AkK2qYRnWcyn9JqIOBQxyMmNquTSCLkEm+Qbpj4zOyRJM subrs7BKr3FR7kO8gYLgSaQjpxJMW4eH1z9qxHxp3Y6s5wBZcolj1fZUMMRV9/f4HdHr0nuBrghTQ IGOiiWP6Qfy7xPCfBHBqR+GUoyC4mYOnIfFIEk2A8QibtXL9Fv7+5yWJE/B/VOCbIByukTz19WW1t V5szimPmbYy8WY/0Hmx99HQtqcZ5MP3h06TGvbvBXd1TG8UR012D/RkL96TW16TzJss+6EBfe9NzE NJbT1Lb8vfOkvSi3hYKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqNH8-005Vi4-Qz; Mon, 07 Jun 2021 21:59:15 +0000 Received: from mail-pf1-f172.google.com ([209.85.210.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqNH4-005VhT-6c for linux-arm-kernel@lists.infradead.org; Mon, 07 Jun 2021 21:59:11 +0000 Received: by mail-pf1-f172.google.com with SMTP id y15so14130913pfl.4 for ; Mon, 07 Jun 2021 14:59:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9jTPa0UY0tGM691xkf4yxBu/UIOdvQ3MoXTrDLCVE28=; b=U4qyWPaGkI2G6q2gkL/IiUP+XH4FE6BuAway6ntSXyEOsbtmx9EBPlU+M0I8ll0IzL wetav8vs5FeM0rBw+eudH68Ybm7SKvtJi3+JJtO2299DfHLU2Ae39tNLoKSlfGdWoN5V UuivXDPmmxkoZ6wF5Qq+3niyB3hTGARQixY9L1SFC8tcwsEvIR5PJsZlAHw8GZTB1Hyb YyWU9fSl8LIkbsc8LNxXsCEwrYultnfiRcWXwAfVfdv3a1ILC+l0wjsJYu6UpjgPj3oz GJU2HgH4GngNdyey6fk/msqFBTLF4uI3AGc+oTNDhZnyQ7ykxLiwAk2y7o65OdbcGRdo E22w== X-Gm-Message-State: AOAM532CIAb3RUI0+A/2wM1FzOfZr8PL1PqBVruyqNjS4lL+d1qraKMV Eqq6Kjr5z6b/oNil1HfD7CE= X-Google-Smtp-Source: ABdhPJwEMED3BT+2G+KRaSnckuwCNQr48LAlsO0xt0KeqSs5tL2hlvV+se5oBw6uhM8ZSwyY8v1M8Q== X-Received: by 2002:a62:dd83:0:b029:2e8:e511:c32f with SMTP id w125-20020a62dd830000b02902e8e511c32fmr18934441pff.49.1623103148070; Mon, 07 Jun 2021 14:59:08 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id n23sm9170372pff.93.2021.06.07.14.59.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jun 2021 14:59:07 -0700 (PDT) Date: Mon, 7 Jun 2021 14:59:06 -0700 From: Moritz Fischer To: trix@redhat.com Cc: hao.wu@intel.com, mdf@kernel.org, michal.simek@xilinx.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/7] fpga: wrappers for fpga_manager_ops Message-ID: References: <20210607172402.2938697-1-trix@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210607172402.2938697-1-trix@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210607_145910_268540_D3C4DDD8 X-CRM114-Status: GOOD ( 17.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tom, On Mon, Jun 07, 2021 at 10:23:55AM -0700, trix@redhat.com wrote: > From: Tom Rix > > As followup from > https://lore.kernel.org/linux-fpga/06301910-10a1-0e62-45a0-d28ab5a787ed@redhat.com/ > > Boards should not be required to have noop functions. > So improve or create fpga-mgr wrappers for the fpga_manager_ops. > Remove the noop functions. > Refactor fpga-mgr to use the wrappers. > > write_sg op was not wrapped on purpose. Its checking / use in > fpga_mgr_buf_load_sg() did not warrant a wrapper. > > Tom Rix (7): > fpga: wrap the write_init() op > fpga: make write_complete() op optional > fpga: wrap the write() op > fpga: wrap the status() op > fpga: wrap the state() op > fpga: wrap the fpga_remove() op > fpga: collect wrappers and change to inline > > drivers/fpga/dfl-fme-mgr.c | 6 --- > drivers/fpga/fpga-mgr.c | 102 +++++++++++++++++++++++------------ > drivers/fpga/stratix10-soc.c | 6 --- > drivers/fpga/ts73xx-fpga.c | 6 --- > drivers/fpga/zynqmp-fpga.c | 7 --- > 5 files changed, 67 insertions(+), 60 deletions(-) > > -- > 2.26.3 > Thanks for doing this, will take a look tonight! - Moritz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel