From: Andrew Lunn <andrew@lunn.ch>
To: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
Cc: Jose.Abreu@synopsys.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, kuba@kernel.org, netdev@vger.kernel.org,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
davem@davemloft.net, mcoquelin.stm32@gmail.com,
weifeng.voon@intel.com, boon.leong.ong@intel.com,
tee.min.tan@intel.com, vee.khee.wong@linux.intel.com,
vee.khee.wong@intel.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/3] net: pcs: add 2500BASEX support for Intel mGbE controller
Date: Fri, 28 May 2021 01:26:38 +0200 [thread overview]
Message-ID: <YLAqrte9qwQ/64BI@lunn.ch> (raw)
In-Reply-To: <20210527092415.25205-3-michael.wei.hong.sit@intel.com>
> +static int xpcs_config_2500basex(struct mdio_xpcs_args *xpcs)
> +{
> + int ret;
> +
> + ret = xpcs_read(xpcs, MDIO_MMD_VEND2, DW_VR_MII_DIG_CTRL1);
> + if (ret < 0)
> + return ret;
> + ret |= DW_VR_MII_DIG_CTRL1_2G5_EN;
> + ret &= ~DW_VR_MII_DIG_CTRL1_MAC_AUTO_SW;
> + ret = xpcs_write(xpcs, MDIO_MMD_VEND2, DW_VR_MII_DIG_CTRL1, ret);
> + if (ret < 0)
> + return ret;
> +
> + ret = xpcs_read(xpcs, MDIO_MMD_VEND2, DW_VR_MII_MMD_CTRL);
> + if (ret < 0)
> + return ret;
> + ret &= ~AN_CL37_EN;
> + ret |= SGMII_SPEED_SS6;
> + ret &= ~SGMII_SPEED_SS13;
> + return xpcs_write(xpcs, MDIO_MMD_VEND2, DW_VR_MII_MMD_CTRL, ret);
> +
> + return 0;
Indentation is messed up here? Or a rebase gone wrong removing an if
statement?
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-27 23:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 9:24 [PATCH net-next v3 0/3] Enable 2.5Gbps speed for stmmac Michael Sit Wei Hong
2021-05-27 9:24 ` [PATCH net-next v3 1/3] net: stmmac: split xPCS setup from mdio register Michael Sit Wei Hong
2021-05-27 9:24 ` [PATCH net-next v3 2/3] net: pcs: add 2500BASEX support for Intel mGbE controller Michael Sit Wei Hong
2021-05-27 23:26 ` Andrew Lunn [this message]
2021-05-28 1:57 ` Sit, Michael Wei Hong
2021-05-27 9:24 ` [PATCH net-next v3 3/3] net: stmmac: enable Intel mGbE 2.5Gbps link speed Michael Sit Wei Hong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLAqrte9qwQ/64BI@lunn.ch \
--to=andrew@lunn.ch \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael.wei.hong.sit@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=tee.min.tan@intel.com \
--cc=vee.khee.wong@intel.com \
--cc=vee.khee.wong@linux.intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).