From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF2C3C4708F for ; Mon, 31 May 2021 04:18:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 809E160FF0 for ; Mon, 31 May 2021 04:18:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 809E160FF0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mKJ7RrpB2lycY0DwggKwatA8HtA4XZzbAOv/UDHzv1A=; b=0y9l6vzoVSxKzu O9CcY48kKNZegvhSy2M/rAfrqbl3c8QVZWocPmHsK4gjpn/X4cNK8oZSaG+kiW4EkS0BkiHWtPbX3 l0xX3+9TbtCgHYOABEdDSM7IwPpa454J3ilj/Ft4n+7mGFXxrq0SFpnaHQhIUMIZLJ6CdFggGPSxR T4/dL36u+qcR9YW+b3nmAleZrKB4pMVXmmZmBHvUngGctkFjWdADOd0kONZNoWbH7VwtvjmqqShGH hbiss26AQprqhMBrtVhblhxN9q3XeD3RvbqTR5cmpOTtNKX984i1/cIIWewHe+vty5VxIHS99H9jw /F1s+S8MQ9FHdHzhfjxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lnZM3-00AfDJ-HZ; Mon, 31 May 2021 04:16:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lnZM0-00AfCz-Ah for linux-arm-kernel@lists.infradead.org; Mon, 31 May 2021 04:16:41 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 16A4660FF0; Mon, 31 May 2021 04:16:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622434599; bh=WrrNcXLSHGAxtkDaYh0sooXVPLQWlfDXREfK1i3H/5E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZSNt6RNUzsFj9QqGharZZ/5OVOErMq24NUVJUMA3vcK9ZQIk2vk0cRcPTSD5Kz5hq LqMKAcCXBv2DaYPPefCkKDSfEuqesQUAwmHpqZT0fzecNe1OlS9kBfWSjftgezJL7R X0hJwwvahOCLHA2euDqqvAdkNGO1Cg/QvEUXpU5fLNyfg5zgZBry5snamtdexI5qCM att6IndNwPQgS5b/rTtayW+ISR9zx3HSgSx7vDdL052nfx/Z+G7mrdVvdXKZCzzW98 Yw6QeGZcNc4BLYOJ+anmQk3aEV7TDphNwmE2d5HALkwgJgjgxZWOl/xGNXw1JIsabD usLUFzXJfDAwQ== Date: Mon, 31 May 2021 09:46:36 +0530 From: Vinod Koul To: Zou Wei Cc: orsonzhai@gmail.com, baolin.wang7@gmail.com, zhang.lyra@gmail.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH -next] dmaengine: fix PM reference leak Message-ID: References: <1621601902-33697-1-git-send-email-zou_wei@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1621601902-33697-1-git-send-email-zou_wei@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210530_211640_412224_832A3B3E X-CRM114-Status: UNSURE ( 6.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21-05-21, 20:58, Zou Wei wrote: > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. Please rebase and submit per driver.. I have already applied few fixes for this and rejected few -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel