linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Jon Hunter <jonathanh@nvidia.com>,
	linux-tegra@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 07/12] memory: tegra: Parameterize interrupt handler
Date: Wed, 2 Jun 2021 10:43:54 +0200	[thread overview]
Message-ID: <YLdEyoSOFIeAki7m@orome.fritz.box> (raw)
In-Reply-To: <ef9e119a-941a-cb15-0084-137a07cf0cf1@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1060 bytes --]

On Tue, Jun 01, 2021 at 10:37:19PM +0300, Dmitry Osipenko wrote:
> 01.06.2021 21:53, Dmitry Osipenko пишет:
> > 01.06.2021 20:59, Thierry Reding пишет:
> >> --- a/drivers/memory/tegra/mc.h
> >> +++ b/drivers/memory/tegra/mc.h
> >> @@ -135,9 +135,13 @@ extern const struct tegra_mc_soc tegra210_mc_soc;
> >>      defined(CONFIG_ARCH_TEGRA_132_SOC) || \
> >>      defined(CONFIG_ARCH_TEGRA_210_SOC)
> >>  int tegra30_mc_probe(struct tegra_mc *mc);
> >> +irqreturn_t tegra30_mc_handle_irq(int irq, void *data);
> > 
> > tegra30_mc_handle_irq() doesn't need to be made global, it's defined and
> > used only within mc.h.
> > 
> 
> You could make this function static and annotate it with maybe_unused.

This doesn't even need to be __maybe_unused because it's declared in the
same #if/#endif block as tegra30_mc_ops. But yeah, I can make this
static to mc.c. Initially I had thought that this was going to be used
by tegra186_mc_ops as well, but we can always export it if necessary
when that work materializes.

Thanks,
Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-02  9:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01 17:59 [PATCH v2 00/12] memory: tegra: Driver unification Thierry Reding
2021-06-01 17:59 ` [PATCH v2 02/12] memory: tegra: Unify struct tegra_mc across SoC generations Thierry Reding
2021-06-01 17:59 ` [PATCH v2 03/12] memory: tegra: Introduce struct tegra_mc_ops Thierry Reding
2021-06-01 17:59 ` [PATCH v2 04/12] memory: tegra: Push suspend/resume into SoC drivers Thierry Reding
2021-06-01 17:59 ` [PATCH v2 05/12] memory: tegra: Make per-SoC setup more generic Thierry Reding
2021-06-01 17:59 ` [PATCH v2 06/12] memory: tegra: Extract setup code into callback Thierry Reding
2021-06-01 17:59 ` [PATCH v2 07/12] memory: tegra: Parameterize interrupt handler Thierry Reding
2021-06-01 18:53   ` Dmitry Osipenko
2021-06-01 18:54     ` Dmitry Osipenko
2021-06-01 19:37     ` Dmitry Osipenko
2021-06-02  8:43       ` Thierry Reding [this message]
2021-06-01 17:59 ` [PATCH v2 08/12] memory: tegra: Make IRQ support opitonal Thierry Reding
2021-06-01 17:59 ` [PATCH v2 09/12] memory: tegra: Only initialize reset controller if available Thierry Reding
2021-06-01 17:59 ` [PATCH v2 10/12] memory: tegra: Unify drivers Thierry Reding
2021-06-01 17:59 ` [PATCH v2 11/12] memory: tegra: Add memory client IDs to tables Thierry Reding
2021-06-01 17:59 ` [PATCH v2 12/12] memory: tegra: Split Tegra194 data into separate file Thierry Reding
2021-06-02  7:53   ` Krzysztof Kozlowski
2021-06-02  8:29     ` Thierry Reding
2021-06-01 19:38 ` [PATCH v2 00/12] memory: tegra: Driver unification Dmitry Osipenko
2021-06-01 20:02   ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLdEyoSOFIeAki7m@orome.fritz.box \
    --to=thierry.reding@gmail.com \
    --cc=digetx@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-tegra@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).