From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E22F6C48BDF for ; Wed, 9 Jun 2021 10:07:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B536B60FDC for ; Wed, 9 Jun 2021 10:07:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B536B60FDC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yTDTumhJstduHDL9bwUe2rTQ4A5EkInHeIY6Gv1aYD8=; b=ua2sYSuXG+cHNj 80TxjuEafEycBYCMGRpnM43QjCiUtCcmrvHs8kBSkQBWA8CZBVr/hu0tcmrdldPAlSgrzFbTWmEFX kuGpKaF32Cr8wSGFjZm58QI07BHVe69DD+1YJfrPC+HMfuW0dLE9pFgkGSb8+0oiUTJcVBO72ESow aPltxfEs6PvIRPIeGDjvEayhyg/vn96ZC2U8ApcnI98M0FvQ1B9zOANh3PcvacMB4ZP8doHy8Dl9N afYB/L/uo/Mc+XOMoeXQpH1ZByoQ5oqDG3YQH9ixLpdtb/1tw+Yppue1DTw+wTOWZSiSi719X2oek Cao3uH1wiz/fURy8yycg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqv3G-00Cs6c-AD; Wed, 09 Jun 2021 10:03:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lquzZ-00Cqvk-6G for linux-arm-kernel@lists.infradead.org; Wed, 09 Jun 2021 09:59:22 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0AE27610C7; Wed, 9 Jun 2021 09:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623232760; bh=265X25GE4eApAM6xlZqmIshxEVIqMbQhtZIqjtCnlBI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hSfsxRI8do3bXAQ/Hz/dyk02xEU7BgVuNfX27QeJZrVOgg+YbtdX44b9HcMNVPbH3 uRtFPaFPAxW/SUh6J3mieCqdgLVaw3jiTdsVBf9BT4m8e8EYJk68l/u52WDVM7B+yq Jy0zCtGbFmbg2/CzSqfAvke43lXYH/3IBdeIDVys= Date: Wed, 9 Jun 2021 11:59:18 +0200 From: Greg KH To: trix@redhat.com Cc: mdf@kernel.org, michal.simek@xilinx.com, nava.manne@xilinx.com, luca@lucaceresoli.net, linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] fpga: xilinx: remove xilinx- prefix on files Message-ID: References: <20210608162551.3010533-1-trix@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210608162551.3010533-1-trix@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210609_025921_288275_BD01BE8A X-CRM114-Status: GOOD ( 16.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 08, 2021 at 09:25:51AM -0700, trix@redhat.com wrote: > From: Tom Rix > > It is not necessary to have a xilinx- prefix on a file > when the file is in a xilinx/ subdir. > > Signed-off-by: Tom Rix > --- > drivers/fpga/xilinx/Makefile | 4 ++-- > drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} | 0 > drivers/fpga/xilinx/{xilinx-spi.c => spi.c} | 0 > 3 files changed, 2 insertions(+), 2 deletions(-) > rename drivers/fpga/xilinx/{xilinx-pr-decoupler.c => pr-decoupler.c} (100%) > rename drivers/fpga/xilinx/{xilinx-spi.c => spi.c} (100%) > > diff --git a/drivers/fpga/xilinx/Makefile b/drivers/fpga/xilinx/Makefile > index 7bb7543412790..4ac727d03e140 100644 > --- a/drivers/fpga/xilinx/Makefile > +++ b/drivers/fpga/xilinx/Makefile > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > > -obj-$(CONFIG_XILINX_PR_DECOUPLER) += xilinx-pr-decoupler.o > -obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o > +obj-$(CONFIG_XILINX_PR_DECOUPLER) += pr-decoupler.o > +obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += spi.o You just renamed the module to be called "spi.ko"???? Did you test this thing? You can not rename modules without good reasons, and calling a device specific kernel module "spi.ko" is not ok. greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel