From: Greg KH <gregkh@linuxfoundation.org>
To: trix@redhat.com
Cc: mdf@kernel.org, hao.wu@intel.com, michal.simek@xilinx.com,
nava.manne@xilinx.com, dinguyen@kernel.org,
krzysztof.kozlowski@canonical.com, yilun.xu@intel.com,
arnd@arndb.de, fpacheco@redhat.com, richard.gong@intel.com,
luca@lucaceresoli.net, linux-kernel@vger.kernel.org,
linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/4] fpga: reorganize to subdirs
Date: Wed, 9 Jun 2021 16:53:33 +0200 [thread overview]
Message-ID: <YMDV7R52QUTFhpHH@kroah.com> (raw)
In-Reply-To: <20210609142208.3085451-1-trix@redhat.com>
On Wed, Jun 09, 2021 at 07:22:03AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> The incoming xrt patchset has a toplevel subdir xrt/
> The current fpga/ uses a single dir with filename prefixes to subdivide owners
> For consistency, there should be only one way to organize the fpga/ dir.
> Because the subdir model scales better, refactor to use it.
> The discussion wrt xrt is here:
> https://lore.kernel.org/linux-fpga/68e85a4f-4a10-1ff9-0443-aa565878c855@redhat.com/
>
> Follow drivers/net/ethernet/ which has control configs
> NET_VENDOR_BLA that map to drivers/net/ethernet/bla
> Since fpgas do not have many vendors, drop the 'VENDOR' and use
> FPGA_BLA.
>
> There are several new subdirs
> altera/
> dfl/
> lattice/
> xilinx/
>
> Each subdir has a Kconfig that has a new/reused
>
> if FPGA_BLA
> ... existing configs ...
> endif FPGA_BLA
>
> Which is sourced into the main fpga/Kconfig
>
> Each subdir has a Makefile whose transversal is controlled in the
> fpga/Makefile by
>
> obj-$(CONFIG_FPGA_BLA) += bla/
>
> Some cleanup to arrange thing alphabetically and make fpga/Makefile's
> whitespace look more like net/'s
>
> Changes from
> v1
> Drop renaming files
> Cleanup makefiles
You can rename the files, you just can not rename the .ko objects
without everyone knowing what you are doing and you trying to bury it in
the middle of a differently described patch.
If you want to do that, do you? I don't really understand why you want
to move things around right now other than "we have 40 files in one
directory, ick!".
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-09 16:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 14:22 [PATCH v2 0/4] fpga: reorganize to subdirs trix
2021-06-09 14:22 ` trix
2021-06-09 14:22 ` [PATCH v2 1/4] fpga: dfl: reorganize to subdir layout trix
2021-06-09 14:22 ` [PATCH v2 2/4] fpga: xilinx: " trix
2021-06-09 14:55 ` Greg KH
2021-06-09 14:22 ` [PATCH v2 3/4] fpga: altera: " trix
2021-06-09 14:56 ` Greg KH
2021-06-09 14:22 ` [PATCH v2 4/4] fpga: lattice: " trix
2021-06-09 14:56 ` Greg KH
2021-06-09 14:51 ` [PATCH v2 0/4] fpga: reorganize to subdirs Greg KH
2021-06-09 14:53 ` Greg KH [this message]
2021-06-09 15:08 ` Tom Rix
2021-06-09 16:38 ` Greg KH
2021-06-09 16:50 ` Tom Rix
2021-06-09 17:13 ` Greg KH
2021-06-09 18:52 ` Tom Rix
2021-06-09 19:16 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMDV7R52QUTFhpHH@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=dinguyen@kernel.org \
--cc=fpacheco@redhat.com \
--cc=hao.wu@intel.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=mdf@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=nava.manne@xilinx.com \
--cc=richard.gong@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).