From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7623DC48BCF for ; Wed, 9 Jun 2021 17:01:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4128661376 for ; Wed, 9 Jun 2021 17:01:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4128661376 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AdG2zL8ibw7i5pF/DXQuk/gYdJX4JLmWlOJIb1cLNYI=; b=c5QTYd/J05sayhM+UvwDpAWrkE BVqra5DZmpsrchgG9DQ8H2NFAzduMGTAaReBpb1afg6N5OvTf1xfTmim1OvSQhWOVuLHkSbuHTiJK IHFKaL/z0p/+bNuFkGIwJFGVWhubOPPMJh2Pua5DI7EE08pmNPpGifVdG9Vwt52i7gg0lEBF1wQrV se7nBv3xzPfHAmM/i6gs3DJF50vCqLf+SVxTVNjW28H9i3l3YuQw5oB/7tS1NI9HC1E+MHqkytcVb IpR5IHznWCttJMIEID6W45Niz2CMx4+93AHm1nsGjAPDxD4iOkJhw8e4DfhptVV2PVgd3JMlU4PV5 XSFhvQ1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lr1XD-00F7Dl-I5; Wed, 09 Jun 2021 16:58:35 +0000 Received: from mail-pf1-f182.google.com ([209.85.210.182]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lr0Gn-00EdTP-VF for linux-arm-kernel@lists.infradead.org; Wed, 09 Jun 2021 15:37:31 +0000 Received: by mail-pf1-f182.google.com with SMTP id y15so18648147pfl.4 for ; Wed, 09 Jun 2021 08:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=neZ2e107rW6u5+BVpWqPAvfyZBtmzgP4djPpeqRyQ04=; b=p3oEZTsxgUaXISabfNCfwlDjRW2XZRlWVv0TCVqelJkHJNM3/EWJSwsue6tjO4/hhn /vfNCoDxpC6LKITX/NHS/uCxfh+V81P01S14Ux2ihYwvi4a1qnhCxbdaRZR0jv5VBvbi hbUFaLZ/uic5TZYxY6VhezmmWDxp+UqJiwAD8WYYjHJw0KqJYn4RK4RvLppFNGu6LjAW caaZ7rG/9S5XC2gNOEnbbDa8h79L/6/RGaWH0OezCFC/+2HVQ7I4gDWY1Oy0b2KM+Fhy cND97zONfQd+t3dc0lti732r5qaX34Uf33Qtn2mMRUWrtTJl/us2WvKy2aPm6FXKTxzV FzmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=neZ2e107rW6u5+BVpWqPAvfyZBtmzgP4djPpeqRyQ04=; b=WshIKGu8/6LTdUPnsIq0ZE2alqHuUnnff08gwnFzk53lhMzs9xfNI27gbIUPt/oGJX +goYvnhZWr7RhgkAfL7G8sjmVn/6s+MhWyXN3Sb6nU3YPxQoSlQjvOnloiePQFKxcuRm SciQNEE45MvqMSigYSqgl4011McfYW4Tc5g81P8Mj8ro9l8TjYnK3UFwazEP0g3E9yoE uU+IaLcTnwcZkJkmfS/DdOEiQxaJP/H8u0wrCNVq5TEHVkl91RrTsh3lQevb94/3XWN4 HIcv/3aLsjvdgrvcZgYk5eyz2VjcVMWrX51oQ0g7DiyQ87fHMqaEXwaHYqnMpTx/ST0y 94YA== X-Gm-Message-State: AOAM5300h4vZ82wkgjFrBQjqZt7EOdzca+76cePrHhbygJr4M1M+acYw uhum6htVQYDIJrU8+JwFwUk= X-Google-Smtp-Source: ABdhPJwyxxyPeyzTzDbknC8LuuZIDpubLWJAJOncQpZ+ccwe7qvp01K7EbRKkr59WznDo/R+ekfEDg== X-Received: by 2002:a63:ad0f:: with SMTP id g15mr248776pgf.415.1623252989343; Wed, 09 Jun 2021 08:36:29 -0700 (PDT) Received: from shinobu ([156.146.35.76]) by smtp.gmail.com with ESMTPSA id u12sm50028pfm.2.2021.06.09.08.36.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 08:36:28 -0700 (PDT) Date: Thu, 10 Jun 2021 00:36:22 +0900 From: William Breathitt Gray To: o.rempel@pengutronix.de Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, Jonathan Cameron , jarkko.nikula@linux.intel.com Subject: Re: [PATCH v11 14/33] counter: interrupt-cnt: Add const qualifier for actions_list array Message-ID: References: <20210609162942.6bdc6d63@jic23-huawei> MIME-Version: 1.0 In-Reply-To: <20210609162942.6bdc6d63@jic23-huawei> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210609_083730_059715_3ABD65BD X-CRM114-Status: GOOD ( 21.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5854122615480463878==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5854122615480463878== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bM5rh64AbDYaJ0MC" Content-Disposition: inline --bM5rh64AbDYaJ0MC Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 09, 2021 at 04:29:42PM +0100, Jonathan Cameron wrote: > On Wed, 9 Jun 2021 10:31:17 +0900 > William Breathitt Gray wrote: >=20 > > The struct counter_synapse actions_list member expects a const enum > > counter_synapse_action array. This patch adds the const qualifier to the > > interrupt_cnt_synapse_actionss to match actions_list. > >=20 > > Cc: Oleksij Rempel > > Signed-off-by: William Breathitt Gray > Naming looks unusual... >=20 > > --- > > drivers/counter/interrupt-cnt.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/drivers/counter/interrupt-cnt.c b/drivers/counter/interrup= t-cnt.c > > index 827d785e19b4..0e07607f2cd3 100644 > > --- a/drivers/counter/interrupt-cnt.c > > +++ b/drivers/counter/interrupt-cnt.c > > @@ -77,7 +77,7 @@ static const struct counter_count_ext interrupt_cnt_e= xt[] =3D { > > }, > > }; > > =20 > > -static enum counter_synapse_action interrupt_cnt_synapse_actionss[] = =3D { > > +static const enum counter_synapse_action interrupt_cnt_synapse_actions= s[] =3D { >=20 > actions? >=20 > Perhaps good to fix that whilst we are here. >=20 > > COUNTER_SYNAPSE_ACTION_RISING_EDGE, > > }; > > =20 Hi Oleksij, Would you take a look at this driver and let us know whether the two 's' at the end of this symbol is intentional? Thanks, William Breathitt Gray --bM5rh64AbDYaJ0MC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmDA3+UACgkQhvpINdm7 VJJDog/7BWfRthJW0ybnlLsxDyqpvnBx92k2hiBaXR2DX8siYjVeWomh7OpLXzwf C84Ze4rdn8H6/Dpc3wA8vDiUUHX9VwIcACOpOh2KJ2IoF5AdrOzLjS9b+a+ZFusC mpbvfXz6/VxKgqjQY8JY+dgTFiROGNnJrllDaCV1sNPRPa/WwmGVSgh8b/+UMeBd e3QOQ5JG77FfWwzV0jjSw9Tq1e7fr+qbtg0v0Nvz74AGePCEsetIxQyA13HWyaEP qlMDIi0yrsbveBx+uUyhJ64hulLu9xRLuGFdtvdICP+b8WohDzykuVTPqHk4z9Ki hNTDtA7qZIZTDlBMVlC3XNGiEfd/B5CIktmatlQVmDmpOF/FaJmF/UyUFXJxG+IE ZH7AuxS8lNtxetA/AAM8ED82WJZ2BWLPW6OZc1HUt41r2eJNsqeCA/fCzrvdEeHg FcSnqxuAwWI9TZ4w1jiaiVTV6N4Z4aNsH9uoX4MSHp/y0obm1hQh2tBZc55DG1Nn 0skswdQVV8k5mjJO4fTMZF8H9N+026UpRZ8bnoO7XkeIs39sPSSmVJo6r3ZDoxiL Rlsd3zp2ByCk5+DfeZLaBCpNWwwndrx2SSq/EN9pKDq3OnkwXs37T8Arql2zfP31 xaeIQUCVKnZE3q7xJV+4EL38BTDw1n8QzrLylft6fViv6xNVAR8= =0g9k -----END PGP SIGNATURE----- --bM5rh64AbDYaJ0MC-- --===============5854122615480463878== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5854122615480463878==--