From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCCA5C48BCD for ; Wed, 9 Jun 2021 17:05:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA7BD613C7 for ; Wed, 9 Jun 2021 17:05:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA7BD613C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1Eh6YEGaEB1xMSMnH8hCc/scCXTbiQ01KbL6q0CV5Ao=; b=bXPh3Uf/4Ic2NWHgFVU+4HalEQ QKbv34lIkc3l+8zZQNhPMq2+zC0Vywo3IQmOoS/W3qjD41cBBN6XZqxFcA2tNDB3c8AEFoAKXRPmF blETuvjKu6A4/M/xyRJEj2vCmAoUBxAbmlHdDPqelqYzu02Ovjvz188Se3/8exhTENicXIMiceY65 3KY9uqGvRmya69PkPxk1gr9fbsyJ9pWnKl8zoStGGFumFADKi0doBDUa3iPh0lR1P7imHXeeZHiiU FXX+8+4JodX4VFOiNdzMN+KGLkSBifqMZ2az5FyZRZRz00vE7YeTW/V6BqZspYz6zGDPSzajvpGtu nQOfmj1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lr1bm-00F9US-0I; Wed, 09 Jun 2021 17:03:16 +0000 Received: from mail-pj1-f42.google.com ([209.85.216.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lr0SG-00Ehvk-CF for linux-arm-kernel@lists.infradead.org; Wed, 09 Jun 2021 15:49:21 +0000 Received: by mail-pj1-f42.google.com with SMTP id ei4so1574684pjb.3 for ; Wed, 09 Jun 2021 08:49:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vyDVyLfPuRvXW3psMvZrGfoYLzSaxY+80nkzI+WIEzE=; b=PucRjujR5+uxNW2fJVOa9kbmJrNpVaZIPswxY7Ka6pj99DjNm2EHCwpbLk1u3/IWu2 uOL8lFiT/VGSKYWcqw9moHzqwv3aiB2d1XZ5+JmzsrP3GBL65uAn6Ao2MynTCM1sCzZ8 2Zr01Mr2Wt9qtRWNCr42VQ3lw4kNNt2PIj7xW+JNejMN6JJ1zC0o5niyCk/Z3nAWWvVj OHgZA3Gx/eLzkn3PCWRc3J2pFc4LALQ9qLiAy1j4KyPkQ+yROrkJi3K186md29/4KBuz 9BLbi5rrcFxb6fVQQE0IbbuIeN4ns1tqKv9rdmqHsCgMByl8m+MfHl9G64aUO/Kk/6ND UC2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vyDVyLfPuRvXW3psMvZrGfoYLzSaxY+80nkzI+WIEzE=; b=DI+hyUPx/ht9vyZ4zrGtckKR+7g3TGye0L8DyKpsCZQUWkvzrULGKPiitndpf9NoUj 190Z5xqKVjRfeGzZ7kllseEJnY1AUqX2l2e3HZlvXQl3FNCCXwxObAtQHGWXJnuzsSJH a23k3UNCi5JKICGDTWh2t33KSceQNMoETbvA2Eqfg08zQiNTUqsiDX6Km8OwhMdmaqMF wBWyKg0jQBw33q+e8ko3+em6bxyGpKuHAuUYqUIr7BlpHclXNR0mqDMm0ZkjOVPvUw4g dbll3emmTiR9u185TxxeOp2xoqwtufu7XSktvFEUeVBYc/6lT2/i6WpH99QQcK6v1kkP Qohw== X-Gm-Message-State: AOAM532avaxTtWDte4ga7foNwJr8HCVYSgRkpoFGYlB9gyCbaRD/EX8c 5atN/hBvGN4xNV+YfTnbRBI= X-Google-Smtp-Source: ABdhPJxh5GLIqWkiRPPzW4Lzh/aEcbyNHtsNthc3er14l4v+e0TkJxr2O5pS0qkS61zBXhjW9z8dzQ== X-Received: by 2002:a17:90a:c8b:: with SMTP id v11mr4532868pja.114.1623253699327; Wed, 09 Jun 2021 08:48:19 -0700 (PDT) Received: from shinobu ([156.146.35.76]) by smtp.gmail.com with ESMTPSA id q23sm213042pgm.31.2021.06.09.08.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 08:48:18 -0700 (PDT) Date: Thu, 10 Jun 2021 00:48:12 +0900 From: William Breathitt Gray To: syednwaris@gmail.com, Jonathan Cameron Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com Subject: Re: [PATCH v11 04/33] counter: 104-quad-8: Return error when invalid mode during ceiling_write Message-ID: References: <538122752d61df30dd450276b87df606a17ac4c7.1623201081.git.vilhelm.gray@gmail.com> <20210609161236.52b2d99f@jic23-huawei> MIME-Version: 1.0 In-Reply-To: <20210609161236.52b2d99f@jic23-huawei> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210609_084920_466380_15566D72 X-CRM114-Status: GOOD ( 23.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6712033757663905500==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6712033757663905500== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HwSslquuWeRs22J3" Content-Disposition: inline --HwSslquuWeRs22J3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 09, 2021 at 04:12:36PM +0100, Jonathan Cameron wrote: > On Wed, 9 Jun 2021 10:31:07 +0900 > William Breathitt Gray wrote: >=20 > > The 104-QUAD-8 only has two count modes where a ceiling value makes > > sense: Range Limit and Modulo-N. Outside of these two modes, setting a > > ceiling value is an invalid operation -- so let's report it as such by > > returning -EINVAL. > >=20 > > Fixes: fc069262261c ("counter: 104-quad-8: Add lock guards - generic in= terface") > > Acked-by: Syed Nayyar Waris > > Signed-off-by: William Breathitt Gray >=20 > We seem to have some inconsistency in the driver about whether > we hold the priv->lock when calling quad8_preset_register_set() >=20 > Can we look to make that consistent? We do need to hold the lock when calling quad8_preset_register_set() lest priv->preset goes out of sync with the device state. Syed, if you have no objections I'll adjust this in the next version. William Breathitt Gray > > --- > > drivers/counter/104-quad-8.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > >=20 > > diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c > > index 4bb9abffae48..233a3acc1377 100644 > > --- a/drivers/counter/104-quad-8.c > > +++ b/drivers/counter/104-quad-8.c > > @@ -714,13 +714,14 @@ static ssize_t quad8_count_ceiling_write(struct c= ounter_device *counter, > > switch (priv->count_mode[count->id]) { > > case 1: > > case 3: > > + mutex_unlock(&priv->lock); >=20 > Probably swap this line and the next one...] >=20 > > quad8_preset_register_set(priv, count->id, ceiling); > > - break; > > + return len; > > } > > =20 > > mutex_unlock(&priv->lock); > > =20 > > - return len; > > + return -EINVAL; > > } > > =20 > > static ssize_t quad8_count_preset_enable_read(struct counter_device *c= ounter, >=20 --HwSslquuWeRs22J3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmDA4rwACgkQhvpINdm7 VJKcxRAA2lDJEsRamD6ptPESbNoCgjVVQCRWJX7wfOydG31YyVXdbmR22IhLx02N KKYKMtnDY5oeGqszRcdJzLS+N/i8TuDtWmmFmWJrAUICaf/rHcyLVNuO1qy0VEQM oe5xjSegTK8NPDvWxp9Z9zWmSlseO9QccbMyjm8fhHMAuHt1F0PE0ua3S1ttHQz8 2VnVALRTWZfl8nEMr+5Mjs6x+9U5o3oGQ5Xh4BlVFN7wmDsoSmMTgjTx8fBpzrRq /IVS+xDKCJa12JcucBr+dk1TROTFQoLLfL2MEJHfdbfGfnjfSPMgdY/dnsviAxLn JZAEdoEGhvFHi/zlFqG+zTXry1rRFPoye2nImJt/sb8sj57qlm3jbJneLUtNjswW qjrb9IhXdsKcPen/chKRoavCmlvbsbT9+ob0OajQmCp55MaWmhWMiLpIXyE00Srb 7F1qKB2G87eF3i1Wjgc2j9YEIgsgVkF95wJZXZ1fr7Qd2VIWT//tyIBGjyewwX2a mCjVFX6epV2CMf8AiMS0KGyP8kRfeWr9nNN27cOtR5plvEN/kFp7uaibI8W/7A1d iFYXeoTy0u1jt46np6EXG/FfiQ38nKikSxkLqOu2pvJLDlQ9j0CQ0D40rDG0B//d 5RywU+DSHx6rtYQJmQZFPJiXecM4wVpqHKmmPFv3IuNJHthtmVM= =u514 -----END PGP SIGNATURE----- --HwSslquuWeRs22J3-- --===============6712033757663905500== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6712033757663905500==--