From: Abel Vesa <abel.vesa@nxp.com>
To: Dong Aisheng <aisheng.dong@nxp.com>
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
sboyd@kernel.org, dongas86@gmail.com, shawnguo@kernel.org,
kernel@pengutronix.de, "Guoniu.zhou" <guoniu.zhou@nxp.com>
Subject: Re: [PATCH 02/10] clk: imx: scu: add parallel port clock ops
Date: Mon, 14 Jun 2021 11:53:23 +0300 [thread overview]
Message-ID: <YMcZA7dQd0zT6eml@ryzen.lan> (raw)
In-Reply-To: <20210604090943.3519350-3-aisheng.dong@nxp.com>
On 21-06-04 17:09:35, Dong Aisheng wrote:
> From: "Guoniu.zhou" <guoniu.zhou@nxp.com>
>
> Because digital pll for parallel interface is on by default, and
> not provide enable/disable function by scu, so add the related ops
> for this kind of clocks.
>
> Signed-off-by: Guoniu.zhou <guoniu.zhou@nxp.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
This looks OK to me.
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
> ---
> drivers/clk/imx/clk-scu.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
> index f4efb3b76c86..680b2650fd45 100644
> --- a/drivers/clk/imx/clk-scu.c
> +++ b/drivers/clk/imx/clk-scu.c
> @@ -425,6 +425,12 @@ static const struct clk_ops clk_scu_cpu_ops = {
> .unprepare = clk_scu_unprepare,
> };
>
> +static const struct clk_ops clk_scu_pi_ops = {
> + .recalc_rate = clk_scu_recalc_rate,
> + .round_rate = clk_scu_round_rate,
> + .set_rate = clk_scu_set_rate,
> +};
> +
> struct clk_hw *__imx_clk_scu(struct device *dev, const char *name,
> const char * const *parents, int num_parents,
> u32 rsrc_id, u8 clk_type)
> @@ -445,6 +451,8 @@ struct clk_hw *__imx_clk_scu(struct device *dev, const char *name,
> init.ops = &clk_scu_ops;
> if (rsrc_id == IMX_SC_R_A35)
> init.ops = &clk_scu_cpu_ops;
> + else if (rsrc_id == IMX_SC_R_PI_0_PLL)
> + init.ops = &clk_scu_pi_ops;
> else
> init.ops = &clk_scu_ops;
> init.parent_names = parents;
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-14 8:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 9:09 [PATCH 00/10] clk: imx: scu: add more scu clock features Dong Aisheng
2021-06-04 9:09 ` [PATCH 01/10] clk: imx: scu: add more scu clocks Dong Aisheng
2021-06-14 8:52 ` Abel Vesa
2021-06-04 9:09 ` [PATCH 02/10] clk: imx: scu: add parallel port clock ops Dong Aisheng
2021-06-14 8:53 ` Abel Vesa [this message]
2021-06-04 9:09 ` [PATCH 03/10] clk: imx: scu: bypass cpu clock save and restore Dong Aisheng
2021-06-14 8:54 ` Abel Vesa
2021-06-04 9:09 ` [PATCH 04/10] clk: imx: scu: detach pd if can't power up Dong Aisheng
2021-06-14 8:55 ` Abel Vesa
2021-06-04 9:09 ` [PATCH 05/10] clk: imx: scu: bypass pi_pll enable status restore Dong Aisheng
2021-06-14 8:57 ` Abel Vesa
2021-06-04 9:09 ` [PATCH 06/10] clk: imx: scu: Add A53 frequency scaling support Dong Aisheng
2021-06-04 9:09 ` [PATCH 07/10] clk: imx: scu: Add A72 " Dong Aisheng
2021-06-04 9:09 ` [PATCH 08/10] clk: imx: scu: Only save DC SS clock using non-cached clock rate Dong Aisheng
2021-06-04 9:09 ` [PATCH 09/10] clk: imx: scu: add parent save and restore Dong Aisheng
2021-06-04 9:09 ` [PATCH 10/10] clk: imx: scu: Do not enable runtime PM for CPU clks Dong Aisheng
2021-06-14 9:07 ` [PATCH 00/10] clk: imx: scu: add more scu clock features Abel Vesa
2021-06-14 10:22 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMcZA7dQd0zT6eml@ryzen.lan \
--to=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=dongas86@gmail.com \
--cc=guoniu.zhou@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).