From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35354C48BE5 for ; Tue, 15 Jun 2021 19:13:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E52026109E for ; Tue, 15 Jun 2021 19:13:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E52026109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9ig0xa9Yea18rsoWVJ7wGctwm2Zb1UOZR3tYWssJVRo=; b=W1/ZyKEaai8Tls KsB5kAxjQxxN8wSKcWQKaZ7KexkNVCox6GUU2cPBSpx49E+MN5yP5eIKzsEqfa3mg7qSyksRwfQWe 5p2UzKCxKvzJXVX7g0KHDkSB3K19GAxJNGfBMbwLbuqesVH+ApiccXdAWKSRN5bTWiyiaS6O6gnvg DYprY798LGoR791RLqjsVyXuDTlhdHx+plkrOaxOWh1Zg+BVLR39BijgtFVH/gjt+Pk6+G6jFpsYY tBqBnAssd+PrtHf4sqQ/H8lyeyTnn2LvJSyv6pj5cKYSBLVQi1+y7W3kHhbN1Us29GiMuQmzhWd9O U4zy3yP9q297tgUAAhgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltET0-002La4-8c; Tue, 15 Jun 2021 19:11:18 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt9N0-000E8e-Ik for linux-arm-kernel@bombadil.infradead.org; Tue, 15 Jun 2021 13:44:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gsoK29CpHQLA/GfD4R0SbpKiCQ+DkUxbidUbSWuX6DE=; b=rAeK6+3iuHgsWADaagBmxK4KgF jytw26z3HHtX2XogC8unXvd+TTCN80e7bme3qsskUs3Mn49VfzKrS0bGvwdTU0rOFuKKsSOsCn9O7 Ame2BfMKznsGA7uVnLHfgY0WN1MBy45sVLba/Za23dPuH50Njmnxhpysavxpz8yRNWPxRd4PdoGpX mNsAHngLS7HTCE2/94cvGsMbguAcAJasto39UphbxnfVW3yosipNCwWo9aLeFO+qXj5Xf9g7Zl3Kb EVBWGTgTO8HP3GzH9w4kuJ9g3io1OO/tBmFapkrcwq5arv7gJspO5it7An6ya+U2Q3CfTzQY4N0EI 0iHvC9LQ==; Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt15h-007LcG-8p for linux-arm-kernel@lists.infradead.org; Tue, 15 Jun 2021 04:54:30 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C9608613DA; Tue, 15 Jun 2021 04:54:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623732866; bh=/MfjuVHcyNn6fWowwYthRN2342Yc3ZUOxofEdm2nQBY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mMFrdbhvWXdpjLcxuF3xf6vpkmJXjrIG3jyesSwW0e7ng00LGZCzzBO7njw6I6VRI x1TVfe/rVZpdnYYsgO24AZwso/Pai1tDN0J4ujKKm1l/N5eummTxlpGaYlJ2KV42g/ vJb7hlfVt2fJWFpvqAAvDAuUp8KiYA4N69bZBWI4= Date: Tue, 15 Jun 2021 06:54:23 +0200 From: Greg KH To: Siddharth Gupta Cc: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v3 3/4] remoteproc: core: Fix cdev remove and rproc del Message-ID: References: <1623723671-5517-1-git-send-email-sidgup@codeaurora.org> <1623723671-5517-4-git-send-email-sidgup@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1623723671-5517-4-git-send-email-sidgup@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_055428_339238_1B372670 X-CRM114-Status: GOOD ( 14.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 14, 2021 at 07:21:10PM -0700, Siddharth Gupta wrote: > The rproc_char_device_remove() call currently unmaps the cdev > region instead of simply deleting the cdev that was added as a > part of the rproc_char_device_add() call. This change fixes that > behaviour, and also fixes the order in which device_del() and > cdev_del() need to be called. > > Signed-off-by: Siddharth Gupta > --- > drivers/remoteproc/remoteproc_cdev.c | 2 +- > drivers/remoteproc/remoteproc_core.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel