From: Matthew Wilcox <willy@infradead.org>
To: Janghyuck Kim <janghyuck.kim@samsung.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Palmer Dabbelt <palmerdabbelt@google.com>,
Atish Patra <atish.patra@wdc.com>, Gavin Shan <gshan@redhat.com>,
Zhengyuan Liu <liuzhengyuan@tj.kylinos.cn>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/2] mm: support fastpath if NUMA is enabled with numa off
Date: Wed, 16 Jun 2021 18:32:50 +0100 [thread overview]
Message-ID: <YMo1wik1plVotC1N@casper.infradead.org> (raw)
In-Reply-To: <20210616083745.14288-1-janghyuck.kim@samsung.com>
On Wed, Jun 16, 2021 at 05:37:41PM +0900, Janghyuck Kim wrote:
> Architecture might support fake node when CONFIG_NUMA is enabled but any
> node settings were supported by ACPI or device tree. In this case,
> getting memory policy during memory allocation path is meaningless.
>
> Moreover, performance degradation was observed in the minor page fault
> test, which is provided by (https://lkml.org/lkml/2006/8/29/294).
> Average faults/sec of enabling NUMA with fake node was 5~6 % worse than
> disabling NUMA. To reduce this performance regression, fastpath is
> introduced. fastpath can skip the memory policy checking if NUMA is
> enabled but it uses fake node. If architecture doesn't support fake
> node, fastpath affects nothing for memory allocation path.
This patch doesn't even apply to the current kernel, but putting that
aside, what's the expensive part of the current code? That is,
comparing performance stats between this numa_off enabled and numa_off
disabled, where do you see taking a lot of time?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-16 17:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210616081628epcas2p3f919d10029cbe01efa1212a5b861af38@epcas2p3.samsung.com>
2021-06-16 8:37 ` [PATCH 1/2] mm: support fastpath if NUMA is enabled with numa off Janghyuck Kim
[not found] ` <CGME20210616081632epcas2p46436c362f3d97c9c1fb09dbb11d64ad7@epcas2p4.samsung.com>
2021-06-16 8:37 ` [PATCH 2/2] arm64: numa: support numa_off_fastpath Janghyuck Kim
2021-06-16 17:10 ` [PATCH 1/2] mm: support fastpath if NUMA is enabled with numa off Vlastimil Babka
2021-06-17 11:42 ` Janghyuck Kim
2021-06-16 17:32 ` Matthew Wilcox [this message]
2021-06-17 11:55 ` Janghyuck Kim
2021-06-17 12:40 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMo1wik1plVotC1N@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=atish.patra@wdc.com \
--cc=catalin.marinas@arm.com \
--cc=gshan@redhat.com \
--cc=janghyuck.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuzhengyuan@tj.kylinos.cn \
--cc=palmerdabbelt@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).