From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de,
a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com,
gwendal@chromium.org, alexandre.belloni@bootlin.com,
david@lechnology.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com,
patrick.havelange@essensium.com, fabrice.gasnier@st.com,
mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com,
Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Subject: Re: [PATCH v11 18/33] counter: Return error code on invalid modes
Date: Sat, 3 Jul 2021 19:41:39 +0900 [thread overview]
Message-ID: <YOA+456Ns2PKdKa8@shinobu> (raw)
In-Reply-To: <20210609164731.2180e4e4@jic23-huawei>
[-- Attachment #1.1: Type: text/plain, Size: 4559 bytes --]
On Wed, Jun 09, 2021 at 04:47:31PM +0100, Jonathan Cameron wrote:
> On Wed, 9 Jun 2021 10:31:21 +0900
> William Breathitt Gray <vilhelm.gray@gmail.com> wrote:
> > diff --git a/drivers/counter/stm32-lptimer-cnt.c b/drivers/counter/stm32-lptimer-cnt.c
> > index c19d998df5ba..78f383b77bd2 100644
> > --- a/drivers/counter/stm32-lptimer-cnt.c
> > +++ b/drivers/counter/stm32-lptimer-cnt.c
> > @@ -206,9 +206,10 @@ static int stm32_lptim_cnt_function_set(struct counter_device *counter,
> > priv->quadrature_mode = 1;
> > priv->polarity = STM32_LPTIM_SYNAPSE_ACTION_BOTH_EDGES;
> > return 0;
> > + default:
> > + /* should never reach this path */
> > + return -EINVAL;
>
> In this particular case we are already exhaustive. So we should have neither default
> nor ideally the return below.
>
> If we have a local variable of the relevant enum type, then I think the compiler
> should be able to tell this is exhaustive and usefully it will then issue
> a warning should the enum gain more entries in future.
I tried using a local variable of type enum stm32_lptim_cnt_function,
but unfortunately the compiler is not able to tell this is exhaustive --
I think it's because 'function' is of type enum counter_function which
can theoretically have a value outside enum stm32_lptim_cnt_function.
>
> > }
> > -
> > - return -EINVAL;
> > }
> >
> > static ssize_t stm32_lptim_cnt_enable_read(struct counter_device *counter,
> > @@ -326,9 +327,10 @@ static int stm32_lptim_cnt_action_get(struct counter_device *counter,
> > case STM32_LPTIM_ENCODER_BOTH_EDGE:
> > *action = priv->polarity;
> > return 0;
> > + default:
>
> Same in this path.
>
> > + /* should never reach this path */
> > + return -EINVAL;
> > }
> > -
> > - return -EINVAL;
> > }
> >
> > static int stm32_lptim_cnt_action_set(struct counter_device *counter,
> > diff --git a/drivers/counter/ti-eqep.c b/drivers/counter/ti-eqep.c
> > index 65df9ef5b5bc..878725c2f010 100644
> > --- a/drivers/counter/ti-eqep.c
> > +++ b/drivers/counter/ti-eqep.c
> > @@ -157,44 +157,39 @@ static int ti_eqep_action_get(struct counter_device *counter,
> > * QEPA and QEPB trigger QCLK.
> > */
> > *action = TI_EQEP_SYNAPSE_ACTION_BOTH_EDGES;
> > - break;
> > + return 0;
> > case TI_EQEP_COUNT_FUNC_DIR_COUNT:
> > /* In direction-count mode only rising edge of QEPA is counted
> > * and QEPB gives direction.
> > */
> > - switch (synapse->signal->id) {
> I'd rather see this as
>
> case TI_EQEP_SIGNAL_QEPA:
> caes TI_EQEP_SIGNAL_QEPB:
>
> To make it clear what the two cases are. Then we don't need the default
> assuming the type is right so the compiler should be able to see
> that we have been exhaustive.
I can refactor this back to a switch statement as you suggest, but we'll
need the default case for the same reason as mentioned above.
William Breathitt Gray
>
> > - case TI_EQEP_SIGNAL_QEPA:
> > - *action = TI_EQEP_SYNAPSE_ACTION_RISING_EDGE;
> > - break;
> > - default:
> > + if (synapse->signal->id == TI_EQEP_SIGNAL_QEPB)
> > *action = TI_EQEP_SYNAPSE_ACTION_NONE;
> > - break;
> > - }
> > - break;
> > + else
> > + *action = TI_EQEP_SYNAPSE_ACTION_RISING_EDGE;
> > + return 0;
> > case TI_EQEP_COUNT_FUNC_UP_COUNT:
> > case TI_EQEP_COUNT_FUNC_DOWN_COUNT:
> > /* In up/down-count modes only QEPA is counted and QEPB is not
> > * used.
> > */
> > - switch (synapse->signal->id) {
> > - case TI_EQEP_SIGNAL_QEPA:
> > - err = regmap_read(priv->regmap16, QDECCTL, &qdecctl);
> > - if (err)
> > - return err;
> > -
> > - if (qdecctl & QDECCTL_XCR)
> > - *action = TI_EQEP_SYNAPSE_ACTION_BOTH_EDGES;
> > - else
> > - *action = TI_EQEP_SYNAPSE_ACTION_RISING_EDGE;
> > - break;
> > - default:
> > + if (synapse->signal->id == TI_EQEP_SIGNAL_QEPB) {
> > *action = TI_EQEP_SYNAPSE_ACTION_NONE;
>
> Same as above
>
> > - break;
> > + return 0;
> > }
> > - break;
> > - }
> >
> > - return 0;
> > + err = regmap_read(priv->regmap16, QDECCTL, &qdecctl);
> > + if (err)
> > + return err;
> > +
> > + if (qdecctl & QDECCTL_XCR)
> > + *action = TI_EQEP_SYNAPSE_ACTION_BOTH_EDGES;
> > + else
> > + *action = TI_EQEP_SYNAPSE_ACTION_RISING_EDGE;
> > + return 0;
> > + default:
> > + /* should never reach this path */
> > + return -EINVAL;
> > + }
> > }
> >
> > static const struct counter_ops ti_eqep_counter_ops = {
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-03 10:44 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 1:31 [PATCH v11 00/33] Introduce the Counter character device interface William Breathitt Gray
2021-06-09 1:31 ` [PATCH v11 01/33] docs: counter: Consolidate Counter sysfs attributes documentation William Breathitt Gray
2021-06-09 14:55 ` Jonathan Cameron
2021-06-09 1:31 ` [PATCH v11 02/33] docs: counter: Fix spelling William Breathitt Gray
2021-06-09 15:02 ` Jonathan Cameron
2021-06-09 1:31 ` [PATCH v11 03/33] counter: 104-quad-8: Remove pointless comment William Breathitt Gray
2021-06-09 15:02 ` Jonathan Cameron
2021-06-09 1:31 ` [PATCH v11 04/33] counter: 104-quad-8: Return error when invalid mode during ceiling_write William Breathitt Gray
2021-06-09 15:12 ` Jonathan Cameron
2021-06-09 15:48 ` William Breathitt Gray
2021-06-09 1:31 ` [PATCH v11 05/33] counter: 104-quad-8: Annotate hardware config module parameter William Breathitt Gray
2021-06-09 15:17 ` Jonathan Cameron
2021-06-09 1:31 ` [PATCH v11 06/33] counter: 104-quad-8: Add const qualifiers for quad8_preset_register_set William Breathitt Gray
2021-06-09 15:19 ` Jonathan Cameron
2021-06-09 1:31 ` [PATCH v11 07/33] counter: 104-quad-8: Add const qualifier for functions_list array William Breathitt Gray
2021-06-09 15:20 ` Jonathan Cameron
2021-06-09 1:31 ` [PATCH v11 08/33] counter: interrupt-cnt: " William Breathitt Gray
2021-06-09 15:21 ` Jonathan Cameron
2021-06-09 1:31 ` [PATCH v11 09/33] counter: microchip-tcb-capture: " William Breathitt Gray
2021-06-09 15:22 ` Jonathan Cameron
2021-06-09 1:31 ` [PATCH v11 10/33] counter: stm32-lptimer-cnt: " William Breathitt Gray
2021-06-09 15:25 ` Jonathan Cameron
2021-06-09 1:31 ` [PATCH v11 11/33] counter: stm32-timer-cnt: " William Breathitt Gray
2021-06-09 15:25 ` Jonathan Cameron
2021-06-09 1:31 ` [PATCH v11 12/33] counter: 104-quad-8: Add const qualifier for actions_list array William Breathitt Gray
2021-06-09 15:27 ` Jonathan Cameron
2021-06-09 1:31 ` [PATCH v11 13/33] counter: ftm-quaddec: " William Breathitt Gray
2021-06-09 15:28 ` Jonathan Cameron
2021-06-09 1:31 ` [PATCH v11 14/33] counter: interrupt-cnt: " William Breathitt Gray
2021-06-09 15:29 ` Jonathan Cameron
2021-06-09 15:36 ` William Breathitt Gray
2021-06-09 1:31 ` [PATCH v11 15/33] counter: microchip-tcb-capture: " William Breathitt Gray
2021-06-09 15:30 ` Jonathan Cameron
2021-06-09 1:31 ` [PATCH v11 16/33] counter: stm32-lptimer-cnt: " William Breathitt Gray
2021-06-09 15:32 ` Jonathan Cameron
2021-06-09 1:31 ` [PATCH v11 17/33] counter: stm32-timer-cnt: " William Breathitt Gray
2021-06-09 15:33 ` Jonathan Cameron
2021-06-09 1:31 ` [PATCH v11 18/33] counter: Return error code on invalid modes William Breathitt Gray
2021-06-09 15:47 ` Jonathan Cameron
2021-07-03 10:41 ` William Breathitt Gray [this message]
2021-06-09 1:31 ` [PATCH v11 19/33] counter: Standardize to ERANGE for limit exceeded errors William Breathitt Gray
2021-06-09 1:31 ` [PATCH v11 20/33] counter: Rename counter_signal_value to counter_signal_level William Breathitt Gray
2021-06-09 1:31 ` [PATCH v11 21/33] counter: Rename counter_count_function to counter_function William Breathitt Gray
2021-06-09 1:31 ` [PATCH v11 23/33] counter: Update counter.h comments to reflect sysfs internalization William Breathitt Gray
2021-06-09 16:55 ` Jonathan Cameron
2021-06-09 1:31 ` [PATCH v11 24/33] docs: counter: Update " William Breathitt Gray
2021-06-09 1:31 ` [PATCH v11 25/33] counter: Move counter enums to uapi header William Breathitt Gray
2021-06-09 1:31 ` [PATCH v11 26/33] counter: Add character device interface William Breathitt Gray
2021-06-09 8:07 ` Dan Carpenter
2021-06-09 8:28 ` William Breathitt Gray
2021-06-09 8:59 ` Dan Carpenter
2021-06-09 14:16 ` William Breathitt Gray
2021-06-09 1:31 ` [PATCH v11 27/33] docs: counter: Document " William Breathitt Gray
2021-06-09 1:31 ` [PATCH v11 28/33] tools/counter: Create Counter tools William Breathitt Gray
2021-06-09 1:31 ` [PATCH v11 29/33] counter: Implement signalZ_action_component_id sysfs attribute William Breathitt Gray
2021-06-09 1:31 ` [PATCH v11 30/33] counter: Implement *_component_id sysfs attributes William Breathitt Gray
2021-06-09 1:31 ` [PATCH v11 31/33] counter: Implement events_queue_size sysfs attribute William Breathitt Gray
2021-06-09 1:31 ` [PATCH v11 32/33] counter: 104-quad-8: Replace mutex with spinlock William Breathitt Gray
2021-06-09 1:31 ` [PATCH v11 33/33] counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8 William Breathitt Gray
2021-06-09 17:27 ` Jonathan Cameron
2021-06-09 13:59 ` [PATCH v11 00/33] Introduce the Counter character device interface Jonathan Cameron
2021-06-09 14:26 ` William Breathitt Gray
[not found] ` <87dec6c889e40068ed27cbb3e66a6376856e2267.1623201082.git.vilhelm.gray@gmail.com>
2021-06-09 16:51 ` [RESEND PATCH v11 22/33] counter: Internalize sysfs interface code Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOA+456Ns2PKdKa8@shinobu \
--to=vilhelm.gray@gmail.com \
--cc=a.fatoum@pengutronix.de \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@st.com \
--cc=david@lechnology.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=fabrice.gasnier@st.com \
--cc=gwendal@chromium.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=jic23@kernel.org \
--cc=kamel.bouhara@bootlin.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=patrick.havelange@essensium.com \
--cc=syednwaris@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).