From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5242BC07E99 for ; Fri, 9 Jul 2021 09:08:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18E15613D9 for ; Fri, 9 Jul 2021 09:08:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18E15613D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h5FiPZ4jn8i0Yzd0Pkxg97MkL9QRHeKZqHSXGyvOkdI=; b=As+FeHwwBVs5L3 LF1ni2vZvSAFBXSibWRWcE7IqI3nyuTJST3QRFDLWF3Cra4VuKNCpODxqYHmDoVIo2QaTkkYRoZdV +BT9cdSaiKUjrA8vWf2ICe0uPzrTiAbwj/wbKwtJV8viCjFYZwIDWCbVKetkUlqBaBR9NAkAJhG1t 7K+dhzoK2hl1e9aVKs49Y3ctAYHch3EugqB+hDLP0AzHvBQaCx39qR8p7Pxsc4GTPMOtdnzfMqXIX vDXe84+7t9fMyf4EOneKFLUDnZG9v002GJJ45PCufidEGle+wLJ/+HUKWiEdzlb9FKwv64d8YkhvI vjJtk/XwRiPmcSQcS0ZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1mTi-001Fy9-8J; Fri, 09 Jul 2021 09:07:22 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1mTd-001Fwl-SB for linux-arm-kernel@lists.infradead.org; Fri, 09 Jul 2021 09:07:19 +0000 Received: by mail-pj1-x1036.google.com with SMTP id d9-20020a17090ae289b0290172f971883bso7287168pjz.1 for ; Fri, 09 Jul 2021 02:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/uc9H5zfGGjDARI0YzyvKzeEpD2wOClc3tIHfeaLQnc=; b=M+M0yYUEtZSkXRq1SttoHZPElhf5y1HWt6Uqd2WPOVvykCW2uMKJo+dWqB/b7T/uAQ fjosM8Kqi5f4SzbPGwYgm4oKpWD1wzaolrW0tjV2nOJFb+dnjxqqmOLl52TBqBzgacFW P0+adWQQUibpuf3s3sD9DAyLwdemH1TUc3jSA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/uc9H5zfGGjDARI0YzyvKzeEpD2wOClc3tIHfeaLQnc=; b=qp1FxXVcdxb6a9llzjO8Ws6MeRFrdNBMxkSu9O75lFtHV4cqxYxWg/WZv7WlJtXjbI g9CtUjgozQVz+MiPZ73XRqe6mEu5btSAGK4DHedUjqMvdiFtR3/v5SxaSAu/iNWt6a+m fHSAc1MJ7C2zuPJ/gpVvIVPmVSUD+rpzUwVe2NZ+HwCKqhRaeIFKXiByv0VzoDCowzW9 Gz3mRzNr0DPmUc/zi6QSj26I7UDz0mNLyaYWCty0p+I+EoFASYIORq2eYupmPvgTF8Pk CrC+EjnQl3TKZ9/pB0lipcwx6P3FgWCraSQisLcgUw9CMhYN45ELmfUHvPqybjXxuYRv mH1Q== X-Gm-Message-State: AOAM533D98Yerl2nZC802hB6CaGgbG/aHR3js33zKEsTNRPs2OStlV/K JIBfjcwRrEBd2EZL1trc4NHyZg== X-Google-Smtp-Source: ABdhPJz4I0POPOVj3Wkh8i4WXpamcrEJC3Grht7ICVEj/onjcRzdIfX2RaRoNse5+ehpA/w95ZtaNA== X-Received: by 2002:a17:90a:4595:: with SMTP id v21mr9612932pjg.202.1625821636697; Fri, 09 Jul 2021 02:07:16 -0700 (PDT) Received: from chromium.org ([2401:fa00:8f:203:735b:c3cc:6957:ae6d]) by smtp.gmail.com with ESMTPSA id 21sm4831945pfh.103.2021.07.09.02.07.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jul 2021 02:07:16 -0700 (PDT) Date: Fri, 9 Jul 2021 18:07:11 +0900 From: Tomasz Figa To: Tzung-Bi Shih Cc: "kyrie.wu" , Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Bin Liu , Matthias Brugger , Tzung-Bi Shih , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, xia.jiang@mediatek.com, maoguang.meng@mediatek.com, srv_heupstream@mediatek.com Subject: Re: [PATCH v2,3/9] media: mtk-jpegenc: remove redundant code of irq Message-ID: References: <1625038079-25815-1-git-send-email-kyrie.wu@mediatek.com> <1625038079-25815-4-git-send-email-kyrie.wu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210709_020717_960716_E168F3BB X-CRM114-Status: GOOD ( 12.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 06, 2021 at 07:00:33PM +0800, Tzung-Bi Shih wrote: > On Wed, Jun 30, 2021 at 3:28 PM kyrie.wu wrote: > > the func of jpgenc irq handler would not compatible, remove those > > code. > Need more explanation about why as I believe it is non-backward compatible. Right. And it breaks bisection, which is not acceptable. Kyrie, please structure your series in a way that none of the patches break any existing functionality. Best regards, Tomasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel