From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF7F9C4338F for ; Tue, 27 Jul 2021 13:26:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7971B61A40 for ; Tue, 27 Jul 2021 13:26:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7971B61A40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pCj2u/ijGdbxYpy2EEY7AeGQ/5Nr9gR5F4xYBmkluG4=; b=tNMiss0MDSQsXe z9g2R3VlLldWxB/MZMjY4+y/7wZsYnF8ACANhpyEqKO/viWCzTPjZPkUuQj1b4w44cphVG0AsJDI+ 71TqXffTD9PGjYF9zfWGgKpFVDlm1N5iZxgsZaWdPZUs7C0sSWTuXHDXSOY5D0MAFAGoqivXQiG25 hEbOVN64qDx3Whn1US5MGA90CuDtcjyWKVOAum1wF9gj4OUcsJIh9cCOdL7p1MCJWDVd9AFTSDQqt ZL9nK3Od34wVwdfm8QC9WgDnM4ujgUSXco7KDAPTB3LsL0AnZn/oJW8jiH4Av+7LHovGfRHb/3UVE fCCKa7i2okOnQUBRWRFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8N5A-00EtaN-RW; Tue, 27 Jul 2021 13:25:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8N4x-00EtXb-Nu for linux-arm-kernel@lists.infradead.org; Tue, 27 Jul 2021 13:25:05 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id D12D761A07; Tue, 27 Jul 2021 13:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627392303; bh=F5FO0KwrjkIdpxIRGWjqMSMQQWb+eHq3L3DMaWH6RQA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u9q5p5jH2mYJrV8HkMu2/aUtXlP3FXBATy73XY6OdDb3OxuwwLVfTkwz882JyDAQS 64+TfrckXAJ8gK6cvMKQT2aygMD5TCe94r0F7G7oPxQOnpEYdiWjYYId5I23tf+vpr E7f8hbHdl8LCfkXDtsJDtU0hSRFqjBcsok1GkgHU= Date: Tue, 27 Jul 2021 15:25:01 +0200 From: Greg KH To: Ojaswin Mujoo Cc: nsaenz@kernel.org, stefan.wahren@i2se.com, dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/5] staging: vchiq: Make creation of vchiq cdev optional Message-ID: References: <846c424dd4aae14d1cc28c8f30877a06e2b7dd10.1626882325.git.ojaswin98@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <846c424dd4aae14d1cc28c8f30877a06e2b7dd10.1626882325.git.ojaswin98@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210727_062503_837429_5C82FAC5 X-CRM114-Status: GOOD ( 16.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 21, 2021 at 09:50:52PM +0530, Ojaswin Mujoo wrote: > Before this commit, vchiq cdev (/dev/vchiq) was always created during > platform initialization. Introduce a new Kconfig option > CONFIG_VCHIQ_CDEV which determines if the cdev will be created or not. > > Signed-off-by: Ojaswin Mujoo > --- > drivers/staging/vc04_services/Kconfig | 10 ++++++++++ > drivers/staging/vc04_services/Makefile | 5 ++++- > .../vc04_services/interface/vchiq_arm/vchiq_arm.h | 9 +++++++++ > 3 files changed, 23 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig > index 4b886293f198..63caa6818d37 100644 > --- a/drivers/staging/vc04_services/Kconfig > +++ b/drivers/staging/vc04_services/Kconfig > @@ -19,6 +19,16 @@ config BCM2835_VCHIQ > Defaults to Y when the Broadcom Videocore services > are included in the build, N otherwise. > > +if BCM2835_VCHIQ > + > +config VCHIQ_CDEV > + bool "VCHIQ Character Driver" > + help > + Enable the creation of VCHIQ character driver to help > + communicate with the Videocore platform. I'll take this, but this really should say more about what this really is for. Who needs this? Why will I know if I want a character driver interface? What tools talk to this? Or conversely, why would I want to turn this off? Can you send a follow-on patch that makes this more descriptive? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel