From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B466C4320A for ; Wed, 28 Jul 2021 13:34:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E3D860D07 for ; Wed, 28 Jul 2021 13:34:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1E3D860D07 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j2ViliEsYuB4H3KWXf8O2noFrXq4PfqpoN8wvUakQ/M=; b=i9xlUKA/GryKNP S65bfw/jB/PzBvP+97aGmL4cQd/ZjECLqmWm1EYlgHwfTS5tLzir6/j9sM2L9RLyVC5hVkFhuyPUS nDTmwzifbUXkP/i77OAslqrPn0HZXRgggcKesedq/vEvvDG7dqJ3L0rk7yd4CbuxYiw3umJ8zjFhb nlRpZbNDsbY8GySq3GS+HqdUfx9MmbfaTudbmV+z1IZaNYCHNvBGlqiPErJh4IMLWqUeXzp5R1Wvr YW885fleJMHsNmy46i9M6GqTh9bR2uA8L4ycENqfnybjfBVadeUuU/dvtdnZXPxvqSOCKqMm0sRof s70/a/n6xS1cPrxQ0c3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8jgA-000ntG-Lu; Wed, 28 Jul 2021 13:32:58 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8jg5-000nqv-W3 for linux-arm-kernel@lists.infradead.org; Wed, 28 Jul 2021 13:32:55 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 77FBCEE; Wed, 28 Jul 2021 15:32:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1627479171; bh=c1dkUuPXfClOIv5jpAqPkqsyfaPoUtpNHnoR7YUBKtE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JgCARYIVVkDVfEHmvs9gFM9xYM7j/CTlLRSZtKoKNqHJIs0AF6WwqQgMxUr03ru+P ypa7AigHetwOwZZOaGKbE2sakovaTsIV6Ny//st1PPyyR+gwYKG/iCPI81o/tnAtk5 iwnjIUWpksVMQze9N4GnXsCRy6iR713Kq6mBzR0U= Date: Wed, 28 Jul 2021 16:32:45 +0300 From: Laurent Pinchart To: Martin Kepplinger Cc: dafna.hirschfeld@collabora.com, shawnguo@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, kernel@pengutronix.de, kernel@puri.sm, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, m.felsch@pengutronix.de, mchehab@kernel.org, phone-devel@vger.kernel.org, robh@kernel.org, slongerbeam@gmail.com, Sascha Hauer Subject: Re: [PATCH v10 0/3] media: imx: add support for imx8mq MIPI RX Message-ID: References: <20210728091245.231043-1-martin.kepplinger@puri.sm> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210728091245.231043-1-martin.kepplinger@puri.sm> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_063254_222529_290834A9 X-CRM114-Status: GOOD ( 24.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Martin, On Wed, Jul 28, 2021 at 11:12:42AM +0200, Martin Kepplinger wrote: > hi, > > This patch series adds a driver for the i.MX8MQ CSI MIPI receiver / controller. > > It includes the driver, the dt-bindings and the DT addition to the SoC dtsi. > I test it using libcamera. Thanks to Laurent who helped a lot. I'm happy for > any feedback, Thank you for the series. I've submitted a pull request that contains patches 1/3 and 2/3. Shawn, Sascha, how would you like to handle 3/3 ? > revision history > ---------------- > v10: (thank you Dafna) > * improve send_level documentation. > * add some comments to 0x180 and 0x184 > * after re-reading I could eliminate the unneeded setting of 0x184 (ignored > by setting 0x180 to 1). > > v9: (thank you Laurent) > * improve getting the esc clock rate for hs_settle > https://lore.kernel.org/linux-media/20210726082117.2423597-1-martin.kepplinger@puri.sm/ > > v8: (thank you Laurent) > * calculate hs_settle for any clk rate and mode > * add reviewed-by tag > https://lore.kernel.org/linux-media/20210723101217.1954805-1-martin.kepplinger@puri.sm/T/ > > v7: (thank you Laurent and Rob) > * fix the binding example (include the reset driver) > * use pm_runtime_resume_and_get() > * fix some logic in init_cfg() > * add some useful code comments and fix minor bits found by Laurent in v6 > https://lore.kernel.org/linux-media/20210716102244.581182-1-martin.kepplinger@puri.sm/T/#t > > v6: (thank you Laurent and Rob) > * add reviewed-by tag to binding > * statically allocate clk_bulk_data > * fix how the hs_settle value is applied > * remove s_power calls > * remove the link_setup() callback implementation and make the link immutable > * more cleanups according to Laurents' review from v5 > https://lore.kernel.org/linux-media/20210714111931.324485-1-martin.kepplinger@puri.sm/ > > v5: (thank you Laurent) > * fix reset usage by using the already supported reset controller driver > * remove clko2 (totally unrelated clock / had been included by accident) > * rename pxl clock to ui > https://lore.kernel.org/linux-media/20210618095753.114557-1-martin.kepplinger@puri.sm/ > > v4: (thank you Rob and Marco) > * create fsl,mipi-phy-gpr custom dt property instead of confusing "phy" > * add imx8mq-specific compatibile to imx8mq.dtsi for future use > https://lore.kernel.org/linux-media/20210614121522.2944593-1-martin.kepplinger@puri.sm/ > > v3: (thank you, Rob and Laurent) > among minor other things according to v2 review, changes include: > * better describe the clocks > * rename DT property "phy-reset" to "reset" and "phy-gpr" to "phy" > https://lore.kernel.org/linux-media/20210608104128.1616028-1-martin.kepplinger@puri.sm/T/#t > > v2: (thank you, Dan and Guido) > among fixes according to v1 reviews, changes include: > * remove status property from dt-bindings example > * define a few bits in order to have less magic values > * use "imx8mq_mipi_csi_" as local function prefix > * read DT properties only during probe() > * remove dead code (log_status) > * add imx8mq_mipi_csi_release_icc() > * fix imx8mq_mipi_csi_init_icc() > https://lore.kernel.org/linux-media/20210531112326.90094-1-martin.kepplinger@puri.sm/ > > v1: > https://lore.kernel.org/linux-media/20210527075407.3180744-1-martin.kepplinger@puri.sm/T/#t > > > Martin Kepplinger (3): > dt-bindings: media: document the nxp,imx8mq-mipi-csi2 receiver phy and > controller > media: imx: add a driver for i.MX8MQ mipi csi rx phy and controller > arm64: dts: imx8mq: add mipi csi phy and csi bridge descriptions > > .../bindings/media/nxp,imx8mq-mipi-csi2.yaml | 174 +++ > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 104 ++ > drivers/staging/media/imx/Makefile | 1 + > drivers/staging/media/imx/imx8mq-mipi-csi2.c | 991 ++++++++++++++++++ > 4 files changed, 1270 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml > create mode 100644 drivers/staging/media/imx/imx8mq-mipi-csi2.c -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel