From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 451CDC4338F for ; Wed, 28 Jul 2021 20:14:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E36360527 for ; Wed, 28 Jul 2021 20:14:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0E36360527 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rQ4FLU+JbJ6BB4nHDhGkv4yTJ1jUx5e+ZrqMxq6Ne8Q=; b=zN9U65vw7bcAel yD11twW7JJFjicmi1UcLca/PnyJmByRGJHBk6mVbiQfPc/ct2N5nlM7tnzIapqdfuVrqq1ZID86gj VbxtVtDkDGR2IJFq3kwyT59ANjXOWdTXgwmAAe9EZp+FjQkgPUWKuGp13DvGm8aIC7zaZwEl9HlBn VJjqdZ3WBYw3p6VwA5AylTFYXpj/KXqxVJ+aq8OEToKGMzjteAJbd9XlrEVW8e0K1OMvv4ZDxWMsU xms6JFZai8d15ESACHcU1jfxNZwnlnUFwmxL1yOhuLPVqqbtiiDwEgF2YVFlyTOKhFIH1MLUp2N3I UsZZbANnFOOWbAVLRv3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8puB-002HzA-1J; Wed, 28 Jul 2021 20:11:51 +0000 Received: from mx2.smtp.larsendata.com ([91.221.196.228]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8pu7-002HyT-5N for linux-arm-kernel@lists.infradead.org; Wed, 28 Jul 2021 20:11:48 +0000 Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 11b79c7f-efe0-11eb-8d1a-0050568cd888; Wed, 28 Jul 2021 20:12:01 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 82FBC194B23; Wed, 28 Jul 2021 22:12:02 +0200 (CEST) Date: Wed, 28 Jul 2021 22:11:39 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Dan.Sneddon@microchip.com Subject: Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces Message-ID: References: <20210727182721.17981-4-tzimmermann@suse.de> <3d2f6b84-dd07-d925-a8b8-2bfd5fc736d9@microchip.com> <2f04b986-6b41-62f9-1587-23818b841655@suse.de> <793514f6-0270-771b-fe36-f82edf4e5fd2@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_131147_387542_5D16AF79 X-CRM114-Status: GOOD ( 17.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, liviu.dudau@arm.com, stefan@agner.ch, amd-gfx@lists.freedesktop.org, anitha.chrisanthus@intel.com, patrik.r.jakobsson@gmail.com, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, kernel@pengutronix.de, edmund.j.dea@intel.com, s.hauer@pengutronix.de, alison.wang@nxp.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, dri-devel@lists.freedesktop.org, daniel@ffwll.ch, sean@poorly.run, linux-arm-kernel@lists.infradead.org, tomba@kernel.org, bbrezillon@kernel.org, jyri.sarha@iki.fi, christian.koenig@amd.com, robdclark@gmail.com, tzimmermann@suse.de, alexander.deucher@amd.com, shawnguo@kernel.org, brian.starkey@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dan, > > > > I think I got it - we need to set irq_enabled to true. > > The documentation says so: > > " > > * @irq_enabled: > > * > > * Indicates that interrupt handling is enabled, specifically vblank > > * handling. Drivers which don't use drm_irq_install() need to set this > > * to true manually. > > " > > > > Can you try to add the following line: > > > > > > +static int atmel_hlcdc_dc_irq_install(struct drm_device *dev, unsigned int irq) > > +{ > > + int ret; > > + > > + if (irq == IRQ_NOTCONNECTED) > > + return -ENOTCONN; > > + > > > > dev->irq_enabled = true; <= THIS LINE > > > > > > + atmel_hlcdc_dc_irq_disable(dev); > > + > > + ret = request_irq(irq, atmel_hlcdc_dc_irq_handler, 0, dev->driver->name, dev); > > + if (ret) > > + return ret; > > > > I hope this fixes it. > > It does! With the irq_enabled line added everything is looking good. Great, thanks for testing. Thomas - I assume you will do a re-spin and there is likely some fixes for the applied IRQ conversions too. Note - irq_enabled must be cleared if request_irq fails. I did not include this in the testing here. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel