From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94BCEC4338F for ; Thu, 29 Jul 2021 20:42:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5ACBB60F46 for ; Thu, 29 Jul 2021 20:42:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5ACBB60F46 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FR9zhjiXqjT5U7xRHUptfzGMqntS+iiLkYBXSCadvxc=; b=3BQZk+E1zk0bhy y5n/i7jBPvE3tZ3cFQoBpNaLWfTjABdxogvwqkxtgvX8jNly+jpXN397O3QZQarkNqWZOT8PAfA9V BQfSctwk3jcdvogHX3WtF1qZZnRW3p/wjiQvv5Ko/FoXgKik15pzbleTHjdyySNujjxD5WW51xHKC OXgpCtMOsw0gDf9z+c0pXduebVK/FmaSwLCzQmEOj9QGAK10mLNyuSwCBv3kiJ/w/13sfbI+q/COe qOr8iHAnLoY1xxEY8OeOyEnoeFwOihn595Z+PuGEyZu8U4OMvoABOJFfhn8FC8/u9Yh/TVKWfTcxl P54+Q+O/YF5D43zv/gWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9CoT-005xfO-7o; Thu, 29 Jul 2021 20:39:30 +0000 Received: from mail-io1-f54.google.com ([209.85.166.54]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9Cgs-005v9b-NP for linux-arm-kernel@lists.infradead.org; Thu, 29 Jul 2021 20:31:40 +0000 Received: by mail-io1-f54.google.com with SMTP id 185so8752672iou.10 for ; Thu, 29 Jul 2021 13:31:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KUWvqLY5dtYTcBMoP6MzaeBbDWJ4C0b6SsAxNWS8lfo=; b=i+n6pLh4ZJs/ELwAAKqusCvS7a1hLnP1gkv0iQ9UOFisPUoDM6497676I4anm4Q+Rq oGztbDPhjS2DiQlgXeAO14P1JSWQ5KH1z8lnfBppUjuJ5fawOEPq9WbutHuIIQaMxnL6 qi4bGqzF3V9kO8ikDWKeLxhdYoOYYs2pngrFzFEdjfy8qBcFN12fMDCyi6MOwJtFB5D9 Lvk0SqucwrUWmF9HzIeyn/gyYdHKTWJBIiaGRH3txfwWgpDLv3A3b4tIjGzKt2jzV3C3 ohcv2+HkhzZuf3rv3ae8CQVwtL60OVmab0H/mhr4zQawUFPk3LsK93uMMYaEa+iQBID2 t9ng== X-Gm-Message-State: AOAM530sPGqhx+VREYHqO/4lwLLGuHnXXO+QcyCcy7XihaZ2d0z1BqmG KrzGFAH3s9lvKIlvyQHnLQ== X-Google-Smtp-Source: ABdhPJwioEdi04/jbfnfuOGVu5hP7n0ehPaMIaPvCp13mUJRpi/eNyFwP4zVRi+5d9gf9aBvRLrKSQ== X-Received: by 2002:a5d:8986:: with SMTP id m6mr5466807iol.87.1627590697396; Thu, 29 Jul 2021 13:31:37 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id a3sm2101033ilj.39.2021.07.29.13.31.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 13:31:36 -0700 (PDT) Received: (nullmailer pid 835093 invoked by uid 1000); Thu, 29 Jul 2021 20:31:35 -0000 Date: Thu, 29 Jul 2021 14:31:35 -0600 From: Rob Herring To: Billy Tsai Cc: Jonathan Cameron , "jic23@kernel.org" , "lars@metafoo.de" , "pmeerw@pmeerw.net" , "joel@jms.id.au" , "andrew@aj.id.au" , "p.zabel@pengutronix.de" , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , BMC-SW Subject: Re: [v2 1/8] dt-bindings: iio: adc: rename the aspeed adc yaml Message-ID: References: <20210723081621.29477-1-billy_tsai@aspeedtech.com> <20210723081621.29477-2-billy_tsai@aspeedtech.com> <20210723154456.00006744@Huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_133138_841868_3E0B7F5C X-CRM114-Status: GOOD ( 18.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 26, 2021 at 06:53:07AM +0000, Billy Tsai wrote: > Hi Jonathan, > > On 2021/7/23, 10:45 PM, "Jonathan Cameron" wrote: > > On Fri, 23 Jul 2021 16:16:14 +0800 > Billy Tsai wrote: > > > > The aspeed,ast2400-adc.yaml not only descriptor the bindings of ast2400. > > > Rename it to aspeed,adc.yaml for all of the aspeed adc bindings. > > > > > > Signed-off-by: Billy Tsai > > > We try to avoid 'wild' card type namings most of the time and instead > > name after a particular part number. I say try because clearly > > we let a few in over the years :( > > > It is very hard to know if this binding will apply to 'all' future > > aspeed ADCs. > > > As such I'm not sure this particular rename makes sense. > > If I want to extend the yaml file to compatible more versions of the aspeed adc. > Would you suggest to add new files call aspeed,ast2600-adc.yaml or just append it > to the aspeed,ast2400-adc.yaml? If 2600 is not backwards compatible with 2400, then probably a new schema file. Given you are adding new properties (which only apply to 2600?), then most likely a new schema file. Depends at which point there are too many conditional (if/then/else) schemas. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel