From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53988C4338F for ; Tue, 10 Aug 2021 12:40:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11CC8604DC for ; Tue, 10 Aug 2021 12:40:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 11CC8604DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1Jzn8nHQZPYpbS/bQKu/BQ86va/WOBlwE/cU6ood7BY=; b=CpAVqiatyiRrLY pc/ZPesuDJnDXdNE4F2Kh1VFGFLWjabVDwm844JzBXNqvLLS6gTZVmrQeFNX/MkEZQkJvpdkY4qN5 dw/P4rErxXVgAXS/xvhef21UuKya2nxaKidnLCIkwotT35woD//VvHziC7tPz/21IYxknDmcwMQa5 4Q7iPkgPNrO8KUlYhZOYu8sdXjT+p98KUHmm180aCnl0iUBI4r83GxJPMogzJiufxUXVROqim2dIP CM2Id0oBDgABgsZlA5Vv4pdXZ3SObprflanSEi/6BtFCRnW3+Mi9cuG71pt3/QpaS1eu/V7sQEEM7 irZRB7JJyr+gsHw+ocWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDQzz-003jbd-VY; Tue, 10 Aug 2021 12:36:52 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDQzw-003jan-Di for linux-arm-kernel@lists.infradead.org; Tue, 10 Aug 2021 12:36:49 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1F7E7604DC; Tue, 10 Aug 2021 12:36:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628599008; bh=65wwyZ1PzsTjVVRVB8uytBblEiEgZgMvnsoHRtYi+4s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h+LM/Sc5HKau/FXlituogSJez40C0Za87secHQ8Y8xGr/etTL57hF7STihj5eAEW0 vWUwYtq5tUkpP/H1I5WeMU55oAeiPWkFGDVXM31alULgQbOZpKXBhkxd3T6Q2/wZbg 2F71pgzZ9VKXCO1isfwKcxdmLzQFrEpaWmGQtL3C/ZIj6CU2Yg54lzKMiw8MzaxAql EGWA5SKO4EOac5sQZteftPIKBVaOeP03Abs8CqasWtkaTrSOVOSFq5SYa8BZJndS0P NJcx8D4d2NfiIxOH7VU1V/kwIITuIXNnOoy2DpGy7c+JJqUJqmHzlmzv1o+bFX3Eke BUV0HfJy2xujA== Date: Tue, 10 Aug 2021 15:36:44 +0300 From: Leon Romanovsky To: Vladimir Oltean Cc: netdev@vger.kernel.org, Jakub Kicinski , "David S. Miller" , Andrew Lunn , Florian Fainelli , Vivien Didelot , Vladimir Oltean , Vadym Kochan , Taras Chornyi , Saeed Mahameed , Jiri Pirko , Ido Schimmel , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Grygorii Strashko , Julian Wiedmann , Karsten Graul , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Jianbo Liu , Vlad Buslov , Bjarni Jonasson , Vignesh Raghavendra , Tobias Waldekranz , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-s390@vger.kernel.org, Russell King , Ido Schimmel Subject: Re: [PATCH v2 net] net: switchdev: zero-initialize struct switchdev_notifier_fdb_info emitted by drivers towards the bridge Message-ID: References: <20210810115024.1629983-1-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210810115024.1629983-1-vladimir.oltean@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210810_053648_538489_E797156A X-CRM114-Status: GOOD ( 14.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 10, 2021 at 02:50:24PM +0300, Vladimir Oltean wrote: > The blamed commit a new field to struct switchdev_notifier_fdb_info, but > did not make sure that all call paths set it to something valid. For > example, a switchdev driver may emit a SWITCHDEV_FDB_ADD_TO_BRIDGE > notifier, and since the 'is_local' flag is not set, it contains junk > from the stack, so the bridge might interpret those notifications as > being for local FDB entries when that was not intended. > > To avoid that now and in the future, zero-initialize all > switchdev_notifier_fdb_info structures created by drivers such that all > newly added fields to not need to touch drivers again. > > Fixes: 2c4eca3ef716 ("net: bridge: switchdev: include local flag in FDB notifications") > Reported-by: Ido Schimmel > Signed-off-by: Vladimir Oltean > Reviewed-by: Ido Schimmel > Tested-by: Ido Schimmel > --- > v1->v2: use an empty struct initializer as opposed to memset, as > suggested by Leon Romanovsky > > drivers/net/ethernet/marvell/prestera/prestera_switchdev.c | 4 ++-- > drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c | 2 +- > drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 4 ++-- > drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 2 +- > drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c | 2 +- > drivers/net/ethernet/rocker/rocker_main.c | 2 +- > drivers/net/ethernet/rocker/rocker_ofdpa.c | 2 +- > drivers/net/ethernet/ti/am65-cpsw-switchdev.c | 2 +- > drivers/net/ethernet/ti/cpsw_switchdev.c | 2 +- > drivers/s390/net/qeth_l2_main.c | 4 ++-- > net/dsa/slave.c | 2 +- > 11 files changed, 14 insertions(+), 14 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel