From: Rob Herring <robh@kernel.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: linux-kernel@vger.kernel.org, frowand.list@gmail.com,
linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org,
saravanak@google.com, linus.walleij@linaro.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/4] amba: Kill sysfs attribute file of irq
Date: Tue, 31 Aug 2021 15:44:15 -0500 [thread overview]
Message-ID: <YS6Un+Zdbaj5qe63@robh.at.kernel.org> (raw)
In-Reply-To: <20210827150600.78811-4-wangkefeng.wang@huawei.com>
On Fri, Aug 27, 2021 at 11:05:59PM +0800, Kefeng Wang wrote:
> As Rob said[1], there doesn't seem to be any users about the sysfs
> attribute file of irq[0] and irq[1]. And we don't need to include
> <asm/irq.h> as NO_IRQ has gone. Let's kill both of them.
>
> [1] https://lkml.org/lkml/2021/8/25/461
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> drivers/amba/bus.c | 18 ++----------------
> 1 file changed, 2 insertions(+), 16 deletions(-)
Acked-by: Rob Herring <robh@kernel.org>
> diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
> index 37fcd5592c6f..4d3a565ca079 100644
> --- a/drivers/amba/bus.c
> +++ b/drivers/amba/bus.c
> @@ -20,8 +20,6 @@
> #include <linux/platform_device.h>
> #include <linux/reset.h>
>
> -#include <asm/irq.h>
> -
> #define to_amba_driver(d) container_of(d, struct amba_driver, drv)
>
> /* called on periphid match and class 0x9 coresight device. */
> @@ -135,8 +133,6 @@ static ssize_t name##_show(struct device *_dev, \
> static DEVICE_ATTR_RO(name)
>
> amba_attr_func(id, "%08x\n", dev->periphid);
> -amba_attr_func(irq0, "%u\n", dev->irq[0]);
> -amba_attr_func(irq1, "%u\n", dev->irq[1]);
> amba_attr_func(resource, "\t%016llx\t%016llx\t%016lx\n",
Might want to get rid of this too. It's available thru other means (DT).
That can be another patch.
> (unsigned long long)dev->res.start, (unsigned long long)dev->res.end,
> dev->res.flags);
> @@ -463,20 +459,10 @@ static int amba_device_try_add(struct amba_device *dev, struct resource *parent)
>
> skip_probe:
> ret = device_add(&dev->dev);
> - if (ret)
> - goto err_release;
> -
> - if (dev->irq[0])
> - ret = device_create_file(&dev->dev, &dev_attr_irq0);
> - if (ret == 0 && dev->irq[1])
> - ret = device_create_file(&dev->dev, &dev_attr_irq1);
> - if (ret == 0)
> - return ret;
> -
> - device_unregister(&dev->dev);
>
> err_release:
> - release_resource(&dev->res);
> + if (ret)
> + release_resource(&dev->res);
> err_out:
> return ret;
>
> --
> 2.18.0.huawei.25
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-31 20:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 15:05 [PATCH v2 0/4] amba: Properly handle device probe without IRQ domain Kefeng Wang
2021-08-27 15:05 ` [PATCH v2 1/4] amba: Drop unused functions about APB/AHB devices add Kefeng Wang
2021-08-27 15:05 ` [PATCH v2 2/4] Revert "ARM: amba: make use of -1 IRQs warn" Kefeng Wang
2021-08-27 15:05 ` [PATCH v2 3/4] amba: Kill sysfs attribute file of irq Kefeng Wang
2021-08-31 20:44 ` Rob Herring [this message]
2021-08-27 15:06 ` [PATCH v2 4/4] amba: Properly handle device probe without IRQ domain Kefeng Wang
2021-08-31 20:48 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YS6Un+Zdbaj5qe63@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=saravanak@google.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).