From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECED6C433F5 for ; Wed, 22 Sep 2021 07:24:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC61C61168 for ; Wed, 22 Sep 2021 07:24:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AC61C61168 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/LsCNI90ZnRH7e3VTEoV+6TELJtmX5qXDUD6SGS3u3s=; b=aUE565Y3Ky8FqY 6UEGcmkm/Z42DnSqT4Oypa5xhTAnRfhipF7mwjG7WdlxCoXiibQ3QwWc8wbjpz4GkKY/Jqq6x9j+9 c3tSdPjHHtQFelzLW1lxwv9eKhJ6e1NWWHz2gTZSfNCG76Q2MfGwatfuEnUwNADzth4lBEkkTKl9W 8uDpH8F1KhA5nNcmrRJCVvLQUIy2sEyXm2FaYLGprfTZCV5cwftRBqvxd5F+7Ti1kPmX3snTzsce3 DdwEVp7xi/OFztYT+kgeZExerQ8Maa7Im+z+keyoXHL2yVHjDLiZ1mVEATNtQEbf8ifCBRaBVJHOn l0Ugb3BIBk/+OW15wI8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSwaZ-007J87-QT; Wed, 22 Sep 2021 07:22:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSwaU-007J6l-Ra for linux-arm-kernel@lists.infradead.org; Wed, 22 Sep 2021 07:22:41 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E45AB610A0; Wed, 22 Sep 2021 07:22:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632295358; bh=WNKcqaMlMsH9avHQqL/8bXo1+ieMx7dN8g+lDPzOPuQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bnfR0sFXxVmWgESwlgn7ej6589e2jVsdDqcK4MCGIvf4tVB0oabLNs+pB3y4vGg8z NQqSASyDEXdPWaQ6masJpciVRvgZhJ43JfAp6MxidubFH6ZJRuahZRJlLZbyV8MtHv 38YcFV5AvfvO4KA+fkWhOmM65BJZAe7Q6gacfi9akt5GHYDtztJukRSqu4nv2FPMP3 KKW5Uv1aK/R5JsL5P3GZ5Ipse8zpnFZLirq6kJFmb5RsiGV1BovZVCOTntvCCfYOeZ a/lQ3cTpkPGaQ0vGhHtnYe+SkzMNaTxo0yS47yYYYqXs3rIrF0FVBtXmdwp/lEGjoo MHDJr4OXgJqiw== Date: Wed, 22 Sep 2021 10:22:32 +0300 From: Mike Rapoport To: Christoph Hellwig Cc: Catalin Marinas , David Hildenbrand , Robin Murphy , Alex Bee , Will Deacon , Andrew Morton , Anshuman Khandual , Linux Kernel Mailing List , linux-mm@kvack.org, Linux ARM Subject: Re: [BUG 5.14] arm64/mm: dma memory mapping fails (in some cases) Message-ID: References: <60a11eba-2910-3b5f-ef96-97d4556c1596@redhat.com> <20210825102044.GA3420@arm.com> <20210918051843.GA16104@lst.de> <20210921082007.GA29121@lst.de> <20210921153805.GA29952@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210921153805.GA29952@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210922_002238_967333_ED91B14E X-CRM114-Status: GOOD ( 18.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 21, 2021 at 05:38:05PM +0200, Christoph Hellwig wrote: > On Tue, Sep 21, 2021 at 12:34:10PM +0300, Mike Rapoport wrote: > > > It doesn't create any new mappings. The only real issue is that it > > > does the wrong thing for RAM in a way that might not be noticed on > > > simple (x86/PC) platforms. > > > > But if the mapping request was rejected by devm_ioremap_resource() because > > of an attempt to map RAM, why we would get to dma_map_resource() at all? > > dma_map_resource takes a phys_addr_t that could come from anywhere. Right, but it's not different from, say, dma_map_page_attrs() that can get a struct page from anywhere and there is no actual memory for that struct page at all. Do you suggest add a check that that struct page is backed by memory in dma_map_page_attrs() as well? -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel