From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CDDBC433EF for ; Wed, 20 Oct 2021 16:11:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 657F861183 for ; Wed, 20 Oct 2021 16:11:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 657F861183 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MzK+m985U8uTq87cmdlJWxn0a7L7TmM9VAOcrUXxGHg=; b=NEx8lXeH0cdaxinJHSh5/YLRpx TQHrKTPei4jr9Lqqz2+HtJIgWC4FQfsvLcSAjiZvGo5vE5h+iQlw4g/aHmcszQ1lrAGjQi9xWBlzP 7O7A7nY+VGpmG51BgY6HjABW2+kzsmX3VmI4zVKzUMk0FYLDhG2CxKfLeEl6P6BmIr/K27IbcY38E CSLGIAE5Wu1Xj2jNY+ZueSgCUiI92UMj+NMwuRx3Gtiq85/P7FH/vhZ2jx5+lh+TaSWIYuvLt8AZ6 BGY8EU9L2igZySPReIhJUQaVHIf9hhMcVjASxzs+zQ7xoT7vXcn+8i2yBb5yw/dd4xSTDGD2x9+pg Eb3RNliw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdEAq-005CFk-Qi; Wed, 20 Oct 2021 16:10:40 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdEAm-005CEP-AZ for linux-arm-kernel@lists.infradead.org; Wed, 20 Oct 2021 16:10:37 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 47FE6611C7; Wed, 20 Oct 2021 16:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634746235; bh=z6PY8llaZwmywwJZWrwXZV/7u2OHh47ZPV0U+0N3ZI4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oRxgXrDJjG9VAK5tvuy9sb66+ZN59gaYZoHn1SsDhC5Q/t7hfPnBBgkytqOmqgWpI HAiowPp02mPPnM/3gCj5gZCVuimSMVyy90JWDW2aS2Y/5rgvncfZWtgbDUYLP6NztA qqEkaHOO9RZNfn1xqd74fapxWsYMW2mckXeZny0XC2Sfhz9wEYLWpLET01dthWf5Pi z2IT8MOyVB7tx8h1DQg5AFp7B1THZSgbx3xmFP6i/+z+CX9b7vOtQ+R958Y1DLoUX1 H5FlPFlw8/8DZ+Bs6F2WCAHMLtUwCaGMtivs98IomtxgFDU6oVvRtpjd8l0Vjk09on xr5gxNweqYOVg== Date: Wed, 20 Oct 2021 17:10:33 +0100 From: Mark Brown To: madvenka@linux.microsoft.com Cc: mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 03/11] arm64: Make get_wchan() use arch_stack_walk() Message-ID: References: <20211015025847.17694-1-madvenka@linux.microsoft.com> <20211015025847.17694-4-madvenka@linux.microsoft.com> MIME-Version: 1.0 In-Reply-To: <20211015025847.17694-4-madvenka@linux.microsoft.com> X-Cookie: I program, therefore I am. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211020_091036_425468_51BC872B X-CRM114-Status: GOOD ( 10.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4663232151835818971==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4663232151835818971== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="O/pViJGvRkkdBw9F" Content-Disposition: inline --O/pViJGvRkkdBw9F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 14, 2021 at 09:58:39PM -0500, madvenka@linux.microsoft.com wrot= e: > From: "Madhavan T. Venkataraman" >=20 > Currently, get_wchan() in ARM64 code walks the stack using start_backtrac= e() > and unwind_frame(). Make it use arch_stack_walk() instead. This makes > maintenance easier. This overlaps with some very similar updates that Peter Zijlstra is working on which addresses some existing problems with wchan: https://lore.kernel.org/all/20211008111527.438276127@infradead.org/ It probably makes sense for you to coordinate with Peter here, some of that series is already merged up to his patch 6 which looks very similar to what you've got here. In that thread you'll see that Mark Rutland spotted an issue with the handling of __switch_to() on arm64 which probably also applies to your change. --O/pViJGvRkkdBw9F Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFwP3gACgkQJNaLcl1U h9AD2Af/cYDwqWJMHFvpAMcH68EcA1Z9pEkv8BxhV1zFhZ5CwFxiJSaY24/lDnCn HaWOYTMkNnwSJYbn4Jb6SP1m9M9HYnxPDE5DxQLV/JZAqf9zQ3VCcF4xBgvKUyOy m+aWvHSPp6M8EMGXWFiah7nlDb7bX80RIVddLGNs9cQHVrLaS/mOxmcjsJ1JWmMR ZQ93tT5kJ+s3ILnQq3azYZ1rbRQCtGQN4zTC4qEJT8iD3sY9ov+28JAgVqrrCOfE 32z6mtBLvH5exVlJe3LS5Irf6ki20DffofCLmoS8lbCexFqPv4LfGsRRYNr/3ooh eaY50Wv0UxQ3stzu9PsMtUW42eUmtg== =tBaY -----END PGP SIGNATURE----- --O/pViJGvRkkdBw9F-- --===============4663232151835818971== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4663232151835818971==--