From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAE0AC433EF for ; Wed, 20 Oct 2021 15:19:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81AC46134F for ; Wed, 20 Oct 2021 15:19:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 81AC46134F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1ufzEAOckIs5cdZHEHM1S0N/vrSwow3V8GEciI47PIU=; b=S9njDV3LSxm5dFIoIvCoYznonG sRBX5mIOhb7sGe+D6siXuQcvBNKOlmV96b5TK/xfTzQzZ8w1OPy9M5kx6bDXJ1H1wzev5mKEuBFVl IGhbLMQPHCZ5osUDaMeTDzDXN4If6p/z6ud9gFaBnig8+88Nu60QjPhgm4V1Pqo8yyNWUDmyFa64D jlT8IK6h9lN/gvjCJhFvREMEqueOh7Pmho3RYgXeM4WUPb6nvWZaVAsE1iQ7OSeQLDOFyOi1KJ6+8 DwEqu0USqUXnkPrinFII5pyxB04M+yHUbhQ+xnpfq/IWTOcX0YMKIard2Sayn2Zw0kqrZPH0yMDT9 Ru6/9P8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdDLx-004xdq-90; Wed, 20 Oct 2021 15:18:06 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdD48-004sKd-TW for linux-arm-kernel@lists.infradead.org; Wed, 20 Oct 2021 14:59:42 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8646D6135F; Wed, 20 Oct 2021 14:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634741980; bh=YrONzKcAhydCls+3APmmyxq1BG0aGp6PcLZnHTAcfDo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EaG1j+7H/TUgyCZp3YkGj0cNrLC0dp5dAkO65rShX82aEdWUv2Ue/LGwv6zHvT3Kr 0CLjqEs19CQw4w6f+1pOLmRMLPnSql8KOzKBYECaNp1tHlBgAKAME1ybd/OrHb7W5m p18pBHtIgwcWLZEB1Mc22M5T6TJRGI8CKr4SiA+Jgdj95leICAe2lNwUdBNT0aBjP/ gSPWnjy5s0kf891tS1oevjuwodS0pF1FU6YsHscqDABCgmyeX9t4oxKCcVpPj9moxx PXwzJK/+x/a9KOrCnbIH/lrp89Nh6ZGSkBR/Y+0ktNbCPfKRwBy0TT51Ohbzo8R4sT amrtQaAZnH65A== Date: Wed, 20 Oct 2021 15:59:37 +0100 From: Mark Brown To: madvenka@linux.microsoft.com Cc: mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 02/11] arm64: Make perf_callchain_kernel() use arch_stack_walk() Message-ID: References: <20211015025847.17694-1-madvenka@linux.microsoft.com> <20211015025847.17694-3-madvenka@linux.microsoft.com> MIME-Version: 1.0 In-Reply-To: <20211015025847.17694-3-madvenka@linux.microsoft.com> X-Cookie: I program, therefore I am. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211020_075941_023474_DDB9FF6F X-CRM114-Status: GOOD ( 12.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4393666618702628803==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4393666618702628803== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0OjbTQTv4ED8ZjVP" Content-Disposition: inline --0OjbTQTv4ED8ZjVP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 14, 2021 at 09:58:38PM -0500, madvenka@linux.microsoft.com wrot= e: > From: "Madhavan T. Venkataraman" >=20 > Currently, perf_callchain_kernel() in ARM64 code walks the stack using > start_backtrace() and walk_stackframe(). Make it use arch_stack_walk() > instead. This makes maintenance easier. > static bool callchain_trace(void *data, unsigned long pc) > { > struct perf_callchain_entry_ctx *entry =3D data; > - perf_callchain_store(entry, pc); > - return true; > + return perf_callchain_store(entry, pc) =3D=3D 0; > } This changes us from unconditionally doing the whole walk to returning an error if perf_callchain_store() returns an error so it's not quite a straight transform, though since that seems like a useful improvement which most likely on't have any practical impact that's fine. Reviewed-by: Mark Brown --0OjbTQTv4ED8ZjVP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFwLtgACgkQJNaLcl1U h9DGlQf9EnRXgRKnKwL2lcj9Tf5P/zGR2UVLC51sGcsAxbyAbr51NzQfPKLAEylw FI+VRW0ibqzD2wpmn9kb7boz99gz99qrlLmBzP6OTEqODAT8CVGY9YeciG9BKHtq 2Jrai3sp33jq3ox0bNtWeJ1YH1BJXlvDG+dUs7V8tytRqzOc06lVLnpmsI29g4So v5J8VVnx/UNF8jXguz16m2XPmH9C8rkgFVFAz5HxNa9gJBkCB3Gl0OeqE7cUBauz AhBkwX+T+t3IGwazfFl1LkbP1h+ikfCZ6gGLvcqsl13ZsmsfWxu3fJi6sOZobGwC VBSNqEWBYqpINLr+jp/J4mtG2929qQ== =wuCL -----END PGP SIGNATURE----- --0OjbTQTv4ED8ZjVP-- --===============4393666618702628803== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4393666618702628803==--