From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98C53C433F5 for ; Tue, 16 Nov 2021 18:08:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C9FC61357 for ; Tue, 16 Nov 2021 18:08:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5C9FC61357 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/4m2bwTZhQeHVcwZ8d2XTDPzuvHUIt+zleIvyhDGolY=; b=y5IqLMUyX2ggN1 jTHWUSIJtw77mqfKgukd88bTkhRHtrWmXYhT96+LFf0a79hmZMbylc8lvoO1z4oaSVPmZ9UGJSrce qskdte1qtgDDJ2qQEVfE7Y683bI3uYGXUGw20dQzht5QTV40UXAIXGf7nIK9m8y6B2y1aI55wLvRo X8mXP8qcPRoJRt5py5k7kn4PFWZWnZezpm5nnWeRgCQPyoiwUPIn8U9KlsdpifDn8RCCI4E0sxGs2 VxnlDHUY/B1cbz/VkexoNXJD0IO324NxmJ5+lmTYlkHMzkiEqcLS+IfYOvKQtn7fJTCmwQEkEuBY4 wGVwUUrmy9I8BvBy/VXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mn2rf-002WoA-8w; Tue, 16 Nov 2021 18:07:27 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mn2rb-002Wma-TR for linux-arm-kernel@lists.infradead.org; Tue, 16 Nov 2021 18:07:25 +0000 Received: by mail-pg1-x52d.google.com with SMTP id r132so16199152pgr.9 for ; Tue, 16 Nov 2021 10:07:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dJLPLJIkQPjO7UzbeQTBcB7R7AACxPrWxl+uljB+ks4=; b=MuEc9myys8soSc9S5p/9ZYxQFINzZE+kAA+k/U3FM52jlU+6MJ1sN342xuvi42MyiM ZMBjLooJ7voz/onZnJrPlWcorIIuLCoKkgjvfuvaYADaSZoZDmAMeW84d3xwQVEbocct qdT5YRu1/seNagLz3qhmq16768PfXRj60IRok= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dJLPLJIkQPjO7UzbeQTBcB7R7AACxPrWxl+uljB+ks4=; b=BdGqUKEp5x8oNlr4jS3EtDrfHFQOYxncA2IECIK+c3p5Wssu95hn09mp/dkC/5f8a9 xIwImn+7sm2B1djpGaHkq5t2Yg0nh5srMH0LkZDAxU1TAnl62SbObOqZgO/HbC2BpO15 FPUzNkuoWkV5WEpHmX7KNViz9OEkWE4I7VfnmxOmHL/j+H8buc/2mOF4GGeWjoBFw3ov NVd3T6DrSsR5mQBRtJvBDEYPRgvsTdTeUEbXPKp6l4M6fzHOFlgll+prK1ZXiWUmHBTz HPbTw3d/L0G8otIH/0oCm2yO0scjn7+DaRhXs03e2Bn80/q7/eeJP+dWA45EBNFx6MgV gwUA== X-Gm-Message-State: AOAM531ac51gToe439djdD5+xg/jJpLsX+M/KBJYiakzcNIkc1EfPgUx UtaLSN9Jy5WtUSVp7mmHhpPOaA== X-Google-Smtp-Source: ABdhPJwhmpm1yvMfuJzR2UucqZRo6IvMajPPkE5cdkExWK4ezhfJ19WuO6fjzPR4AH6ILz/jpNvTTw== X-Received: by 2002:a63:c61:: with SMTP id 33mr552897pgm.415.1637086037631; Tue, 16 Nov 2021 10:07:17 -0800 (PST) Received: from localhost ([2620:15c:202:201:54aa:73ab:b480:41e2]) by smtp.gmail.com with UTF8SMTPSA id e7sm2315303pgj.11.2021.11.16.10.07.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Nov 2021 10:07:16 -0800 (PST) Date: Tue, 16 Nov 2021 10:07:14 -0800 From: Matthias Kaehlcke To: Doug Anderson Cc: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi , devicetree@vger.kernel.org, Peter Chen , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Bastien Nocera , Ravi Chandra Sadineni , Michal Simek , Roger Quadros , Krzysztof Kozlowski , Stephen Boyd , Andrew Lunn , Aswath Govindraju , Dmitry Osipenko , Fabio Estevam , Gregory Clement , Krzysztof Kozlowski , Pawel Laszczak , Sebastian Hesselbarth , Tony Lindgren , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v16 5/7] usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on' Message-ID: References: <20210813195228.2003500-1-mka@chromium.org> <20210813125146.v16.5.If248f05613bbb06a44eb0b0909be5d97218f417b@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211116_100723_989572_F62B828F X-CRM114-Status: GOOD ( 14.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 11, 2021 at 03:48:06PM -0800, Doug Anderson wrote: > Hi, > > On Fri, Aug 13, 2021 at 12:52 PM Matthias Kaehlcke wrote: > > > > config USB_DWC3 > > tristate "DesignWare USB3 DRD Core Support" > > - depends on (USB || USB_GADGET) && HAS_DMA > > - select USB_XHCI_PLATFORM if USB_XHCI_HCD > > + depends on ((USB && USB_XHCI_PLATFORM) || USB_GADGET) && HAS_DMA > > Technically you don't need the "USB &&", right? Since > USB_XHCI_PLATFORM is defined in 'usb/host/Kconfig' and that's only > even included if USB is defined. So it can be just: > > depends on (USB_XHCI_PLATFORM || USB_GADGET) && HAS_DMA True, the dependency on USB isn't strictly needed. > That's not terribly important, though, so: > > Reviewed-by: Douglas Anderson Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel