From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78D39C433EF for ; Tue, 30 Nov 2021 08:44:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0AeWq01SrSmxjNKNY4JzesP5QK2fYOlHc62h7MtUG40=; b=i+507RwcV7weHo 79EglBB/8eUsqto8hlpbIstNSXaRNK4BENqMGlue0c+S2eXNKm0YB0AUf28zLwTC4FlH0HWU6Kigq YDAZRbjG+2E4vFxZr4/uZFsEvZByhSgNMU5J4ziserghyMDTH4Lb64QrYUIg5G1pXTvkSijPcD7lW RWqt5FdV4hk/gamt0TO1aq/878ES1N5KMDpP1aeQrAYuGEFYqlrClSEuobqBqTypH0NrkdfTRTyLg anaAdNQHEwYFYPuTkxPYShzpVabU0/QQwUta6awDL3fzUGXmhLQ7GmRQTOIyODFIuLE3Ep6l8fgC+ 7/aOMPWr2QMY8YVG8Nyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mryjT-004AYM-Lx; Tue, 30 Nov 2021 08:43:24 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mryjO-004AV2-2o for linux-arm-kernel@lists.infradead.org; Tue, 30 Nov 2021 08:43:19 +0000 Received: by mail-pl1-x636.google.com with SMTP id v19so14344711plo.7 for ; Tue, 30 Nov 2021 00:43:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fHVy98BTaUQF52BWKLZtuQVRzz01N8+H95C8cB4Mhtg=; b=dkAqbyqTPRY4L/DB0uLdYdRPU6b1N+TybDCY0FHBvSZn/2S8Ae0v0tdFZwYj7zBLDi 8QqrjFuNnxaIPD8BAr2rJhpwB2cDkqWynWjh0Ac4qLo6dTsE54UqsPiCOX+RddtIHAO2 8JBLdxXwcjC/F/oqOtekIMDpqcxK4ymeEg2t/OKu6eb2DQDHJUzH+N2n7plAhq184vX+ 3ilr42mjOAMqMwT+OGrhYyComtrMz2+AeX0KPKFk06V5xiL+cTmcyS3TObk+6xDdalRD 5Gaot3pJL+djNMmQ9F1IXX3Sxk97PgB1c7iou+/rl9Rq5op0ena4PcLEXQYlr5biumJp qtzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fHVy98BTaUQF52BWKLZtuQVRzz01N8+H95C8cB4Mhtg=; b=kmGnAaiPWrs5JdZTtaaxDz+xZXUkwcUnUyFBwrfHzJ0zV6i8oXtDiu/k1CcjU6t0Ei SQ13dmE6V3uoyHA1M1URXO9JYNgL4e4/v7fquFSiRfBSFzFOtpZQytuy1+tCP+GS0+YG xNmxIFiK4hjIASAFOZ6stP+vbKcX4Ev/p69wmTXuTZfbUd8yeY+ukTuGLDRNDcAiphyq fiMTjBD/SoVYVsUbkNzscMxGbGdO1r5DoLVkoEZCTZH2KM1Fg73e8S5bGMnFIcGaVuDp OFBoyndaYH0V82vuj1dPnBRNexirSomg8mCgPnodsl/s3HuvAlfCVeO+f5WFei1BJTl/ iz1Q== X-Gm-Message-State: AOAM533WzdqDGRpHyywGvBRFKiDK73LGTzLuJuU1HZ/JAG7KdNhJJJRX YUJtaYAIOPqthngqrads+P3EKA== X-Google-Smtp-Source: ABdhPJxue2FBF6O8NbPbziRrwGNOciaOEZ/z8FnZ1b/zhjeFgaTTmvLKkjb9rz4cIuDD9UU5GWKBaQ== X-Received: by 2002:a17:903:24d:b0:143:beb5:b6b1 with SMTP id j13-20020a170903024d00b00143beb5b6b1mr66622707plh.54.1638261792852; Tue, 30 Nov 2021 00:43:12 -0800 (PST) Received: from google.com ([2401:fa00:1:10:6cb4:a0cc:6d7f:cba7]) by smtp.gmail.com with ESMTPSA id v10sm20770644pfu.123.2021.11.30.00.43.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 00:43:12 -0800 (PST) Date: Tue, 30 Nov 2021 16:43:07 +0800 From: Tzung-Bi Shih To: "allen-kh.cheng" Cc: Mark Brown , Rob Herring , Matthias Brugger , Jassi Brar , Linux-ALSA , cujomalainey@google.com, Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , Jaroslav Kysela , Takashi Iwai , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, sound-open-firmware@alsa-project.org Subject: Re: [PATCH v8 3/3] mailbox: mediatek: add support for adsp mailbox controller Message-ID: References: <20211129101946.6008-1-allen-kh.cheng@mediatek.com> <20211129101946.6008-4-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211129101946.6008-4-allen-kh.cheng@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211130_004318_183988_9B77755D X-CRM114-Status: GOOD ( 12.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 29, 2021 at 06:19:45PM +0800, allen-kh.cheng wrote: > diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c [...] > +static int mtk_adsp_mbox_probe(struct platform_device *pdev) > +{ [...] > + mbox->dev = dev; > + mbox->ops = &mtk_adsp_mbox_chan_ops; > + mbox->txdone_irq = false; > + mbox->txdone_poll = true; > + mbox->of_xlate = mtk_adsp_mbox_xlate; > + mbox->num_chans = 1; > + mbox->chans = devm_kzalloc(mbox->dev, sizeof(*mbox->chans), GFP_KERNEL); I have commented in the v3[1]. To be neat, I prefer to use "dev" instead of "mbox->dev". If you ever have the chance to respin the series, please fix it. [1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20211124084514.28002-3-allen-kh.cheng@mediatek.com/#24614933 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel