From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42953C433EF for ; Wed, 2 Mar 2022 13:07:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OxioTddFEBr30bLKyQflTEfpDBTHsSZ7XjhCKaKAp7s=; b=U66JFGWtgO8ynQ 1pEGEzerHYmaVdyBXSwDx30BirYwm+4TqeX9Yi/zCevKw0m3BKl1IRR+yhNEKCoFUEt+HZqvYIdFt ZXUCtumzY4eZ4mbOlnvE+mQUr+TLjdcwGUN44ZnVrbqhUN0UQn/wQK9QCo3YqKOwjiX0IBX65H2qq Wc1UsRzTtBUhRh/uJXvz2VRlP17gl59Ztlrch9amGkVsNlc+IFyMisVoiw0EurZL4nf4YbY2ZnoOa FKOc49YbCW4iHxOQKekap5dkTbzhIaPiewk8HS+1wznTTdhKhDpmS/FAHda7ibVpLJMPdlIjTwzbW jejsiBt0tMi4QhfWHz/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPOgF-002hrz-SO; Wed, 02 Mar 2022 13:06:12 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPOgB-002hrH-UD for linux-arm-kernel@lists.infradead.org; Wed, 02 Mar 2022 13:06:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=HAXyBFQgUVdxAmj2m4irVlIbi28ci3NyzG6w9FJrnpo=; b=ix 3QAKfOb8taZ760/sB/w2raFHrsngAJA8L5gR74OL/nRn6OUBvjrWuYS32V+6EHZ0RKy1gA24JcdIL aTztDAnnTRSYOD0Knn8/3nqZ6LtPrUrfp0eILKXNhbjfDkcmA4gSM5qjvP08Tbkp+CDUL4MRQ/Y6m 24+fWWWL/ZjBdPk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nPOg5-008ux4-Vz; Wed, 02 Mar 2022 14:06:01 +0100 Date: Wed, 2 Mar 2022 14:06:01 +0100 From: Andrew Lunn To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Gregory CLEMENT , Marek =?iso-8859-1?Q?Beh=FAn?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: marvell: armada-37xx: Remap IO space to bus address 0x0 Message-ID: References: <20220218212526.16021-1-pali@kernel.org> <87o82r0zjh.fsf@BL-laptop> <875yoz0wpw.fsf@BL-laptop> <20220301092539.lru7hsaqxrjqz32r@pali> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220301092539.lru7hsaqxrjqz32r@pali> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220302_050607_997777_8313F9F2 X-CRM114-Status: GOOD ( 19.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 01, 2022 at 10:25:39AM +0100, Pali Roh=E1r wrote: > On Monday 28 February 2022 17:42:03 Gregory CLEMENT wrote: > > > Hello Pali, > > > > > >> Remap PCI I/O space to the bus address 0x0 in the Armada 37xx > > >> device-tree in order to support legacy I/O port based cards which ha= ve > > >> hardcoded I/O ports in low address space. > > >> > > >> Some legacy PCI I/O based cards do not support 32-bit I/O addressing. > > >> > > >> Since commit 64f160e19e92 ("PCI: aardvark: Configure PCIe resources = from > > >> 'ranges' DT property") this driver can work with I/O windows which > > >> have > > > > > > Should we add a "Fixes: 64f160e19e92 ("PCI: aardvark: Configure PCIe > > > resources from 'ranges' DT property")" tag ? > > = > > Waiting for your confirmation I tried to applied it but it failed. > > = > > Did you base this patch on v5.17-rc1 ? > > = > > Gregory > = > Hello! This change is breaking booting of Turris Mox kernel with older > bootloader due to bugs in bootloader. Do you know what actually goes wrong? I've not been involved in the discussion, but looking at the comments above, not changing the space can result in non-working cards. So it does sound like something which in general we want to do. Does the current code assume the bootloader has initialized some registers with specific values? Can that be moved into the driver so it also works with older bootloaders? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel