From: Rob Herring <robh@kernel.org>
To: Kuldeep Singh <singh.kuldeep87k@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, Robin Murphy <robin.murphy@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Subject: Re: [PATCH v2 2/2] dt-bindings: spi: Update clock-names property for ARM pl022
Date: Thu, 10 Mar 2022 16:08:42 -0600 [thread overview]
Message-ID: <Yip26uBIHgt42PDf@robh.at.kernel.org> (raw)
In-Reply-To: <20220308072125.38381-2-singh.kuldeep87k@gmail.com>
On Tue, Mar 08, 2022 at 12:51:25PM +0530, Kuldeep Singh wrote:
> Pl022 clock-names can be one of following:
> ['apb_pclk'] or ['sspclk', 'apb_pclk']
>
> The current schema refers to second case only. Make necessary changes to
> incorporate both the cases and resolve below dtc warning:
> clock-names: 'apb_pclk' is not one of ['sspclk']
>
> Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> ---
> v2:
> - Reword commit message
> - Drop SSPCLK
>
> Documentation/devicetree/bindings/spi/spi-pl022.yaml | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
> index 7d36e15db5b3..6cfab948624e 100644
> --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
> @@ -38,11 +38,13 @@ properties:
> maxItems: 2
>
> clock-names:
> - items:
> + oneOf:
> - enum:
> - - SSPCLK
> - - sspclk
> - - const: apb_pclk
> + - apb_pclk
Are you going to make the driver work with no SPI clock? Because this
change is saying that it is valid to have the APB bus clock and no SPI
clock.
Rob
> + - items:
> + - enum:
> + - sspclk
> + - const: apb_pclk
>
> pl022,autosuspend-delay:
> description: delay in ms following transfer completion before the
> --
> 2.25.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-10 22:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 7:21 [PATCH v2 1/2] dt-bindings: spi: Update clocks property for ARM pl022 Kuldeep Singh
2022-03-08 7:21 ` [PATCH v2 2/2] dt-bindings: spi: Update clock-names " Kuldeep Singh
2022-03-10 22:08 ` Rob Herring [this message]
2022-03-11 2:57 ` Kuldeep Singh
2022-03-08 8:27 ` [PATCH v2 1/2] dt-bindings: spi: Update clocks " Krzysztof Kozlowski
2022-03-09 13:57 ` Kuldeep Singh
2022-03-10 22:05 ` Rob Herring
2022-03-11 2:55 ` Kuldeep Singh
2022-03-11 3:31 ` Kuldeep Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yip26uBIHgt42PDf@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=singh.kuldeep87k@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).