From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1BF9C433F5 for ; Tue, 15 Mar 2022 14:35:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ffzlw0fl0iESrzIwOckeWHy+mldS7vpoz3WFMnFylvE=; b=U5cjiom4j6dBL/ hEGYcGWo3B//iabKX6UESjn8t+gt1FgSwnmv5gLCVkzj0PdzDzquZD0++cM2umxNRSprV+lbjUZTA oXRui+QaLDUgmTsGrdxRSdLwgiQ7up/T1d4uDLwFXCRO5oDg0CS+FbnObyh81ppFPQgDHm2GiY44i XTCPC2FKbkU0E1o63vA/cPSVwAco78D9YUe1nXnyTUDnRMmozqqogTJKyAnpximXDUXT3615+jjew pP7c4LzPO49RT2sjrrO5LmDsV/DE2OgeX5Pd7U+botIEBrMQi4HqokMFoussvaPpirHM7D0oSu8Xk 3zUwTkrWmgYO1+8+w2IA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU8G3-009T2x-EC; Tue, 15 Mar 2022 14:34:43 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU8Fd-009Srg-WC for linux-arm-kernel@lists.infradead.org; Tue, 15 Mar 2022 14:34:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=eJsfs1ayMlkHRMVaZjiTJvsea1SB/3jhR8tU9VpMC4Q=; b=noTAN4Ep6VH8aqKxHHTygbvmc3 GAYZ0uSnZPDa80wL00A9Zed3nWWcHfqGIg9dZwNZK8THRjMmQEaGn/qaPmrGvepVa2eMBhZWPw+gk CEKltoMLGKEa7cfbM0Qh4V6h0cdlEg5sjMhW/5xlJIyKMn/e6+g6WVJily/0hvNVFpos=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nU8FH-00Aybj-Jz; Tue, 15 Mar 2022 15:33:55 +0100 Date: Tue, 15 Mar 2022 15:33:55 +0100 From: Andrew Lunn To: Krzysztof Kozlowski Cc: Chris Packham , huziji@marvell.com, ulf.hansson@linaro.org, robh+dt@kernel.org, davem@davemloft.net, kuba@kernel.org, linus.walleij@linaro.org, catalin.marinas@arm.com, will@kernel.org, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, adrian.hunter@intel.com, thomas.petazzoni@bootlin.com, kostap@marvell.com, robert.marko@sartura.hr, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 4/8] pinctrl: mvebu: pinctrl driver for 98DX2530 SoC Message-ID: References: <20220314213143.2404162-1-chris.packham@alliedtelesis.co.nz> <20220314213143.2404162-5-chris.packham@alliedtelesis.co.nz> <04ed13f1-671f-7416-61d0-0bf452ae862e@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <04ed13f1-671f-7416-61d0-0bf452ae862e@canonical.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220315_073418_072486_80C1358E X-CRM114-Status: UNSURE ( 9.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > +static struct platform_driver ac5_pinctrl_driver = { > > + .driver = { > > + .name = "ac5-pinctrl", > > + .of_match_table = of_match_ptr(ac5_pinctrl_of_match), > > of_match_ptr() does not look correct for OF-only platform. This should > complain in W=1 compile tests on !OF config. The Marvell family of SoC which this embedded SoC borrows HW blocks from can boot using ACPI. I doubt anybody would boot this particularly SoC using ACPI, but the drivers Chris copied probably do build !OF for when ACPI is in us. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel