From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DD39C433F5 for ; Wed, 16 Mar 2022 15:34:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zYTf3j7++prer6HmzVH0J5DZB2PLP9zaxHbWqn9hPvM=; b=Jj1KGVeY9RodSt pm5ZIE6X83DxJqiDWtIYeX788YE9Db2TuePig0c+vcQ8c2R32ZXbADXRA/QoQsZkrnLDeEIxdUQXy 2TO0pKz2b4WYmi8kPli0G/QSCFCG0/1im+14uq/nkqBp+JubVuasb1vBQ5jO4Wk1RYC/zfuue5aDs ePXjwwVy/fifyaJ7GlBfbeuUZkM6nv+4s5h12KQgFzTZ1SPiGhblVE5krfekkVjScB39peOkEYCuD ruiTZLsAHoheTzFF35DPFg0GDyAfe40NI9p6MZdco0lU5ZRVFR2XF2Z0mh2HyS0rGdv8TmtTc6Evh SZ952VLyDoRbS+oYp5Eg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUVd9-00DZrk-LA; Wed, 16 Mar 2022 15:32:11 +0000 Received: from mail-mw2nam10on20705.outbound.protection.outlook.com ([2a01:111:f400:7e89::705] helo=NAM10-MW2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUVS5-00DUz4-Ue for linux-arm-kernel@lists.infradead.org; Wed, 16 Mar 2022 15:20:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FL+HuH5w5QUNxz5YJZJcNwvI5VXO2iVW1+nogO3e/W0ovjtgeQMyqdapmZ2jnsUn6i455x1M2Q/cKVM/FXhzJu23DyKJCiXwMu8QDdaYhFFplxGiBlBkYioqAZAcWCFCmGC0+Ut356VwYC0dp2lb4KbHpz2b4Wv+gDyVXi4rHLJE/4N4rVBFbTzr/xqh8ilXwc6fDf7lez+16E4OujV4JEYpHZzPTLnfIeeZ+IjS5p8Rh+vGJITi8m150r+zMsiej1GZXMq6K6uKoutdVoQV4CEldGgsoLNtQl4FqSJCcy8mnRBDzAq9242JGoendhEweKvQ7h7VFlDMy7ZGtVRWtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qZu0rN7XbI47qOfBKCpUifksFqATGovAix5yShSNmv8=; b=F3U8w9CO48G4yeouw4122fslhG203FLA0D14jAxDKKuR/15Yi+ElFS6o0d57ZNJphRrl6fMIbkV9AI9GbnlwNC93+sac3eGGJz0FE+cVTTZyADePxsBDPpkGVKqySGTpKzdzIl2j8kCpB3EDeXeRaDdD0eGa94qY1CALGfZx+ZRIU/uCWV+uPzAMXw+H0opPA4dd4s0samUSsq47TiQxoOabNX4rpIrZ6lmUoZ2q8sHW9Zx9f075Tx812gUYhWXcazENS4GvOASN61ZDM6n6XJ5XEa9qexZ7pat+1l/6H7QITGbHpH5/1QUuGVRc1smXuu6dZrepdKff4lmWXmerQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qZu0rN7XbI47qOfBKCpUifksFqATGovAix5yShSNmv8=; b=gX/lLrW0J9DbKKfrtdH/LAgNhA/yQud6WrUBuyyD0nl3uEXvltHM5pRlYIrtCFzE/pe5gLLzuxVzuS2He/2UUfBPyi38lekCj5dS0+xMwASY8HGZrvUNpgDJVRsJaH0oqonOwz42HPK3KcR9EDqe9Fbylu+a7jfm3WEQQ38gnvI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from SA0PR01MB6329.prod.exchangelabs.com (2603:10b6:806:ee::12) by BN0PR01MB7103.prod.exchangelabs.com (2603:10b6:408:152::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.14; Wed, 16 Mar 2022 15:20:35 +0000 Received: from SA0PR01MB6329.prod.exchangelabs.com ([fe80::f56a:e18f:b6c4:ddb5]) by SA0PR01MB6329.prod.exchangelabs.com ([fe80::f56a:e18f:b6c4:ddb5%9]) with mapi id 15.20.5061.028; Wed, 16 Mar 2022 15:20:34 +0000 Date: Wed, 16 Mar 2022 08:20:32 -0700 From: Darren Hart To: Dietmar Eggemann Cc: Vincent Guittot , Will Deacon , LKML , Linux Arm , Sudeep Holla , Greg Kroah-Hartman , "Rafael J. Wysocki" , Catalin Marinas , Peter Zijlstra , Valentin Schneider , "D . Scott Phillips" , Ilkka Koskinen , stable@vger.kernel.org, Barry Song <21cnbao@gmail.com> Subject: Re: [PATCH v3] topology: make core_mask include at least cluster_siblings Message-ID: References: <20220308103012.GA31267@willie-the-truck> <7ac47c67-0b5e-5caa-20bb-a0100a0cb78f@arm.com> <9398d7ad-30e7-890a-3e18-c3011c383585@arm.com> Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MW4PR04CA0049.namprd04.prod.outlook.com (2603:10b6:303:6a::24) To SA0PR01MB6329.prod.exchangelabs.com (2603:10b6:806:ee::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 682b50ed-8efd-40ec-b2ba-08da07608475 X-MS-TrafficTypeDiagnostic: BN0PR01MB7103:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1+95JofcmdX/3/ZJ/8fQeB3t7c5qDUiClc6gXzJZwLEUrgIaJ4jEEmsD5UAroKRbhKygJdfSMavrg0555SjngKJEVH5lyoe/fOHk1GMrhTLycnuAwwbWreG5MvH07HZ9JgaX84vLcsKPfqiQcZD2HtOHZq7l6P8FDZGA68+XDWQbdhCOUDDqjkv2eutmGw4TAI8ZrlwtjxeAqY9o/JlG54zLOOXoNS511+rBhIETmz3B8JNOXM78tFae3KXXgkEIU4sC/aBsX7/LIKpUZKD+IM6nK6mU8rEGHvOO4oVhD0ZEIsAB5jE8rGX+kbtAiLvbwjjUtcek7MxUNjZmk0YoZH0HBzNknAaMfwrAp3671Lj1BvwxwurvNXVNOoDbvbmcvzxSr6ReydBKDmpbSzrvG9a/QOy10VTjqPNJMB4sLxR6KK57eky17x50A9DeRvJWho0eofM9M6erX3o/3zLvEmtA0gVvOm2xYWt4mb4uKbeiETRAHzT69ZglkcFVWSGKBZxPA1CWg9Mhtskw82u5vuit49tIKdO4rkLH1bpafOj/qlX0srnYljF6fT5s/ysbdChOH6/C8XbDczIHICxOHDcu+XT+qNMvJXhnYldvatKxNEm5JY4JyYrGLHQHe/xLFaTSpCEUjE598Gc5JiGXnkFBF+X2M9UsanVal/Xnk7OmO2HNocZ0fVhAjU9v1JqYZxnM3CoFZOB6PzJPvrol+Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA0PR01MB6329.prod.exchangelabs.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(7916004)(366004)(2906002)(33716001)(316002)(6512007)(6916009)(9686003)(54906003)(38350700002)(186003)(38100700002)(86362001)(5660300002)(508600001)(7416002)(4326008)(8676002)(66946007)(66556008)(66476007)(26005)(8936002)(53546011)(52116002)(6506007)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gL+ArBpvxYjZHCsaUYY/3KaTknXNz5h74LlC2Ak6qr67On6edefkGP5Y1Ad6?= =?us-ascii?Q?URANqJm0O6Zy4lVKfoYTEgxjiKkCejgEg3xsTvvBnCW3QmwP0ify9jmZ/r9t?= =?us-ascii?Q?MIR9jlDsNrbnD+5iNcKs8PKE+M4suYKMtl0p7An+OEnlZyaFNNnv9y3Xj/By?= =?us-ascii?Q?0OELpPet7wPc9xo1EvFCuGl7EZciyKSp1B/1DjwCwjgrFDdQcerxK/d3EaHG?= =?us-ascii?Q?z9ROFqGgW1LAo8tVImz9z2OpMEHkVK4X4BD0AmqwiHeIpyPdOnJH1MYO5r7E?= =?us-ascii?Q?cn2/mqQXLwoUaGFqnx7sfAWx3JX8ppDYM69thRYVr6SqajQPhXd0NxbvsigT?= =?us-ascii?Q?EcVutuSKP5y6LNQZZaGWlSIqZ+wMgHs0olu5hNm0HtPEMYAhadwy8BrmeFQt?= =?us-ascii?Q?9RvsOE0dVMphqKO+3WpJ6JyWAsyPqpeokqt6rLcPfCmKoaGJD2b/B1gYuTX6?= =?us-ascii?Q?i9LcSaQAP891ML0C8bF5ic16YsBC56a6nAsumAijceDAiVJ/L0U6Dse+RCNT?= =?us-ascii?Q?Jh72m9Lb52KeAwymyO/8VFTK3crSG6GiQZfS1wqRcB8uwJdILCmPXmiJR+9/?= =?us-ascii?Q?lwNeO3kh5JayNJGSIRBYla/obJUjgACfVhut3CXDO0/dQ0bRBpL8NmfqFvgD?= =?us-ascii?Q?EH/ycvsVDmOI1AUeYsu/ChLQWnZhg3ZRAxYpdUO4k/PCuBPJKucc/ME7ixjl?= =?us-ascii?Q?irZr1aMFtz9lJoEuctTWW4dx+ZQ9kXJWhwflzaoT2QIZBWQ85jLORXrjsY1d?= =?us-ascii?Q?Sloqw/x5kR74AVdJEgsy31VvrakmT0oDsdLoAY9I43QvvBUoIiuCwb45TCoz?= =?us-ascii?Q?OtN2Rk0XK7VEYfphaeLDU6NESfImBbUK6fP31CwtZ879UKXS41XMvr75UKGD?= =?us-ascii?Q?cMtzJkpAfgRz49KGN4rGkFRaAmHwbs3xUqqVLawmaFDJ7CmTv9DmVVr9Q4ug?= =?us-ascii?Q?GNQ4qECHH1aAhFHpcsYheZtCxPy/SVKDC8WO75nkXwViqM8efiOdImqRcZH4?= =?us-ascii?Q?1Z4RfHDy4aEjZqMVIqAqDhOyTnw8kzDZxzKHyvlli0ywReTkap7+8+cnN5ra?= =?us-ascii?Q?uXtPlheyptkpe5NvarxxvReQD9XgAQzapIrMzTF9NyrSyA2AikWyhEOyuoeK?= =?us-ascii?Q?wjUV2q9t2JaC1iDvjKJWTDB5rjGLBGvD2en+VvHmJIuUMiZPZnS3kcW98h9Y?= =?us-ascii?Q?Sb9qObIIR+z72UpFEEJtR4J2RiFb0KEiHW9bz98jZRDoJpHyrhgHVZx1Q1CH?= =?us-ascii?Q?Y5uLmlYv6ChMUvpwnCTzl+HHwyUWUHm4wRjqcT2dkp4Fms7kyyNocct9pql/?= =?us-ascii?Q?ds8j69J5JWT3n1nh7+vSDAiGvf5OC++BcnrbuSOmBYm+ZUe0QPBOFlJimsn6?= =?us-ascii?Q?HkLJPddPNcet5x/jRuocIncIyZ3JkRsChPSJfS0Ymmjvf1R9elaz+bJk8mPV?= =?us-ascii?Q?f4gvok2OL4/tm8vMq96fxqk/etPJYlt312YHKxxMB1OgAqKIcIRIRCri0rxD?= =?us-ascii?Q?KiMuRpbAECKETPg=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 682b50ed-8efd-40ec-b2ba-08da07608475 X-MS-Exchange-CrossTenant-AuthSource: SA0PR01MB6329.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2022 15:20:34.8157 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c44q/7dosQ1ggQaJU7g0RNSMPkmUvGclPep9LLpDCXaDatYFBzhsDkBInvP420FkKDRrsj5cEw+yPJcErO4qTAOjS9ZwYhdJpYhpWTG40Aa/07Y7Cw4gbdJDDjGtfUM2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR01MB7103 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220316_082042_208313_A343CFB7 X-CRM114-Status: GOOD ( 25.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 16, 2022 at 03:48:50PM +0100, Dietmar Eggemann wrote: > - Barry Song (always get undelivered mail > returned to sender) > + Barry Song <21cnbao@gmail.com> > > On 14/03/2022 17:54, Darren Hart wrote: > > On Mon, Mar 14, 2022 at 05:35:05PM +0100, Dietmar Eggemann wrote: > >> On 09/03/2022 19:26, Darren Hart wrote: > >>> On Wed, Mar 09, 2022 at 01:50:07PM +0100, Dietmar Eggemann wrote: > >>>> On 08/03/2022 18:49, Darren Hart wrote: > >>>>> On Tue, Mar 08, 2022 at 05:03:07PM +0100, Dietmar Eggemann wrote: > >>>>>> On 08/03/2022 12:04, Vincent Guittot wrote: > >>>>>>> On Tue, 8 Mar 2022 at 11:30, Will Deacon wrote: > > [...] > > > Ultimately, this delivers the same result. I do think it imposes more complexity > > for everyone to address what as far as I'm aware only affect the one system. > > > > I don't think the term "Cluster" has a clear and universally understood > > definition, so I don't think it's a given that "CLS should be sub-SD of MC". I > > I agree, the term 'cluster' is overloaded but default_topology[] clearly > says (with direction up means smaller SD spans). > > #ifdef CONFIG_SCHED_CLUSTER > { cpu_clustergroup_mask, cpu_cluster_flags, SD_INIT_NAME(CLS) }, > #endif > > #ifdef CONFIG_SCHED_MC > { cpu_coregroup_mask, cpu_core_flags, SD_INIT_NAME(MC) }, > #endif > Right, understood. It is a clear expectation of the current Sched Domain topology abstraction. > In ACPI code we have `cluster_node = fetch_pptt_node(... , > cpu_node->parent) but then the cache information (via > llc_id/llc_sibling) can change things which make this less easy to grasp. > > > think this has been assumed, and that assumption has mostly held up, but this is > > an abstraction, and the abstraction should follow the physical topologies rather > > than the other way around in my opinion. If that's the primary motivation for > > this approach, I don't think it justifies the additional complexity. > > > > All told, I prefer the 2 line change contained within cpu_coregroup_mask() which > > handles the one known exception with minimal impact. It's easy enough to come > > back to this to address more cases with a more complex solution if needed in the > > future - but I prefer to introduce the least amount of complexity as possible to > > address the known issues, especially if the end result is the same and the cost > > is paid by the affected systems. > > > > Thanks, > > Yeah, I can see your point. It's the smaller hack. My solution just > prevents us to manipulate the coregroup mask only to get the MC layer > degenerated by the core topology code. But people might say that's a > clever thing to do here. So I'm fine with your original solution as well. > > [...] Thanks Dietmar, Sudeep, do we have sufficient consensus to pull in this patch? Thanks, -- Darren Hart Ampere Computing / OS and Kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel