From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B46EAC433F5 for ; Fri, 18 Mar 2022 15:51:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cX86B4Q2xYUeWuWEGh7H1uQHR6M/MCuFVOjubANnw14=; b=Qy8x0tNW21uHvj c1E3ShOKkLg57d0eOu8jVXuI66EdGog89ZSUKeuvKHoXcOZ78vxYIpSx/lJOcCPFEggIggQZD699n bIip1u3HtsHsysaLVVyfyUY/vbiqbV6zo4pP8CCm3tmQZHyPY3TGDlXDWA6bSa7eq49EUbYCBHeOP rV5HwXAJU0pl44qKUcE67TygD2dFifz+ozrR99Z7dRCd2hIlYIAVhYNfx5Mj12a49qXc1JUj6Lwvq KINJqT2QMSqR/7LyIYOBQ/UWjO8L+dd5nEt5EXVSgai/nzUewsr6/69mQ1gbP7QrltKwh2DDinuUl GiD4GCwpTxOAUu+7XFsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVErh-002JFY-74; Fri, 18 Mar 2022 15:50:09 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVEre-002JFD-6e for linux-arm-kernel@lists.infradead.org; Fri, 18 Mar 2022 15:50:07 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B22D4B82474; Fri, 18 Mar 2022 15:50:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A98CCC340E8; Fri, 18 Mar 2022 15:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647618603; bh=5uXL2x8DBwPa0cjyYC6YBKuUMgI5fKBpohYJLpVwkRU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mLaxEglc7duHdibRRJgglHKlHginIPE1xSMZtIsv9GhGSrS2VkQFj99XdDp05uven Zvp+u2gSF5ARMCqDn0s/EtoYWiL8BrKzRrJXCDy9zmCCdGwAplqBeGePju0rZ0AeV2 0NV1oHOpTZPeJAvqJt0N7ctm68j0JITWyMKmwgKM= Date: Fri, 18 Mar 2022 16:49:59 +0100 From: Greg Kroah-Hartman To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@huawei.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, peter.hilber@opensynergy.com, "Rafael J. Wysocki" , Alexander Viro Subject: Re: [RFC PATCH 07/16] debugfs: Add signed versions of debugfs_create_u32/64 helpers Message-ID: References: <20220227205608.30812-1-cristian.marussi@arm.com> <20220227205608.30812-8-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220318_085006_435408_96901C7A X-CRM114-Status: GOOD ( 21.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 18, 2022 at 03:39:40PM +0000, Cristian Marussi wrote: > On Fri, Mar 18, 2022 at 02:21:32PM +0100, Greg Kroah-Hartman wrote: > > On Sun, Feb 27, 2022 at 08:55:59PM +0000, Cristian Marussi wrote: > > > Add a few helpers to deal with signed values integers; built on existing > > > debugfs internal helpers as the existing unsigned functions already do. > > > > > > Make the simple_attr_write() internal helper detect the sign of the > > > requested set operation from the related format string: this is needed > > > to be able to properly parse negatively signed input strings. > > > > > > Cc: Greg Kroah-Hartman > > > Cc: "Rafael J. Wysocki" > > > Cc: Alexander Viro > > > Signed-off-by: Cristian Marussi > > > --- > > Hi Greg, > > thanks for the feedback. > > > > Note that in the rest of the series I do NOT need the s64 WRITE/SET > > > operations, that required the more invasive simple_attr_write() change, > > > but it seemed odd to implement a get only debug_create_s32/64 API. > > > > Let's wait to add them when we have a need for them with a in-kernel > > user. Otherwise I'll just end up removing them eventually when I sweep > > for "is this used" cleanups. > > > > Ok, so just to double check what I understood(or not), I'll leave out the > setters ops and implement instead the debufs_create_s32/s64 with only RO > fops support, right ? Only create what you actually need. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel