From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 488ADC433F5 for ; Fri, 8 Apr 2022 06:43:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WKYEJDtvQ/MoInv1mbEFLHt45PssTJH+ehunxmTy75g=; b=EKy5AJ+N6YK9hQ 9Yq0cy9Qim8cDNur5quBL6+1bz8cbD/L9tOQvt1Ckt9DeqOubeFe3gli9pdQLfPEta4De9tHNwxqo 0z8g0qthK5WLT8iAkHta4XdPufwogGLZ7ezmKb8C1+As4RhhqbNbkGOCij1u+Dh/jygM0FCSjPvDN rUw72YEhPdacoN4FGMso/S6B3iQLdLOhst1L7Y714EAMC04bkFF/iIDU32t45N/OLcgkcbVBQCeVt OvZUIV2fo+OHs8zc38vTh+lZ/NonhGWoqwcOEYFict0hBhTIa9XixY+5qZmaLTcV9IX+bDbYAn1Js SgUK3RGAIuNaLIbOhhlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nciKE-00FLZ4-8v; Fri, 08 Apr 2022 06:42:30 +0000 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nciKB-00FLXZ-LO for linux-arm-kernel@lists.infradead.org; Fri, 08 Apr 2022 06:42:29 +0000 Received: by mail-pj1-x1035.google.com with SMTP id h23-20020a17090a051700b001c9c1dd3acbso8778839pjh.3 for ; Thu, 07 Apr 2022 23:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pYAWmA2mzvjlynkITTRP/QBtHX3DhppNiVnqizFawyk=; b=m3eYQ2SnsKAcXforZE0s4H1JXIupwn57zG7A5EQuiAUeTmfB/YyOuJHhZ9yQ22aUF0 3kfjqC5krkpaxIthl7/vQy19PpxneYBHPRMJcaxknoh+6MdmvYpx7Lhy3ta5XYHHXjc/ AKtVXXTuaCKISLYE7p7qwwYQ5kSIJn7feeTslmOfyFWPTyt46OPW/mQnvQi4a9RL+eeM uNX9FazyIfGRhHoa3yBGa8oj3ZUS05YB0SXqa1vcQp1todBt5YDNWmIBeUUrMXW9s3tS 3BdsLGxJt/ZWuHu2bI3uahgcfBUNOv7NKZmsE5JcQmrJ2Agnx47JhHBJb06JYarwEwUJ q78w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pYAWmA2mzvjlynkITTRP/QBtHX3DhppNiVnqizFawyk=; b=AIP3TNXKwX5j7BeoY5pa69uTB/tFl8Ni8H7FujkMIg6LOc7L7B16Va9QxtH3rgfRzU gi14hfXZf6p9JhNRaz9/OdnrLgTysWOMhsPJXArEW/nPGGGRgKfjdWlOajlIs88ErOY7 DLDi9uYrV0BuMuMCQyfxULB9xQyGFt7zmk+DWJlR2q9890TrE3eXO+wTIkw7JRNgRKev WK8eokT6v+mohqhsiC1FNUg/UO1Ok5z8CwZfGCCHSjIYaEhSh0k2DRFDROSX0Gf3x/2O UgWjHtuS9gcTZ8OToA3voQFMGtKK/6GKDGpiH1Detr3QmldT9CYCaMjNoRlXn+Bf59Wu tu1w== X-Gm-Message-State: AOAM531B3EJFDbfjfrwypSVxmYoA3BcvjvfuuWf2X152jxVuxLNkuv3N /RbdFGYD6FculfgfPXJvljI= X-Google-Smtp-Source: ABdhPJwzWfhiEuvayiUnpNnk4zCnrgrOkuebnQasPetk1mTi8/i/6CSqaM+0Z7ybryAGQdYAW9vLBA== X-Received: by 2002:a17:903:2446:b0:154:3bb0:7ba0 with SMTP id l6-20020a170903244600b001543bb07ba0mr17352444pls.38.1649400143908; Thu, 07 Apr 2022 23:42:23 -0700 (PDT) Received: from hyeyoo ([114.29.24.243]) by smtp.gmail.com with ESMTPSA id y24-20020a056a00181800b004fac7d687easm25036917pfa.66.2022.04.07.23.42.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 23:42:20 -0700 (PDT) Date: Fri, 8 Apr 2022 15:42:13 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Catalin Marinas Cc: Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/10] mm/slab: Decouple ARCH_KMALLOC_MINALIGN from ARCH_DMA_MINALIGN Message-ID: References: <20220405135758.774016-1-catalin.marinas@arm.com> <20220405135758.774016-2-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220405135758.774016-2-catalin.marinas@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220407_234227_739198_69AD0696 X-CRM114-Status: GOOD ( 25.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 05, 2022 at 02:57:49PM +0100, Catalin Marinas wrote: > In preparation for supporting a dynamic kmalloc() minimum alignment, > allow architectures to define ARCH_KMALLOC_MINALIGN independently of > ARCH_DMA_MINALIGN. In addition, always define ARCH_DMA_MINALIGN even if > an architecture does not override it. > > After this patch, ARCH_DMA_MINALIGN is expected to be used in static > alignment annotations and defined by an architecture to be the maximum > alignment for all supported configurations/SoCs in a single Image. > ARCH_KMALLOC_MINALIGN, if different, is the minimum alignment guaranteed > by kmalloc(). > > Signed-off-by: Catalin Marinas > Cc: Andrew Morton > --- > include/linux/slab.h | 23 ++++++++++++++++++----- > 1 file changed, 18 insertions(+), 5 deletions(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 373b3ef99f4e..d58211bdeceb 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -187,17 +187,30 @@ bool kmem_valid_obj(void *object); > void kmem_dump_obj(void *object); > #endif > > +/* > + * slob does not support independent control of ARCH_KMALLOC_MINALIGN and > + * ARCH_DMA_MINALIGN. > + */ > +#ifdef CONFIG_SLOB > +#undef ARCH_KMALLOC_MINALIGN > +#endif I think you should replace ARCH_KMALLOC_MINALIGN with ARCH_DMA_MINALIGN in mm/slob.c too? Or detect minimum kmalloc alignment in runtime like SLAB/SLUB? current code seem to break with SLOB on machines that has 128 byte cache lines because ARCH_KMALLOC_MINALIGN is 64? > + > /* > * Some archs want to perform DMA into kmalloc caches and need a guaranteed > * alignment larger than the alignment of a 64-bit integer. > - * Setting ARCH_KMALLOC_MINALIGN in arch headers allows that. > + * Setting ARCH_DMA_MINALIGN in arch headers allows that. > */ > -#if defined(ARCH_DMA_MINALIGN) && ARCH_DMA_MINALIGN > 8 > +#ifndef ARCH_DMA_MINALIGN > +#define ARCH_DMA_MINALIGN __alignof__(unsigned long long) > +#elif ARCH_DMA_MINALIGN > 8 && !defined(ARCH_KMALLOC_MINALIGN) > #define ARCH_KMALLOC_MINALIGN ARCH_DMA_MINALIGN > -#define KMALLOC_MIN_SIZE ARCH_DMA_MINALIGN > -#define KMALLOC_SHIFT_LOW ilog2(ARCH_DMA_MINALIGN) > -#else > +#endif > + > +#ifndef ARCH_KMALLOC_MINALIGN > #define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long long) > +#else > +#define KMALLOC_MIN_SIZE ARCH_KMALLOC_MINALIGN > +#define KMALLOC_SHIFT_LOW ilog2(KMALLOC_MIN_SIZE) > #endif > > /* > -- Thanks, Hyeonggon _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel