From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96D8BC433EF for ; Thu, 7 Apr 2022 09:51:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q2493d3uue0GLKLV71cSScPAlDdoMaBgi7/p4c9Ieh8=; b=OkzwrS81TDjfNr NXzdDCADj/4kRyRtodPd4FLomWu1iSTdYK2Zx1WNmJozBt2sNFbOwp40C3MVSXbImHYUdHLniMGHM QPnRcFNlelgPYQWx6TtbSO6/D4WkSB09DfsroMu/xhuLXmBIKqbLTVEf+0xczMhRYaNsusVd0E2zu p65FsxCocJFbTCWVU6AnPA3n3NOPzUQ+oy6TqZJIvQi6Wd+XZW7fzBlcE/NIGsQcpyPh3LKSVZghK 008HqivVKQwpxRbTWdByP0ePUaEMbmc+mOx4LWwssnLri7so/KbZ+pXdcX7M8Abrqpl47Ur+2sYDb y2aAml0yZnw/bhpIXJnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncOmN-00B0j1-Lq; Thu, 07 Apr 2022 09:50:16 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncOOD-00Apsd-6m for linux-arm-kernel@lists.infradead.org; Thu, 07 Apr 2022 09:25:18 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4F87C61988; Thu, 7 Apr 2022 09:25:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77837C385A0; Thu, 7 Apr 2022 09:25:13 +0000 (UTC) Date: Thu, 7 Apr 2022 10:25:10 +0100 From: Catalin Marinas To: Muchun Song Cc: Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" Subject: Re: [PATCH 07/10] crypto: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN Message-ID: References: <20220405135758.774016-1-catalin.marinas@arm.com> <20220405135758.774016-8-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220407_022517_329027_89F24345 X-CRM114-Status: GOOD ( 23.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 07, 2022 at 02:14:15PM +0800, Muchun Song wrote: > On Tue, Apr 05, 2022 at 02:57:55PM +0100, Catalin Marinas wrote: > > ARCH_DMA_MINALIGN represents the minimum (static) alignment for safe DMA > > operations while ARCH_KMALLOC_MINALIGN is the minimum kmalloc() objects > > alignment. > > > > Signed-off-by: Catalin Marinas > > Cc: Herbert Xu > > Cc: "David S. Miller" > > --- > > include/linux/crypto.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/linux/crypto.h b/include/linux/crypto.h > > index 2324ab6f1846..654b9c355575 100644 > > --- a/include/linux/crypto.h > > +++ b/include/linux/crypto.h > > @@ -167,7 +167,7 @@ > > * maintenance for non-coherent DMA (cache invalidation in particular) does not > > * affect data that may be accessed by the CPU concurrently. > > */ > > -#define CRYPTO_MINALIGN ARCH_KMALLOC_MINALIGN > > +#define CRYPTO_MINALIGN ARCH_DMA_MINALIGN > > I don't think this should be changed since ARCH_KMALLOC_MINALIGN is > already aligned with the size what you need. With this series, ARCH_KMALLOC_MINALIGN is no longer safe for non-coherent DMA on all arm64 SoCs, that's what ARCH_DMA_MINALIGN will cover. Now, looking at the comment for CRYPTO_MINALIGN, one aspect it covers is the minimum alignment required by C for the crypto_tfm structure access. So a smaller ARCH_KMALLOC_MINALIGN would do. But the other part of the comment mentions in-structure alignment for non-coherent DMA. Here we'd need the upper bound alignment, ARCH_DMA_MINALIGN. I'll follow up on Herbert's email as I think he has a good point on structure vs kmalloc() alignment. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel