From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B51C1C433EF for ; Tue, 19 Apr 2022 09:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uBZQOrkuDdxktjEhmF+Bov3wjjyYcyIwpeCyUsEcAIE=; b=JgQn0hWhgYsMeq voZ0N931N07tb7rhCjZ3cmstbrBM9REBQGBKaOw1gBR8YdMf1pXmKF6LZmp9lCWWpNPUOMehtXuJc zc92pPo67x0+YWiWpYkV34tkDmTVomm/KeOEdFd2s9F8caNWRQZ82HT/lmvRj+hvUHovSDZs29y3Z TDN3UuIXgXmABotkgDrINaSMztaNitNgWAWhs496Yl3cOxNRQpDaPqjuoRCbjpqZ9r/Ou1wGEw0is GaUEVxKbY9izOmvK9H3shaRPUcBbEsWIMiRH1HGvmD9P/IavUJi/KJeq0WDwJ1HXRX5S602yittly n0p4ozb9UA0eOphTINKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngjmy-002Ty4-1w; Tue, 19 Apr 2022 09:04:48 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngjmw-002Txg-KW; Tue, 19 Apr 2022 09:04:46 +0000 Date: Tue, 19 Apr 2022 02:04:46 -0700 From: Christoph Hellwig To: Shameerali Kolothum Thodi Cc: Christoph Hellwig , Robin Murphy , "jon@solid-run.com" , Linuxarm , "steven.price@arm.com" , "linux-acpi@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "linux-arm-kernel@lists.infradead.org" , "Guohanjun (Hanjun Guo)" , yangyicong , "Sami.Mujawar@arm.com" , "will@kernel.org" , wanghuiqiang Subject: Re: [PATCH v9 06/11] ACPI/IORT: Add support to retrieve IORT RMR reserved regions Message-ID: References: <20220404124209.1086-1-shameerali.kolothum.thodi@huawei.com> <20220404124209.1086-7-shameerali.kolothum.thodi@huawei.com> <955601f02f3b474da3327963fb1630f0@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <955601f02f3b474da3327963fb1630f0@huawei.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 19, 2022 at 08:31:55AM +0000, Shameerali Kolothum Thodi via iommu wrote: > Sorry for the delayed response(was on holidays). So if we move the > iommu_dma_put_resv_region() call to generic_iommu_put_resv_regions() , > will that address the concerns here? > > I think it will resolve the issue in 05/11 as well pointed out by Christoph > where we end up not releasing reserved regions when > CONFIG_IOMMU_DMA is not set. As Robin pointed out we might not really deduct that ACPI means RMR. I suspect the best would be to just attach a free callback to the regions. Either by adding it directly to struct iommu_resv_region if we thing there are few enough regions to not be worried about the memory use, or other by adding a container struct for the list_head that contains the free callback. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel