From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65877C433EF for ; Tue, 19 Apr 2022 13:25:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YTd2UN2mZXvC5fyFjOxEq7/ehG01fo0SCWYufMf0/b4=; b=hOGrstg14ccRga X1HgfpNL8n+1+a9Sn9de0MWDaKIZi95hz2I11tsjE+YNk9ZMz04cddcJjer/E61fg2kA1hVakDct8 4PjCdMsH4edrKdkK/ho29frktZBWfTbqMR2KHgZ/3Ce7+++pjnGRjAMt3b2vWtGr9r7YWE+ov3H6w n/bZF4Z7/Mjvtk63TV8+hID/FQt5a6XZUhn/A+xvUB/QECo1BULrzk0xg6nzYL8stSmXJWS8TSOde piJmDeXCrQBPCEys4hqgeuGqFKzruUF5Q/U/VUgjTkGldaugC01sxeAdeMXTxdH5MB95KAnD+1xrC MdbCyB+EoRP8GTnFzAMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngnqM-003otE-5o; Tue, 19 Apr 2022 13:24:35 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngml7-003OiI-IU; Tue, 19 Apr 2022 12:15:07 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 66347614DC; Tue, 19 Apr 2022 12:15:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51361C385A7; Tue, 19 Apr 2022 12:15:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650370503; bh=egk3NV7ZTPANDM1QUGV3BN2ZMc0MwzdTAMdoUxfarx0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fpm43+mezkvM6YP/nwkJWU6CBtHl+xZ4KAgQrH6K1vUjE/GyQA70B0fhT9keBk58y NvLd6s7NIbwO0Ofi0TRXxQDRzLeO91x26/8dYnfLweVVkCcHSN7Gzkrj7LqdhaWmrU m7zRgCASPhbodzPxWwKB8N864xdfxNoxC9RyzLrM= Date: Tue, 19 Apr 2022 14:14:59 +0200 From: Greg KH To: Tom Rix Cc: nsaenz@kernel.org, bcm-kernel-feedback-list@broadcom.com, stefan.wahren@i2se.com, gascoar@gmail.com, ojaswin98@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vchiq_arm: change vchiq_platform_init from global to static Message-ID: References: <20220418164356.3532969-1-trix@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220418164356.3532969-1-trix@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_051505_782007_53B0776B X-CRM114-Status: GOOD ( 18.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 18, 2022 at 12:43:56PM -0400, Tom Rix wrote: > Smatch reports this issue > vchiq_arm.c:466:5: warning: symbol 'vchiq_platform_init' > was not declared. Should it be static? Error messages can all go on one line. > vchiq_platform_init is only used in vchiq_arm.c. Single > file variables should not be global so change > vchiq_platform_init's storage-class specifier to static. You have a full 72 columns, please use them. > > Signed-off-by: Tom Rix > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index 0596ac61e286..7de98655e8ec 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -463,7 +463,7 @@ free_pagelist(struct vchiq_pagelist_info *pagelistinfo, > cleanup_pagelistinfo(pagelistinfo); > } > > -int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) > +static int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) > { > struct device *dev = &pdev->dev; > struct vchiq_drvdata *drvdata = platform_get_drvdata(pdev); > -- > 2.27.0 > > Always test build your patches. To not do so is a bit rude, don't you think? {sigh} _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel