From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7386C433EF for ; Tue, 19 Apr 2022 15:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SmvD06CaQAg0yMw5vIMpjq7SvR3EOX9CsKOdtjRitws=; b=Gjibp859RIsbYj 2R278kwQed06j5pMtmeW2rk3Ip3rM1868dkuwLJ95o/Pt3hUx5KGNs0TNfWADn+C8IKPjxz618YHY phsGuiyyKiWp1i1pNw1t3lTOVz+ANk2CLfsrbDVWeLNAUrjurz1MkFs30XWe+VnQkwTnwYtBEUK12 cb1LcefrmR5g2COr/z55Bqq9w5Tb0ZakaTneTYpgX2WBr/QIGiE2YSorDhVuh62W57IRAWxEw9Q4L +ujqP09IXaA2HYMyAsHbfNAfDYkrwofXJ7R5VBs4FGtIlrzM8mjtMR2f9rhpPGDi/8dybX1rtNq1v LT92aZrn3/KzH2qkI8+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngpWk-004YMf-RT; Tue, 19 Apr 2022 15:12:28 +0000 Received: from mail-oi1-f171.google.com ([209.85.167.171]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngoi6-004D73-9Z for linux-arm-kernel@lists.infradead.org; Tue, 19 Apr 2022 14:20:07 +0000 Received: by mail-oi1-f171.google.com with SMTP id r85so13064263oie.7 for ; Tue, 19 Apr 2022 07:20:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VgdRnd9bpdceRif0299S3ykKHSVMUwPtZgbwTlR6fjI=; b=WUZbJEFr22zPZGp2R+yq14W9tmBo9XetjO+FiQnUS6NKcOIntjvyBCtTYLkkJkKZQu UdEikkxkDk56hAlnzq58xdVYwjPFo27COhii2FQOuHJAWfCYttfThYPviPDEi1eCgHx3 2OPOleMsHrvkALD9X3tpGzs/yKeBJ3qfACYIboyNgUHpU9kYpxAISUMpLl05b7lhasSj GB3YtBVc9cuUyDPypSeNX8MNp5XBFA8JCA8qu0mSsrdqc3oaNc4cOUJNpDQyXDgmoUGw dxkSBxMg/sVerNF4lW0mIbjhkagm0wbDx/WHALdzGsedNWyGYmz8gY2+Z1FGNh1F02vc 8FTw== X-Gm-Message-State: AOAM5317Z4Q7vixfftqXi+TBuEBWreNw8S6XhnIExE8luGTkiMfOUIsG HNILjrY1IlwLy+iMGD9T3Q== X-Google-Smtp-Source: ABdhPJz/8eHniA/MbQVrURiit4Y5m329UMTk5wqUlgVlgHQSwRcyGZcRmbiP8oSqsceOmAnEhLvLow== X-Received: by 2002:aca:c056:0:b0:322:4f77:517e with SMTP id q83-20020acac056000000b003224f77517emr8250843oif.18.1650378003722; Tue, 19 Apr 2022 07:20:03 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id q6-20020a056870028600b000d9be0ee766sm5076841oaf.57.2022.04.19.07.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 07:20:03 -0700 (PDT) Received: (nullmailer pid 2490554 invoked by uid 1000); Tue, 19 Apr 2022 14:20:02 -0000 Date: Tue, 19 Apr 2022 09:20:02 -0500 From: Rob Herring To: Aradhya Bhatia Cc: Jyri Sarha , Tomi Valkeinen , Vignesh Raghavendra , Nishanth Menon , DRI Development , Devicetree , Linux ARM Kernel , Linux Kernel , Nikhil Devshatwar Subject: Re: [PATCH 1/2] dt-bindings: display: ti,am65x-dss: Add missing register & interrupt Message-ID: References: <20220419070302.16502-1-a-bhatia1@ti.com> <20220419070302.16502-2-a-bhatia1@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220419070302.16502-2-a-bhatia1@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_072006_434161_AC4D421B X-CRM114-Status: GOOD ( 18.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 19, 2022 at 12:33:01PM +0530, Aradhya Bhatia wrote: > The DSS IP on the ti-am65x soc supports an additional register space, > named "common1". Further. the IP services a maximum number of 2 > interrupts. > > Add the missing register space "common1" and the additional interrupt. > > Signed-off-by: Aradhya Bhatia > --- > .../devicetree/bindings/display/ti/ti,am65x-dss.yaml | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > index 5c7d2cbc4aac..102059e9e0d5 100644 > --- a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > +++ b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml > @@ -26,6 +26,7 @@ properties: > Addresses to each DSS memory region described in the SoC's TRM. > items: > - description: common DSS register area > + - description: common1 DSS register area You've just broken the ABI. New entries have to go on the end. > - description: VIDL1 light video plane > - description: VID video plane > - description: OVR1 overlay manager for vp1 > @@ -36,6 +37,7 @@ properties: > reg-names: > items: > - const: common > + - const: common1 > - const: vidl1 > - const: vid > - const: ovr1 > @@ -64,7 +66,7 @@ properties: > maxItems: 3 > > interrupts: > - maxItems: 1 > + maxItems: 2 Once there is more than 1, we need to know what each entry is and the order. > > power-domains: > maxItems: 1 > @@ -122,13 +124,14 @@ examples: > dss: dss@4a00000 { > compatible = "ti,am65x-dss"; > reg = <0x04a00000 0x1000>, /* common */ > + reg = <0x04a01000 0x1000>, /* common1 */ > <0x04a02000 0x1000>, /* vidl1 */ > <0x04a06000 0x1000>, /* vid */ > <0x04a07000 0x1000>, /* ovr1 */ > <0x04a08000 0x1000>, /* ovr2 */ > <0x04a0a000 0x1000>, /* vp1 */ > <0x04a0b000 0x1000>; /* vp2 */ > - reg-names = "common", "vidl1", "vid", > + reg-names = "common", "common1". "vidl1", "vid", > "ovr1", "ovr2", "vp1", "vp2"; > ti,am65x-oldi-io-ctrl = <&dss_oldi_io_ctrl>; > power-domains = <&k3_pds 67 TI_SCI_PD_EXCLUSIVE>; > @@ -136,7 +139,8 @@ examples: > <&k3_clks 216 1>, > <&k3_clks 67 2>; > clock-names = "fck", "vp1", "vp2"; > - interrupts = ; > + interrupts = , > + ; > ports { > #address-cells = <1>; > #size-cells = <0>; > -- > 2.35.3 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel