From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61D00C433F5 for ; Tue, 12 Apr 2022 10:20:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VsAFqzu5thfzUvyJ66dhcJqZFySd/iSyn/Gv6EmiDE8=; b=F+ULwKxeb+FN4K U4b2CRf/8XF4yvsONvnNMHL1aK0nJR/orPap0Dn/GVyMfFj79pSjPWszmrruXmfZe3cB3Yh6tk3HT 8V2alCFo3LdyQ4Iv9MjlRpzCj1wK4g+ytuv+U/f8ZCJlLEpjz00Ml4dD2e62XG5fjuG+cNT1tD1tA zLI7kdPVjLPnz9mKGclqAgsoiRyWb2kdOrpqoTSnvO9cLCo+T68/uBVfvaVfdi38OTKSojRpY8sOF KDOs+5sGuRVFknLmOKyefBt3w8bNhi/TZbc+uyxaeEf2rWT5MKzFQiFU9dKwHbwEie4kEo71cAtbq Wt6zcRp8Qd6R9Db/tZbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neDc3-00DEhn-HF; Tue, 12 Apr 2022 10:19:07 +0000 Received: from helcar.hmeau.com ([216.24.177.18] helo=fornost.hmeau.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neDbz-00DEf5-1H for linux-arm-kernel@lists.infradead.org; Tue, 12 Apr 2022 10:19:05 +0000 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1neDbi-001uO8-2v; Tue, 12 Apr 2022 20:18:47 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Tue, 12 Apr 2022 18:18:46 +0800 Date: Tue, 12 Apr 2022 18:18:46 +0800 From: Herbert Xu To: Catalin Marinas Cc: Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH 07/10] crypto: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_031903_116573_CE3B5BEC X-CRM114-Status: GOOD ( 10.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 12, 2022 at 11:02:54AM +0100, Catalin Marinas wrote: > > This series does not penalise any architecture. It doesn't even make > arm64 any worse than it currently is. Right, the patch as it stands doesn't change anything. However, it is also broken as it stands. As I said before, CRYPTO_MINALIGN is not something that is guaranteed by the Crypto API, it is simply a statement of whatever kmalloc returns. So if kmalloc is no longer returning CRYPTO_MINALIGN-aligned memory, then those drivers that need this alignment for DMA will break anyway. If you want the Crypto API to guarantee alignment over and above that returned by kmalloc, the correct way is to use cra_alignmask. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel