From: Drew Fustini <dfustini@baylibre.com>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Nishanth Menon <nm@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Dave Gerlach <d-gerlach@ti.com>, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: wkup-m3-ipc: Add ti, set-io-isolation property
Date: Thu, 14 Apr 2022 12:44:40 -0700 [thread overview]
Message-ID: <Ylh5qPs57uruokUh@x1> (raw)
In-Reply-To: <20220414192722.2978837-2-dfustini@baylibre.com>
On Thu, Apr 14, 2022 at 12:27:23PM -0700, Drew Fustini wrote:
> Add documentation for the ti,set-io-isolation DT property on the wkup_m3_ipc
> node which tells the wkup_m3_ipc driver to use the wkup_m3 to enable
> IO Isolation during low power mode transitions on am43xx platforms.
>
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> [dfustini: convert to YAML, make DTS example that passes check]
> Signed-off-by: Drew Fustini <dfustini@baylibre.com>
> ---
> Changes from v2:
> - correct indentation of the 'allOf:' block
>
> Changes from v1:
> - correct typo of 'ti,set-io-isolation' property in subject
> - make 'ti,set-io-isolation' only valid for 'ti,am4372-wkup-m3-ipc'
>
> .../bindings/soc/ti/wkup-m3-ipc.yaml | 78 +++++++++++++++++--
> 1 file changed, 73 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml b/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml
> index 7f4a75c5fcaa..f0ae86250fe4 100644
> --- a/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml
> +++ b/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml
> @@ -24,14 +24,22 @@ description: |+
> A wkup_m3_ipc device node is used to represent the IPC registers within an
> SoC.
>
> - Support for VTT Toggle
> - ==================================
> + Support for VTT Toggle with GPIO pin
> + ====================================
> On some boards like the AM335x EVM-SK and the AM437x GP EVM, a GPIO pin is
> connected to the enable pin on the DDR VTT regulator. This allows the
> regulator to be disabled upon suspend and enabled upon resume. Please note
> that the GPIO pin must be part of the GPIO0 module as only this GPIO module
> is in the wakeup power domain.
>
> + Support for IO Isolation
> + ========================
> + On AM437x SoCs, certain pins can be forced into an alternate state when IO
> + isolation is activated. Those pins have pad control registers prefixed by
> + 'CTRL_CONF_' that contain DS0 (e.g. deep sleep) configuration bits that can
> + override the pin's existing bias (pull-up/pull-down) and value (high/low) when
> + IO isolation is active.
> +
> properties:
> compatible:
> enum:
> @@ -63,6 +71,24 @@ properties:
> $ref: /schemas/types.yaml#/definitions/uint32
> description: GPIO pin connected to enable pin on VTT regulator
>
> + ti,set-io-isolation:
> + type: boolean
> + description:
> + If this property is present, then the wkup_m3_ipc driver will instruct
> + the CM3 firmware to activate IO isolation when suspending to deep sleep.
> + This can be leveraged by a board design to put other devices on the board
> + into a low power state.
> +allOf:
Rob - sorry for the churn. I realize now that there should have been a
blank line before 'allOf:'. Should I send a v4 or (if there are not
other issues) could that just added when applying?
Thank you,
Drew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-14 19:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 19:27 [PATCH v3 0/2] soc: ti: wkup_m3_ipc: Add support for IO Isolation Drew Fustini
2022-04-14 19:27 ` [PATCH v3 1/2] dt-bindings: wkup-m3-ipc: Add ti, set-io-isolation property Drew Fustini
2022-04-14 19:44 ` Drew Fustini [this message]
2022-04-19 13:04 ` Rob Herring
2022-04-14 19:27 ` [PATCH v3 2/2] soc: ti: wkup_m3_ipc: Add support for IO Isolation Drew Fustini
2022-04-21 6:56 ` [PATCH v3 0/2] " Tony Lindgren
2022-04-22 5:10 ` Drew Fustini
2022-04-26 6:45 ` Tony Lindgren
2022-05-03 13:08 ` (subset) " Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ylh5qPs57uruokUh@x1 \
--to=dfustini@baylibre.com \
--cc=d-gerlach@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).