From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 652A8C433EF for ; Thu, 21 Apr 2022 06:25:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+RRGC2UJgdxMc1G1wu9yE+uD+qZYO6owU0S/Xs7msQI=; b=ILO3RbmtI74qHk L1iYJAU6iuQzo8KMy1wJmh5THOjCpQNxWOZFVOxft4N2o4189bLpI+Mbp/99nuRx0pvN9xq/oLPPl fqzvrtBu2i7Uvru8iK25l5oReMeEEvMiP6xoa7vDS9KDtNmrYpAYG1edE6wn9njIOuhnpx8kNZnec jqIqoUi5sf2V0NG6SNEmlTj9zKsK4r3wPOAqbhU/g4l4sWxbzKlGXVX20LQq2jl6gsW2bR0j40LaU /ddcwCoXGZRkAZHRrJ94R5Mr85dAndZylghoj2haDjZsEt9CEYvc+WFlKEfNbaRxpaT5THDzI8una l/lAFXqD5w/UEJMPfqLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhQFB-00BhnS-Fj; Thu, 21 Apr 2022 06:24:45 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhQF8-00Bhkk-80 for linux-arm-kernel@lists.infradead.org; Thu, 21 Apr 2022 06:24:43 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 53E33811B; Thu, 21 Apr 2022 06:21:49 +0000 (UTC) Date: Thu, 21 Apr 2022 09:24:39 +0300 From: Tony Lindgren To: Arnd Bergmann Cc: linux-omap@vger.kernel.org, aaro.koskinen@iki.fi, jmkrzyszt@gmail.com, Arnd Bergmann , Russell King , Paul Walmsley , Kevin Hilman , Peter Ujfalusi , Vinod Koul , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Mark Brown , Felipe Balbi , Alan Stern , Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Linus Walleij , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, dmaengine@vger.kernel.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, linux-serial@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 40/41] [TO BE REBASED] ARM: OMAP1: clock: Convert to CCF Message-ID: References: <20220419133723.1394715-1-arnd@kernel.org> <20220419133723.1394715-41-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220419133723.1394715-41-arnd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_232442_387436_B70DDBFF X-CRM114-Status: GOOD ( 11.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Arnd Bergmann [220419 13:39]: > From: Janusz Krzysztofik > + /* protect clk->enable_reg from concurrent access via clk_set_rate() */ > + if (clk->enable_reg == OMAP1_IO_ADDRESS(ARM_CKCTL)) > + spin_lock_irqsave(&arm_ckctl_lock, flags); > + else if (clk->enable_reg == OMAP1_IO_ADDRESS(ARM_IDLECT2)) > + spin_lock_irqsave(&arm_idlect2_lock, flags); > + else if (clk->enable_reg == OMAP1_IO_ADDRESS(MOD_CONF_CTRL_0)) > + spin_lock_irqsave(&mod_conf_ctrl_0_lock, flags); > + else if (clk->enable_reg == OMAP1_IO_ADDRESS(MOD_CONF_CTRL_1)) > + spin_lock_irqsave(&mod_conf_ctrl_1_lock, flags); > + else if (clk->enable_reg == OMAP1_IO_ADDRESS(SWD_CLK_DIV_CTRL_SEL)) > + spin_lock_irqsave(&swd_clk_div_ctrl_sel_lock, flags); > + Eventually there should be just separate clock controller instances for the clock registers banks, and then this should all disappear as the lock is instance specific. Anyways, that's probably best done as a separate changes later on. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel