From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.lore.kernel.org (Postfix) with ESMTPS id 620BEC433F5
	for <linux-arm-kernel@archiver.kernel.org>; Tue,  3 May 2022 23:53:52 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:
	List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:
	In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:
	Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date
	:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;
	bh=qqqwiWXiBeVEkscGRHNyH/Y4+LN/W3ALiiMxHzxZl2E=; b=HFwqIV0tfdC4AfYqMtsQF3AYCu
	6koV19URMIi9r27ORjjwOo5cfB/FkcxywQAt1UlRq7h4KH7cIx16kdJi4U0pAiFZ1x6pmSZhm59f4
	tsHtbuvHZDeKQztZUKJ8pNOCqDh3lBzpR2PZ5AS+yVKLwuYCUR7Zt115kjdlPwWPsFsXlis/y7lDc
	KnjzMc5okw3Csj7Kj/lB8Lu0975N4PAKs2B5yGqBPHa1XhO9ozHpRjC1Lfcotwmh5YhCVKe2sgJgK
	z3dCLUqrtOAWIravYE8VX9qRNfXw9WfqxBJ2D2OypkILFedoGkn3DVFfjttZvl9kILniKXYJfyF7r
	tU9OEJyg==;
Received: from localhost ([::1] helo=bombadil.infradead.org)
	by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux))
	id 1nm2Jg-0085tH-BT; Tue, 03 May 2022 23:52:28 +0000
Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1])
 by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux))
 id 1nm2Jd-0085se-Bv
 for linux-arm-kernel@lists.infradead.org; Tue, 03 May 2022 23:52:26 +0000
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id B0295617E5;
 Tue,  3 May 2022 23:52:24 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A132C385B1;
 Tue,  3 May 2022 23:52:23 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
 s=k20201202; t=1651621944;
 bh=SWm5tsQRoZWKFpiKOc/x2fsplpE56+E6NZ0o7bJAmkg=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=RdU9Y8o+nSYI2fDTTzPb/0eeyA8P8n2t8XwH/ZL/A2L6LMYHC+lrpim5HoQ8TUboM
 eLQGxYwWYZUl425X46i71rLAc79vcKmTfV3g2AtY+gHVKbmnwysBYfJSdGitKnTepk
 EGP0TBaahqrdZ2tG8DmXoADa7177s/1wWGJZLoVMAOHgxGNM1K25aUQ/9orsmnbxVM
 JfWAE+E+xMU2ZYp+qg+3BlWH3cRDl1KikjaV5QTIgtXBl0sbJrrl8Hewj1kk8AW+FM
 TQukq0DQKpYUpxkwnPxYyVTsjUM2S+ldxRIrLx7frcs0onjGBPaU6CRxvVaE4zD0jX
 eCWQ3z+FHNCWQ==
Date: Wed, 4 May 2022 00:52:20 +0100
From: Mark Brown <broonie@kernel.org>
To: Qian Cai <quic_qiancai@quicinc.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
 Shuah Khan <skhan@linuxfoundation.org>, Shuah Khan <shuah@kernel.org>,
 Basant Kumar Dwivedi <Basant.KumarDwivedi@arm.com>,
 Luis Machado <luis.machado@arm.com>, Szabolcs Nagy <szabolcs.nagy@arm.com>,
 linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org,
 Alan Hayward <alan.hayward@arm.com>, kvmarm@lists.cs.columbia.edu,
 Salil Akerkar <Salil.Akerkar@arm.com>,
 Luca Salabrino <luca.scalabrino@arm.com>
Subject: Re: [PATCH v14 00/39] arm64/sme: Initial support for the Scalable
 Matrix Extension
Message-ID: <YnHANG5cM0CS9ffm@sirena.org.uk>
References: <20220419112247.711548-1-broonie@kernel.org>
 <YnGrbEt3oBBTly7u@qian>
MIME-Version: 1.0
In-Reply-To: <YnGrbEt3oBBTly7u@qian>
X-Cookie: <Culus-> libc6 is not essential :|
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 
X-CRM114-CacheID: sfid-20220503_165225_519518_90F8DEEF 
X-CRM114-Status: GOOD (  20.87  )
X-BeenThere: linux-arm-kernel@lists.infradead.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: <linux-arm-kernel.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, 
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, 
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
Content-Type: multipart/mixed; boundary="===============7004873735102253712=="
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org


--===============7004873735102253712==
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Frr2wg0Yl14gtCx1"
Content-Disposition: inline


--Frr2wg0Yl14gtCx1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, May 03, 2022 at 06:23:40PM -0400, Qian Cai wrote:
> On Tue, Apr 19, 2022 at 12:22:08PM +0100, Mark Brown wrote:
> > This series provides initial support for the ARMv9 Scalable Matrix
> > Extension (SME).  SME takes the approach used for vectors in SVE and
> > extends this to provide architectural support for matrix operations.  A
> > more detailed overview can be found in [1].
>=20
> Set CONFIG_ARM64_SME=3Dn fixed a warning while running libhugetlbfs tests.
>=20
>         /*
>          * There are several places where we assume that the order value =
is sane
>          * so bail out early if the request is out of bound.
>          */
>         if (unlikely(order >=3D MAX_ORDER)) {
>                 WARN_ON_ONCE(!(gfp & __GFP_NOWARN));
>                 return NULL;
>         }

Ugh, right.  These variable sized register sets really don't map
entirely cleanly onto the ptrace interface but now you point it
out what the code has there is going to give a rather larger
number than is sensible.  Not fully checked but does the below
fix things?

Thanks for your testing with this stuff, it's been really
helpful.

diff --git a/arch/arm64/kernel/ptrace.c b/arch/arm64/kernel/ptrace.c
index 47d8a7472171..08c1cb43cf33 100644
--- a/arch/arm64/kernel/ptrace.c
+++ b/arch/arm64/kernel/ptrace.c
@@ -1447,8 +1447,8 @@ static const struct user_regset aarch64_regsets[] =3D=
 {
 	},
 	[REGSET_ZA] =3D { /* SME ZA */
 		.core_note_type =3D NT_ARM_ZA,
-		.n =3D DIV_ROUND_UP(ZA_PT_ZA_SIZE(SVE_VQ_MAX), SVE_VQ_BYTES),
-		.size =3D SVE_VQ_BYTES,
+		.n =3D 1,
+		.size =3D ZA_PT_SIZE(SVE_VQ_MAX),
 		.align =3D SVE_VQ_BYTES,
 		.regset_get =3D za_get,
 		.set =3D za_set,

--Frr2wg0Yl14gtCx1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJxwDMACgkQJNaLcl1U
h9CQsgf/Q4m/iGl8z+mHVPV4t0ivYDXAhsjtBBB7OiPYEhpKxAjxNwbQkSUHmT4u
1Kuv7QBOrp6c+61UQodXcZ3FGTWr/rXqLoRtMEjkVnxxOi4oeeyj65DqsX/WgsH4
yYMtVGGn5ztDOnyX9pYm131Nv0HHObduTAzoSA/SwGFeRhjuuxCiGdoXTnq9foOv
1mflaITdoUCJPHp0gLo3rksyckeMdf6jI0iPs7haJVd8EifLC4/h65P2//YzU8er
LF1CX/sOpOjpHnxMt+EyEIjCMj2eSjdjcJvNrfonaYVR4V3V9rRyCExWHiGdhfsq
Y7Y/mCO5ndmsxPekSdBnlUf5/ksNDQ==
=TMQ4
-----END PGP SIGNATURE-----

--Frr2wg0Yl14gtCx1--


--===============7004873735102253712==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--===============7004873735102253712==--