From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72321C433EF for ; Sat, 7 May 2022 18:51:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j2cvlD0leGP8DQy0NpoYWk1HuFTPhAcfTsXigangj0s=; b=jEHctkEQoU49WV KwrtKrnvp0OYsfVmEmTj82qd2Fyzle8W8I6MBvVD298OzEqVyRKtFvIb5SqvRAb22QkjNkdQE1e9k MGnucf+GRd/kLCBXW1qnvVwiyztWlLTqeDq373JCwmg2IH0eghAkcq8Wn3lxWlGwfALgT8hVFKh0l lv2reSDLG7fAIoOLVWFBJ/R0e/M54i6hKmva3MiwyCQ0jOgGZ21hG8Nm7w9H7FWr7i+XiZHRSMGKr BRTTKtQuAn/S8k0VwmR6tejowUHPflLyznbEy6BcVyiDNUvXXPbFGMf5g/m6zNgEHOIUBe7477sBK WUiDKAKlrLlkcOnONsPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnPVk-00828F-1W; Sat, 07 May 2022 18:50:36 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnPVf-008261-Bl; Sat, 07 May 2022 18:50:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 230A761416; Sat, 7 May 2022 18:50:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CE0BC385A5; Sat, 7 May 2022 18:50:25 +0000 (UTC) Date: Sat, 7 May 2022 19:50:21 +0100 From: Catalin Marinas To: Baoquan He Cc: Zhen Lei , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , linux-kernel@vger.kernel.org, Dave Young , Vivek Goyal , Eric Biederman , kexec@lists.infradead.org, Will Deacon , linux-arm-kernel@lists.infradead.org, Rob Herring , Frank Rowand , devicetree@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou , John Donnelly , Dave Kleikamp Subject: Re: [PATCH v24 3/6] arm64: kdump: Reimplement crashkernel=X Message-ID: References: <20220506114402.365-1-thunder.leizhen@huawei.com> <20220506114402.365-4-thunder.leizhen@huawei.com> <20220506231032.GA122876@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220506231032.GA122876@MiWiFi-R3L-srv> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220507_115031_482994_B71ACC5F X-CRM114-Status: GOOD ( 19.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 07, 2022 at 07:10:32AM +0800, Baoquan He wrote: > On 05/06/22 at 07:43pm, Zhen Lei wrote: > ...... > > @@ -118,8 +162,7 @@ static void __init reserve_crashkernel(void) > > if (crash_base) > > crash_max = crash_base + crash_size; > > > > - /* Current arm64 boot protocol requires 2MB alignment */ > > - crash_base = memblock_phys_alloc_range(crash_size, SZ_2M, > > + crash_base = memblock_phys_alloc_range(crash_size, CRASH_ALIGN, > > crash_base, crash_max); > > if (!crash_base) { > > pr_warn("cannot allocate crashkernel (size:0x%llx)\n", > > @@ -127,6 +170,11 @@ static void __init reserve_crashkernel(void) > > return; > > } > > > > There's corner case missed, e.g > 1) ,high and ,low are specified, CONFIG_ZONE_DMA|DMA32 is not enabled; > 2) ,high and ,low are specified, the whole system memory is under 4G. My view of ,low is that it should only used to override the default ZONE_DMA allocation if that one is not suitable. If no ZONE_DMA exists or everything is ZONE_DMA, ignore it altogether. That's a specialist case for people that know more about the memory layout, otherwise crashkernel=X works in most case with crashkernel=X,high as an alternative to allow high allocation. > I would suggest merging this series, Lei can add this corner case > handling on top. Since this is a newly added support, we don't have > to make it one step. Doing step by step can make reviewing easier. I agree. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel