From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30E08C433EF for ; Wed, 13 Jul 2022 10:47:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=To8IAIfowI2BGa7ibKJUgqhKo89lCMDVfy4nXVeH6NM=; b=s+zSjehBpCbt/D Xrs13XoJ9a+buVD7jHgkk5pcZdfRTKZ4tsn9dpYriD2MpioS40GimDYqtegh88RH9a/Hi0Bu0V8JL yazg3SzKF1nbm/HrzoHm9Ilty/sXSvA9tMvRsHoQjWn1f40fVKRa7G0bsDVthT13/B032QXNWS9NS 1Z8XfbHY3kn/LLCxpC7eLOJp7QisAYHMVEfPB9q0U3vnG9lxiqB1MOC0I2IaX8O2aQhf69TbggYS/ m0ULJIXZuR0RfiFkSAH6C2zHFqrn0JmYqrGn/119lNFgEKDaSCdKfxOrCF86OjdPMVoV5m7m8caxv qFqCtwSNKrxTGwgnuI4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBZsc-002n2f-G3; Wed, 13 Jul 2022 10:46:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBZsZ-002n0e-7S for linux-arm-kernel@lists.infradead.org; Wed, 13 Jul 2022 10:46:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 871DD1424; Wed, 13 Jul 2022 03:45:59 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4D6013F792; Wed, 13 Jul 2022 03:45:58 -0700 (PDT) Date: Wed, 13 Jul 2022 11:45:52 +0100 From: Cristian Marussi To: Christophe JAILLET Cc: Sudeep Holla , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] firmware: arm_scmi: Use the bitmap API to allocate bitmaps Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220713_034603_345010_E4C0C369 X-CRM114-Status: GOOD ( 14.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 08, 2022 at 09:30:01PM +0200, Christophe JAILLET wrote: > Use devm_bitmap_zalloc() instead of hand-writing them. > > It is less verbose and it improves the semantic. > > Signed-off-by: Christophe JAILLET > --- > drivers/firmware/arm_scmi/driver.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index 609ebedee9cb..b1265732d83a 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -1911,8 +1911,8 @@ static int __scmi_xfer_info_init(struct scmi_info *sinfo, > hash_init(info->pending_xfers); > > /* Allocate a bitmask sized to hold MSG_TOKEN_MAX tokens */ > - info->xfer_alloc_table = devm_kcalloc(dev, BITS_TO_LONGS(MSG_TOKEN_MAX), > - sizeof(long), GFP_KERNEL); > + info->xfer_alloc_table = devm_bitmap_zalloc(dev, MSG_TOKEN_MAX, > + GFP_KERNEL); > if (!info->xfer_alloc_table) > return -ENOMEM; > LGTM. Reviewed-by: Cristian Marussi Tested-by: Cristian Marussi Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel