On Mon, Aug 01, 2022 at 11:23:03AM +0800, zhiyong.tao wrote: > On Thu, 2022-07-28 at 12:07 +0100, Mark Brown wrote: > > On Thu, Jul 28, 2022 at 02:27:49PM +0800, Zhiyong Tao wrote: > > > + properties: > > > + regulator-name: > > > + pattern: > > > "^v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$" > > regulator-name should be free form text for the system integrator to > > describe the use of the supply on their board, no constraints should > > be > > placed on it by the regulator. > we put regulator-name here, we describe it by mt6366 datasheet. > we think that it is the common attribute. > So we place it here. No, for the reasons above.