From: Mark Rutland <mark.rutland@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: broonie@kernel.org, catalin.marinas@arm.com, james.morse@arm.com,
kaleshsingh@google.com, madvenka@linux.microsoft.com,
maz@kernel.org, tabba@google.com, will@kernel.org
Subject: Re: [PATCH 3/8] arm64: stacktrace: move SDEI stack helpers to stacktrace code
Date: Thu, 4 Aug 2022 15:38:56 +0100 [thread overview]
Message-ID: <YuvaABYTjAvxt117@FVFF77S0Q05N.cambridge.arm.com> (raw)
In-Reply-To: <20220801121209.2479449-4-mark.rutland@arm.com>
On Mon, Aug 01, 2022 at 01:12:04PM +0100, Mark Rutland wrote:
> diff --git a/arch/arm64/include/asm/stacktrace.h b/arch/arm64/include/asm/stacktrace.h
> index 6ebdcdff77f56..fa2df1ea22ebc 100644
> --- a/arch/arm64/include/asm/stacktrace.h
> +++ b/arch/arm64/include/asm/stacktrace.h
> +#if defined(CONFIG_ARM_SDE_INTERFACE) && defined(CONFIG_VMAP_STACK)
> +DECLARE_PER_CPU(unsigned long *, sdei_stack_normal_ptr);
> +DECLARE_PER_CPU(unsigned long *, sdei_stack_critical_ptr);
> diff --git a/arch/arm64/kernel/sdei.c b/arch/arm64/kernel/sdei.c
> index d20620a1c51a4..881eece3422ca 100644
> --- a/arch/arm64/kernel/sdei.c
> +++ b/arch/arm64/kernel/sdei.c
> @@ -31,9 +31,6 @@ unsigned long sdei_exit_mode;
> * sdei stack.
> * For now, we allocate stacks when the driver is probed.
> */
> -DECLARE_PER_CPU(unsigned long *, sdei_stack_normal_ptr);
> -DECLARE_PER_CPU(unsigned long *, sdei_stack_critical_ptr);
> -
The kbuild test robot reported that removing these lines broke builds with
CONFIG_SDE_INTERFACE=y && CONFIG_VMAP_STACK=n:
https://lore.kernel.org/r/16ba6649-d680-69d4-dbd3-3b1ffb06319b@intel.com
For now I've restored the declarations in sdei.c, as the alternative was to
make the ifdeffery in stacktrace.h more convoluted.
Thanks,
Mark.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-04 14:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 12:12 [PATCH 0/8] arm64: stacktrace: cleanups and improvements Mark Rutland
2022-08-01 12:12 ` [PATCH 1/8] arm64: stacktrace: simplify unwind_next_common() Mark Rutland
2022-08-01 12:46 ` Mark Brown
2022-08-02 4:34 ` Kalesh Singh
2022-08-01 12:12 ` [PATCH 2/8] arm64: stacktrace: rename unwind_next_common() -> unwind_next_frame_record() Mark Rutland
2022-08-01 12:52 ` Mark Brown
2022-08-02 4:38 ` Kalesh Singh
2022-08-01 12:12 ` [PATCH 3/8] arm64: stacktrace: move SDEI stack helpers to stacktrace code Mark Rutland
2022-08-01 12:48 ` Mark Brown
2022-08-02 4:53 ` Kalesh Singh
2022-08-02 12:26 ` Mark Rutland
2022-08-02 16:31 ` Kalesh Singh
2022-08-04 14:38 ` Mark Rutland [this message]
2022-08-01 12:12 ` [PATCH 4/8] arm64: stacktrace: add stackinfo_on_stack() helper Mark Rutland
2022-08-01 15:56 ` Mark Brown
2022-08-02 5:00 ` Kalesh Singh
2022-08-01 12:12 ` [PATCH 5/8] arm64: stacktrace: rework stack boundary discovery Mark Rutland
2022-08-01 17:14 ` Mark Brown
2022-08-02 5:22 ` Kalesh Singh
2022-08-02 12:29 ` Mark Rutland
2022-08-01 12:12 ` [PATCH 6/8] arm64: stacktrace: remove stack type from fp translator Mark Rutland
2022-08-02 5:32 ` Kalesh Singh
2022-08-03 12:36 ` Mark Brown
2022-08-01 12:12 ` [PATCH 7/8] arm64: stacktrace: track all stack boundaries explicitly Mark Rutland
2022-08-02 16:05 ` Kalesh Singh
2022-08-01 12:12 ` [PATCH 8/8] arm64: stacktrace: track hyp stacks in unwinder's address space Mark Rutland
2022-08-02 16:27 ` Kalesh Singh
2022-08-02 17:48 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuvaABYTjAvxt117@FVFF77S0Q05N.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kaleshsingh@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=madvenka@linux.microsoft.com \
--cc=maz@kernel.org \
--cc=tabba@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).